From patchwork Tue Oct 8 08:15:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slavomir Kaslev X-Patchwork-Id: 11179105 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1B348139A for ; Tue, 8 Oct 2019 08:15:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04A9D206BB for ; Tue, 8 Oct 2019 08:15:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730504AbfJHIPp (ORCPT ); Tue, 8 Oct 2019 04:15:45 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:33563 "EHLO mail-wm1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730292AbfJHIPp (ORCPT ); Tue, 8 Oct 2019 04:15:45 -0400 Received: by mail-wm1-f43.google.com with SMTP id r17so1782750wme.0 for ; Tue, 08 Oct 2019 01:15:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ggzDISk7LH3iT4GUg+zgvxMwEIYok/qjd+YPvldLAp0=; b=MIIpSAhkzGoDR/h28A6ZhYbe5+puMnwxHZR4yswSKhpXbYfUh2U9GGJy3cd9gkPnn5 9EnqaCfxR29gxditOjoOse1NqULxPgsLalrsnPDVqfw9LZYAlgdv3Tg9JnCCzQxbBA0N Xf8URxnk+nCGb7PABlwmiNFPUYsv10yAUB439Pf3hs4dJGdenwJYspplp7mG+bClTzFF PVjvqmfQ8OSIXrprF50+4/Uc69KXI5X7E9OLSphOAHweXxp0ymXRHI9sUsUPRrJXYq0g 69id26ARpb6EvAOCsIRg407KeMUazHmpDLrN3bZo5UCXCXdi8IpUD6usopni18ZcQCMp gbXg== X-Gm-Message-State: APjAAAUZj6kXw94PnHjWL5FN2t/ZdkiwWZqlaFBL80q1r+i5OeB8rpgP SnWpJL9qhbdTjsVXn6xBhGEIRMdD3g== X-Google-Smtp-Source: APXvYqxDUO5tQ3H9vsmcbVdPWc6m9zWFf5dmq3u1OGnGEfaNlolfAnT/o1bB7YWW0xikkK2yiTAfKg== X-Received: by 2002:a1c:5f82:: with SMTP id t124mr2875435wmb.114.1570522543944; Tue, 08 Oct 2019 01:15:43 -0700 (PDT) Received: from box.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id f13sm2201440wmj.17.2019.10.08.01.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 01:15:43 -0700 (PDT) From: Slavomir Kaslev To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v15 00/13] Add VM kernel tracing over vsockets and FIFOs Date: Tue, 8 Oct 2019 11:15:24 +0300 Message-Id: <20191008081537.11536-1-kaslevs@vmware.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org This patchset adds support for tracing guest kernels to trace-cmd. Changes in v14 and v15: - rebased on top of latest master - no changes in behavior Changes in v13: - ignore SIGINT in recording processes - add more checks for memory allocation failures Changes in v12: - fix patches' Signed-off-by tags Changes in v11: - fix flushing tracing data bug when doing VM recording Changes in v10: - add support for specifying VMware Workstation guests by name on the command line - add docstring for tracecmd_create_recorder_virt() - add a comment on why we need to poll() in direct_splice_data() Changes in v9: - none Changes in v8: - switched protocol message encoding of ports to text - switched ports data type to unsigned since vsockets port numbers can overflow int and be confused with errors codes by other code - added automatic naming for guests with no names (for VMware Workstation guests currently) - added --debug option to trace-cmd agent Changes in v7: - fixed potential memory leak in add_arg() - call msg_free() in tracecmd_msg_recv_trace_req() eventhough we're stealing the message buffer - added is_guest and is_agent macros and use throughout tracecmd_record.c instead of testing instance->flags bits - avoid memory allocation in make_dir() Changes in v6: - added specialized data transfer path over FIFOs making single splice() per iteration - made tracecmd_msg_recv_trace_req/tracecmd_msg_recv_trace_resp more defensive to invalid messages Changes in v5: - add FIFOs transport for tracing data - fixed a bug in tracecmd_msg_wait_close Changes in v4: - detect and use splice(2) on vsock sockets if possible - switch port numbers to unsigned int - trace-cmd record --date flag is now set for all guests if provided by the user - removed grow_cap and exponential buffer size growth Changes in v3: - addressed Steven's feedback - detect and disable guest tracing if is not available - the --date flag is now treated as global for all guest instances - fixed a bug that caused --date to be ignored for host tracing data when tracing guests Changes in v2: - rebased on top of protocol V3 - fixed system clock timestamps with the --date flag Slavomir Kaslev (12): trace-cmd: Make ports unsigned int trace-cmd: Add tracecmd_create_recorder_virt() function trace-cmd: Add VM tracing protocol messages trace-cmd: Add buffer instance flags for tracing in guest and agent context trace-cmd: Add VM kernel tracing over vsockets transport trace-cmd: Use splice(2) for vsockets if available trace-cmd: Switch stop recording signal to SIGUSR1 trace-cmd: Add `trace-cmd setup-guest` command trace-cmd: Try to autodetect number of guest CPUs in setup-guest if not specified trace-cmd: Add setup-guest flag for attaching FIFOs to the guest VM config trace-cmd: Add VM kernel tracing over FIFO transport trace-cmd: Add support for tracing VMware Workstation VMs by name Steven Rostedt (VMware) (1): trace-cmd: Detect if vsockets are available Makefile | 7 + include/trace-cmd/trace-cmd.h | 34 +- lib/trace-cmd/trace-msg.c | 274 ++++++++++- lib/trace-cmd/trace-recorder.c | 154 ++++-- tracecmd/Makefile | 5 + tracecmd/include/trace-local.h | 29 ++ tracecmd/trace-agent.c | 294 +++++++++++ tracecmd/trace-cmd.c | 4 + tracecmd/trace-listen.c | 10 +- tracecmd/trace-record.c | 875 +++++++++++++++++++++++++++++++-- tracecmd/trace-setup-guest.c | 247 ++++++++++ tracecmd/trace-usage.c | 22 +- 12 files changed, 1848 insertions(+), 107 deletions(-) create mode 100644 tracecmd/trace-agent.c create mode 100644 tracecmd/trace-setup-guest.c