[00/10] rtw88: minor throughput improvement
mbox series

Message ID 20191008082101.2494-1-yhchuang@realtek.com
Headers show
Series
  • rtw88: minor throughput improvement
Related show

Message

Tony Chuang Oct. 8, 2019, 8:20 a.m. UTC
From: Yan-Hsuan Chuang <yhchuang@realtek.com>

This patchset mainly adds support for beamforming and power
tracking. Power tracking can monitor the thermal value of
the device and adjust corresponding power indexes, to make
sure the RF output power is expected.

And another thing is to add a debugfs for physical layer
information. This is useful when sometimes the environment
is too harsh for the device, and provides the activities
for us to debug.

The rest patches are some minor fixes.


Ping-Ke Shih (1):
  rtw88: coex: Set 4 slot mode for A2DP

Tsang-Shian Lin (1):
  rtw88: add phy_info debugfs to show Tx/Rx physical status

Tzu-En Huang (6):
  rtw88: add power tracking support
  rtw88: Enable 802.11ac beamformee support
  rtw88: config 8822c multicast address in MAC init flow
  rtw88: add set_bitrate_mask support
  rtw88: update regulatory settings implementaion
  rtw88: add NL80211_EXT_FEATURE_CAN_REPLACE_PTK0 support

Yan-Hsuan Chuang (2):
  rtw88: Use rtw_write8_set to set SYS_FUNC
  rtw88: pci: config phy after chip info is setup

 drivers/net/wireless/realtek/rtw88/Makefile   |   1 +
 drivers/net/wireless/realtek/rtw88/bf.c       | 408 +++++++++++++++++
 drivers/net/wireless/realtek/rtw88/bf.h       |  92 ++++
 drivers/net/wireless/realtek/rtw88/coex.c     |  24 +-
 drivers/net/wireless/realtek/rtw88/debug.c    | 174 +++++++-
 drivers/net/wireless/realtek/rtw88/debug.h    |   1 +
 drivers/net/wireless/realtek/rtw88/fw.c       |   1 +
 drivers/net/wireless/realtek/rtw88/mac.c      |   2 +-
 drivers/net/wireless/realtek/rtw88/mac.h      |   5 +
 drivers/net/wireless/realtek/rtw88/mac80211.c |  65 +++
 drivers/net/wireless/realtek/rtw88/main.c     | 159 ++++++-
 drivers/net/wireless/realtek/rtw88/main.h     | 155 ++++++-
 drivers/net/wireless/realtek/rtw88/pci.c      |   4 +-
 drivers/net/wireless/realtek/rtw88/phy.c      | 118 +++++
 drivers/net/wireless/realtek/rtw88/phy.h      |  12 +
 drivers/net/wireless/realtek/rtw88/reg.h      |   2 +
 drivers/net/wireless/realtek/rtw88/regd.c     |  61 ++-
 drivers/net/wireless/realtek/rtw88/rtw8822b.c | 413 ++++++++++++++++++
 drivers/net/wireless/realtek/rtw88/rtw8822b.h |  12 +
 drivers/net/wireless/realtek/rtw88/rtw8822c.c | 341 +++++++++++++++
 drivers/net/wireless/realtek/rtw88/rtw8822c.h |  12 +
 drivers/net/wireless/realtek/rtw88/rx.c       |  69 ++-
 22 files changed, 2056 insertions(+), 75 deletions(-)
 create mode 100644 drivers/net/wireless/realtek/rtw88/bf.c
 create mode 100644 drivers/net/wireless/realtek/rtw88/bf.h

Comments

Kalle Valo Oct. 14, 2019, 9:45 a.m. UTC | #1
<yhchuang@realtek.com> writes:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> This patchset mainly adds support for beamforming and power
> tracking. Power tracking can monitor the thermal value of
> the device and adjust corresponding power indexes, to make
> sure the RF output power is expected.
>
> And another thing is to add a debugfs for physical layer
> information. This is useful when sometimes the environment
> is too harsh for the device, and provides the activities
> for us to debug.
>
> The rest patches are some minor fixes.
>
>
> Ping-Ke Shih (1):
>   rtw88: coex: Set 4 slot mode for A2DP
>
> Tsang-Shian Lin (1):
>   rtw88: add phy_info debugfs to show Tx/Rx physical status
>
> Tzu-En Huang (6):
>   rtw88: add power tracking support
>   rtw88: Enable 802.11ac beamformee support
>   rtw88: config 8822c multicast address in MAC init flow
>   rtw88: add set_bitrate_mask support
>   rtw88: update regulatory settings implementaion
>   rtw88: add NL80211_EXT_FEATURE_CAN_REPLACE_PTK0 support
>
> Yan-Hsuan Chuang (2):
>   rtw88: Use rtw_write8_set to set SYS_FUNC
>   rtw88: pci: config phy after chip info is setup

It would be easier for me if you could split the patchsets even more,
for example fixes into one set and new features into another. That way I
can apply the fixes faster. (I now applied five fixes from this set)

And maybe you could even split the new features into smaller sets, or
maybe even just send them one by one once you have a patch ready
(especially on bigger features). That would also make it faster to
review, reviewing big patchsets is pain.

But whenever you submit, just to use wireless-drivers-next as the
baseline, and no extra patches on top of. That way it's for git to
handle conflicts.
Tony Chuang Oct. 15, 2019, 3:23 a.m. UTC | #2
> From: Kalle Valo 
> 
> <yhchuang@realtek.com> writes:
> 
> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >
> > This patchset mainly adds support for beamforming and power
> > tracking. Power tracking can monitor the thermal value of
> > the device and adjust corresponding power indexes, to make
> > sure the RF output power is expected.
> >
> > And another thing is to add a debugfs for physical layer
> > information. This is useful when sometimes the environment
> > is too harsh for the device, and provides the activities
> > for us to debug.
> >
> > The rest patches are some minor fixes.
> >
> >
> > Ping-Ke Shih (1):
> >   rtw88: coex: Set 4 slot mode for A2DP
> >
> > Tsang-Shian Lin (1):
> >   rtw88: add phy_info debugfs to show Tx/Rx physical status
> >
> > Tzu-En Huang (6):
> >   rtw88: add power tracking support
> >   rtw88: Enable 802.11ac beamformee support
> >   rtw88: config 8822c multicast address in MAC init flow
> >   rtw88: add set_bitrate_mask support
> >   rtw88: update regulatory settings implementaion
> >   rtw88: add NL80211_EXT_FEATURE_CAN_REPLACE_PTK0 support
> >
> > Yan-Hsuan Chuang (2):
> >   rtw88: Use rtw_write8_set to set SYS_FUNC
> >   rtw88: pci: config phy after chip info is setup
> 
> It would be easier for me if you could split the patchsets even more,
> for example fixes into one set and new features into another. That way I
> can apply the fixes faster. (I now applied five fixes from this set)
> 
> And maybe you could even split the new features into smaller sets, or
> maybe even just send them one by one once you have a patch ready
> (especially on bigger features). That would also make it faster to
> review, reviewing big patchsets is pain.
> 
> But whenever you submit, just to use wireless-drivers-next as the
> baseline, and no extra patches on top of. That way it's for git to
> handle conflicts.
> 

Sorry, it my fault to mess them into one patch set.
Will try to split them into more sets.
Thanks.

Yan-Hsuan