[v1,0/6] Enable HDR on MCA LSPCON based Gen9 devices
mbox series

Message ID 20191016103249.32121-1-uma.shankar@intel.com
Headers show
Series
  • Enable HDR on MCA LSPCON based Gen9 devices
Related show

Message

Shankar, Uma Oct. 16, 2019, 10:32 a.m. UTC
Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR
support for MCA LSPCON based GEN9 devices.

SOC will drive LSPCON as DP and send HDR metadata as standard
DP SDP packets. LSPCON will be set to operate in PCON mode,
will receive the metadata and create Dynamic Range and
Mastering Infoframe (DRM packets) and send it to HDR capable
HDMI sink devices.

Uma Shankar (6):
  drm/i915/display: Add HDR Capability detection for LSPCON
  drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon
  drm/i915/display: Attach HDR property for capable Gen9 devices
  drm/i915/display: Set HDR Infoframe for HDR capable LSPCON devices
  drm/i915/display: Enable BT2020 for HDR on LSPCON devices
  drm/i915/display: Reduce blanking to support 4k60@10bpp for LSPCON

 drivers/gpu/drm/drm_atomic_state_helper.c     |  1 +
 drivers/gpu/drm/drm_atomic_uapi.c             |  1 +
 drivers/gpu/drm/i915/display/intel_ddi.c      | 10 ++
 .../drm/i915/display/intel_display_types.h    |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 19 +++-
 drivers/gpu/drm/i915/display/intel_hdmi.c     | 33 +++++++
 drivers/gpu/drm/i915/display/intel_lspcon.c   | 91 ++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_lspcon.h   |  7 ++
 include/drm/drm_connector.h                   |  1 +
 9 files changed, 152 insertions(+), 12 deletions(-)

Comments

Ville Syrjälä Oct. 16, 2019, 1:17 p.m. UTC | #1
On Wed, Oct 16, 2019 at 04:02:43PM +0530, Uma Shankar wrote:
> Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR
> support for MCA LSPCON based GEN9 devices.

Couple of general comments about the LSPCON stuff.

a) we need infoframe readout support
b) we need to stop sending infoframes to DVI sinks
c) we need to figure out how to disable the AVI infoframe
   once enabled (if it doesn't get automagically disabled
   when do a modeset), because otherwise when we switch
   displays from HDMI to DVI we will still send the infoframe
   to the DVI sink

I think those should be fixed first before we add more
infoframes to the mix.

Also if we use the SDP stuff for the HDR infoframe we should
just integrate it properly with the already existing DP HDR
metadata stuff. And we need to add readout support for that.
Shankar, Uma Oct. 16, 2019, 2:21 p.m. UTC | #2
>-----Original Message-----
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>Sent: Wednesday, October 16, 2019 6:48 PM
>To: Shankar, Uma <uma.shankar@intel.com>
>Cc: intel-gfx@lists.freedesktop.org; Mun, Gwan-gyeong <gwan-
>gyeong.mun@intel.com>; Sharma, Shashank <shashank.sharma@intel.com>
>Subject: Re: [v1 0/6] Enable HDR on MCA LSPCON based Gen9 devices
>
>On Wed, Oct 16, 2019 at 04:02:43PM +0530, Uma Shankar wrote:
>> Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR
>> support for MCA LSPCON based GEN9 devices.
>
>Couple of general comments about the LSPCON stuff.
>
>a) we need infoframe readout support

We lack that in general for all the DP SDP stuff. Discussed with GG
and hopefully he has plans for DP state readout.

>b) we need to stop sending infoframes to DVI sinks

Sure, will work on this.

>c) we need to figure out how to disable the AVI infoframe
>   once enabled (if it doesn't get automagically disabled
>   when do a modeset), because otherwise when we switch
>   displays from HDMI to DVI we will still send the infoframe
>   to the DVI sink

Ok, will  work on to handle this.

>I think those should be fixed first before we add more infoframes to the mix.
>
>Also if we use the SDP stuff for the HDR infoframe we should just integrate it properly
>with the already existing DP HDR metadata stuff. And we need to add readout support
>for that.

Sure, will discuss with GG to get the state readout for DP SDP.

>--
>Ville Syrjälä
>Intel