Message ID | 20191017133155.5327-1-mreitz@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | iotests: Add and use $SOCK_DIR | expand |
On 10/17/19 8:31 AM, Max Reitz wrote: > Hi, > > Perhaps the main reason we cannot run important tests such as 041 in CI > is that when they care Unix sockets in $TEST_DIR, the path may become > too long to connect to them. > > To get by this problem, this series lets the check script create a new > temporary directory (mktemp -d) and then makes the iotests use it for > all Unix sockets. > > > v2: > - Patch 1: Use mkdir -p I just thought of another potential concern there - what do you think of my response there? Depending on how that thread goes, it may work to just amend the commit or take it as-is without having to go to a full v3 posting... > - Patches 4/23: Only add the $SOCK_DIR replacement line in patch 4 and > only drop the $TEST_DIR line in patch 23 > (Took Eric’s R-b on both because that’s how I interpreted his > comments) Yes, looks like you handled that well. My R-b is okay there.
On 17.10.19 15:31, Max Reitz wrote: > Hi, > > Perhaps the main reason we cannot run important tests such as 041 in CI > is that when they care Unix sockets in $TEST_DIR, the path may become > too long to connect to them. > > To get by this problem, this series lets the check script create a new > temporary directory (mktemp -d) and then makes the iotests use it for > all Unix sockets. > > > v2: > - Patch 1: Use mkdir -p > - Patches 4/23: Only add the $SOCK_DIR replacement line in patch 4 and > only drop the $TEST_DIR line in patch 23 > (Took Eric’s R-b on both because that’s how I interpreted his > comments) Thanks for the rewies, applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max