| Message ID | cover.1571430329.git.hns@goldelico.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | OpenPandora: make wl1251 connected to mmc3 sdio port of OpenPandora work again | expand |
"H. Nikolaus Schaller" <hns@goldelico.com> writes: > Here we have a set of scattered patches to make the OpenPandora WiFi work again. > > v4.7 did break the pdata-quirks which made the mmc3 interface > fail completely, because some code now assumes device tree > based instantiation. > > Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") > > v4.11 did break the sdio qirks for wl1251 which made the driver no longer > load, although the device was found as an sdio client. > > Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") > > To solve these issues: > * we convert mmc3 and wl1251 initialization from pdata-quirks > to device tree > * we make the wl1251 driver read properties from device tree > * we fix the mmc core vendor ids and quirks > * we fix the wl1251 (and wl1271) driver to use only vendor ids > from header file instead of (potentially conflicting) local > definitions > > > H. Nikolaus Schaller (9): > Documentation: dt: wireless: update wl1251 for sdio > net: wireless: ti: wl1251 add device tree support > DTS: ARM: pandora-common: define wl1251 as child node of mmc3 > mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid > of pandora_wl1251_init_card > omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251 > mmc: sdio: fix wl1251 vendor id > mmc: core: fix wl1251 sdio quirks > net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition > net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions I didn't get patches 3-7 so I don't know what they have, but what's the plan how these should be applied? Normally wl1251 patches go via wireless-drivers-next but are you planning something else?
Hi, > Am 19.10.2019 um 13:06 schrieb Kalle Valo <kvalo@codeaurora.org>: > > "H. Nikolaus Schaller" <hns@goldelico.com> writes: > >> Here we have a set of scattered patches to make the OpenPandora WiFi work again. >> >> v4.7 did break the pdata-quirks which made the mmc3 interface >> fail completely, because some code now assumes device tree >> based instantiation. >> >> Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") >> >> v4.11 did break the sdio qirks for wl1251 which made the driver no longer >> load, although the device was found as an sdio client. >> >> Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") >> >> To solve these issues: >> * we convert mmc3 and wl1251 initialization from pdata-quirks >> to device tree >> * we make the wl1251 driver read properties from device tree >> * we fix the mmc core vendor ids and quirks >> * we fix the wl1251 (and wl1271) driver to use only vendor ids >> from header file instead of (potentially conflicting) local >> definitions >> >> >> H. Nikolaus Schaller (9): >> Documentation: dt: wireless: update wl1251 for sdio >> net: wireless: ti: wl1251 add device tree support >> DTS: ARM: pandora-common: define wl1251 as child node of mmc3 >> mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid >> of pandora_wl1251_init_card >> omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251 >> mmc: sdio: fix wl1251 vendor id >> mmc: core: fix wl1251 sdio quirks >> net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition >> net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions > > I didn't get patches 3-7 oh sorry. I don't know why. Here they are all: https://patchwork.kernel.org/cover/11199599/ > so I don't know what they have, but what's the > plan how these should be applied? Normally wl1251 patches go via > wireless-drivers-next but are you planning something else? Well, I have no plan for that except that all should end up fixed in mainline and stable. The issue is that multiple subsystems are involved (net/wireless, mmc and arm/omap) and all patches should be ideally be applied in combination. BR and thanks, Nikolaus
"H. Nikolaus Schaller" <hns@goldelico.com> writes: > Hi, > >> Am 19.10.2019 um 13:06 schrieb Kalle Valo <kvalo@codeaurora.org>: >> >> "H. Nikolaus Schaller" <hns@goldelico.com> writes: >> >>> Here we have a set of scattered patches to make the OpenPandora WiFi work again. >>> >>> v4.7 did break the pdata-quirks which made the mmc3 interface >>> fail completely, because some code now assumes device tree >>> based instantiation. >>> >>> Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") >>> >>> v4.11 did break the sdio qirks for wl1251 which made the driver no longer >>> load, although the device was found as an sdio client. >>> >>> Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") >>> >>> To solve these issues: >>> * we convert mmc3 and wl1251 initialization from pdata-quirks >>> to device tree >>> * we make the wl1251 driver read properties from device tree >>> * we fix the mmc core vendor ids and quirks >>> * we fix the wl1251 (and wl1271) driver to use only vendor ids >>> from header file instead of (potentially conflicting) local >>> definitions >>> >>> >>> H. Nikolaus Schaller (9): >>> Documentation: dt: wireless: update wl1251 for sdio >>> net: wireless: ti: wl1251 add device tree support >>> DTS: ARM: pandora-common: define wl1251 as child node of mmc3 >>> mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid >>> of pandora_wl1251_init_card >>> omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251 >>> mmc: sdio: fix wl1251 vendor id >>> mmc: core: fix wl1251 sdio quirks >>> net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition >>> net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions >> >> I didn't get patches 3-7 > > oh sorry. I don't know why. > > Here they are all: https://patchwork.kernel.org/cover/11199599/ Thanks. >> so I don't know what they have, but what's the >> plan how these should be applied? Normally wl1251 patches go via >> wireless-drivers-next but are you planning something else? > > Well, I have no plan for that except that all should end up fixed in mainline > and stable. > > The issue is that multiple subsystems are involved (net/wireless, mmc and arm/omap) > and all patches should be ideally be applied in combination. Ok, I then assume someone else is going to handle these, wl1251 rarely has any changes so the chance of conflicts is small anyway, and I'll drop the wl1251 patches from my patchwork. For wl1251 patches 1, 2, 8 and 9: Acked-by: Kalle Valo <kvalo@codeaurora.org>
Here we have a set of scattered patches to make the OpenPandora WiFi work again. v4.7 did break the pdata-quirks which made the mmc3 interface fail completely, because some code now assumes device tree based instantiation. Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") v4.11 did break the sdio qirks for wl1251 which made the driver no longer load, although the device was found as an sdio client. Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") To solve these issues: * we convert mmc3 and wl1251 initialization from pdata-quirks to device tree * we make the wl1251 driver read properties from device tree * we fix the mmc core vendor ids and quirks * we fix the wl1251 (and wl1271) driver to use only vendor ids from header file instead of (potentially conflicting) local definitions H. Nikolaus Schaller (9): Documentation: dt: wireless: update wl1251 for sdio net: wireless: ti: wl1251 add device tree support DTS: ARM: pandora-common: define wl1251 as child node of mmc3 mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_card omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251 mmc: sdio: fix wl1251 vendor id mmc: core: fix wl1251 sdio quirks net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions .../bindings/net/wireless/ti,wl1251.txt | 26 +++++++++++++ arch/arm/boot/dts/omap3-pandora-common.dtsi | 37 ++++++++++++++++++- arch/arm/mach-omap2/pdata-quirks.c | 13 +++---- drivers/mmc/core/quirks.h | 7 ++++ drivers/mmc/host/omap_hsmmc.c | 21 +++++++++++ drivers/net/wireless/ti/wl1251/sdio.c | 23 +++++++----- drivers/net/wireless/ti/wlcore/sdio.c | 8 ---- include/linux/mmc/sdio_ids.h | 2 + 8 files changed, 111 insertions(+), 26 deletions(-)