[rdma-next,0/6] CM cleanup
mbox series

Message ID 20191020071559.9743-1-leon@kernel.org
Headers show
Series
  • CM cleanup
Related show

Message

Leon Romanovsky Oct. 20, 2019, 7:15 a.m. UTC
From: Leon Romanovsky <leonro@mellanox.com>

Hi,

This is first part of CM cleanup series needed to effectively
add IBTA Enhanced Connection Establishment (ECE) spec changes.

In this series, we don't do anything major, just small code cleanup
with small change in srpt. This change will allow us to provide
general getter and setter for all CM structures.

Thanks

Leon Romanovsky (6):
  RDMA/cm: Delete unused cm_is_active_peer function
  RDMA/cm: Use specific keyword to check define
  RDMA/cm: Update copyright together with SPDX tag
  RDMA/cm: Delete useless QPN masking
  RDMA/cm: Provide private data size to CM users
  RDMA/srpt: Use private_data_len instead of hardcoded value

 drivers/infiniband/core/cm.c          | 51 ++++++++-------------------
 drivers/infiniband/core/cm_msgs.h     | 32 ++---------------
 drivers/infiniband/core/cma.c         | 31 ++--------------
 drivers/infiniband/ulp/srpt/ib_srpt.c |  2 +-
 include/rdma/ib_cm.h                  | 33 +++--------------
 5 files changed, 24 insertions(+), 125 deletions(-)

--
2.20.1

Comments

Jason Gunthorpe Oct. 28, 2019, 1:17 p.m. UTC | #1
On Sun, Oct 20, 2019 at 10:15:53AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Hi,
> 
> This is first part of CM cleanup series needed to effectively
> add IBTA Enhanced Connection Establishment (ECE) spec changes.
> 
> In this series, we don't do anything major, just small code cleanup
> with small change in srpt. This change will allow us to provide
> general getter and setter for all CM structures.
> 
> Thanks
> 
> Leon Romanovsky (6):
>   RDMA/cm: Delete unused cm_is_active_peer function
>   RDMA/cm: Use specific keyword to check define
>   RDMA/cm: Update copyright together with SPDX tag

Applied to for-next

>   RDMA/cm: Delete useless QPN masking
>   RDMA/cm: Provide private data size to CM users
>   RDMA/srpt: Use private_data_len instead of hardcoded value

These ones probably need a bit more work

Thanks,
Jason
Leon Romanovsky Oct. 28, 2019, 1:20 p.m. UTC | #2
On Mon, Oct 28, 2019 at 10:17:25AM -0300, Jason Gunthorpe wrote:
> On Sun, Oct 20, 2019 at 10:15:53AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Hi,
> >
> > This is first part of CM cleanup series needed to effectively
> > add IBTA Enhanced Connection Establishment (ECE) spec changes.
> >
> > In this series, we don't do anything major, just small code cleanup
> > with small change in srpt. This change will allow us to provide
> > general getter and setter for all CM structures.
> >
> > Thanks
> >
> > Leon Romanovsky (6):
> >   RDMA/cm: Delete unused cm_is_active_peer function
> >   RDMA/cm: Use specific keyword to check define
> >   RDMA/cm: Update copyright together with SPDX tag
>
> Applied to for-next

Thanks

>
> >   RDMA/cm: Delete useless QPN masking
> >   RDMA/cm: Provide private data size to CM users
> >   RDMA/srpt: Use private_data_len instead of hardcoded value
>
> These ones probably need a bit more work

I disagree about that last patch, we don't want to make private_data_len dynamic.

Thanks

>
> Thanks,
> Jason