[v7,0/9] backlight: gpio: simplify the driver
mbox series

Message ID 20191022083630.28175-1-brgl@bgdev.pl
Headers show
Series
  • backlight: gpio: simplify the driver
Related show

Message

Bartosz Golaszewski Oct. 22, 2019, 8:36 a.m. UTC
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

While working on my other series related to gpio-backlight[1] I noticed
that we could simplify the driver if we made the only user of platform
data use GPIO lookups and device properties. This series tries to do
that.

First two patches contain minor fixes. Third patch makes the driver
explicitly drive the GPIO line. Fourth patch adds all necessary data
structures to ecovec24. Patch 5/9 unifies much of the code for both
pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
fields. Last two patches contain additional improvements for the GPIO
backlight driver while we're already modifying it.

I don't have access to this HW but hopefully this works. Only compile
tested.

[1] https://lkml.org/lkml/2019/6/25/900

v1 -> v2:
- rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
- added additional two patches with minor improvements

v2 -> v3:
- in patch 7/7: used initializers to set values for pdata and dev local vars

v3 -> v4:
- rebased on top of v5.4-rc1
- removed changes that are no longer relevant after commit ec665b756e6f
  ("backlight: gpio-backlight: Correct initial power state handling")
- added patch 7/7

v4 -> v5:
- in patch 7/7: added a comment replacing the name of the function being
  pulled into probe()

v5 -> v6:
- added a patch making the driver explicitly set the direction of the GPIO
  to output
- added a patch removing a redundant newline

v6 -> v7:
- renamed the function calculating the new GPIO value for status update
- collected more tags

Bartosz Golaszewski (9):
  backlight: gpio: remove unneeded include
  backlight: gpio: remove stray newline
  backlight: gpio: explicitly set the direction of the GPIO
  sh: ecovec24: add additional properties to the backlight device
  backlight: gpio: simplify the platform data handling
  sh: ecovec24: don't set unused fields in platform data
  backlight: gpio: remove unused fields from platform data
  backlight: gpio: use a helper variable for &pdev->dev
  backlight: gpio: pull gpio_backlight_initial_power_state() into probe

 arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
 drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
 include/linux/platform_data/gpio_backlight.h |   3 -
 3 files changed, 69 insertions(+), 95 deletions(-)

Comments

Bartosz Golaszewski Oct. 22, 2019, 9:29 a.m. UTC | #1
wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> While working on my other series related to gpio-backlight[1] I noticed
> that we could simplify the driver if we made the only user of platform
> data use GPIO lookups and device properties. This series tries to do
> that.
>
> First two patches contain minor fixes. Third patch makes the driver
> explicitly drive the GPIO line. Fourth patch adds all necessary data
> structures to ecovec24. Patch 5/9 unifies much of the code for both
> pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> fields. Last two patches contain additional improvements for the GPIO
> backlight driver while we're already modifying it.
>
> I don't have access to this HW but hopefully this works. Only compile
> tested.
>
> [1] https://lkml.org/lkml/2019/6/25/900
>
> v1 -> v2:
> - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> - added additional two patches with minor improvements
>
> v2 -> v3:
> - in patch 7/7: used initializers to set values for pdata and dev local vars
>
> v3 -> v4:
> - rebased on top of v5.4-rc1
> - removed changes that are no longer relevant after commit ec665b756e6f
>   ("backlight: gpio-backlight: Correct initial power state handling")
> - added patch 7/7
>
> v4 -> v5:
> - in patch 7/7: added a comment replacing the name of the function being
>   pulled into probe()
>
> v5 -> v6:
> - added a patch making the driver explicitly set the direction of the GPIO
>   to output
> - added a patch removing a redundant newline
>
> v6 -> v7:
> - renamed the function calculating the new GPIO value for status update
> - collected more tags
>
> Bartosz Golaszewski (9):
>   backlight: gpio: remove unneeded include
>   backlight: gpio: remove stray newline
>   backlight: gpio: explicitly set the direction of the GPIO
>   sh: ecovec24: add additional properties to the backlight device
>   backlight: gpio: simplify the platform data handling
>   sh: ecovec24: don't set unused fields in platform data
>   backlight: gpio: remove unused fields from platform data
>   backlight: gpio: use a helper variable for &pdev->dev
>   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
>
>  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
>  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
>  include/linux/platform_data/gpio_backlight.h |   3 -
>  3 files changed, 69 insertions(+), 95 deletions(-)
>
> --
> 2.23.0
>

Lee, Daniel, Jingoo,

Jacopo is travelling until November 1st and won't be able to test this
again before this date. Do you think you can pick it up and in case
anything's broken on SH, we can fix it after v5.5-rc1, so that it
doesn't miss another merge window?

Bart
Daniel Thompson Oct. 23, 2019, 3:59 p.m. UTC | #2
On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> >
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > While working on my other series related to gpio-backlight[1] I noticed
> > that we could simplify the driver if we made the only user of platform
> > data use GPIO lookups and device properties. This series tries to do
> > that.
> >
> > First two patches contain minor fixes. Third patch makes the driver
> > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > fields. Last two patches contain additional improvements for the GPIO
> > backlight driver while we're already modifying it.
> >
> > I don't have access to this HW but hopefully this works. Only compile
> > tested.
> >
> > [1] https://lkml.org/lkml/2019/6/25/900
> >
> > v1 -> v2:
> > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > - added additional two patches with minor improvements
> >
> > v2 -> v3:
> > - in patch 7/7: used initializers to set values for pdata and dev local vars
> >
> > v3 -> v4:
> > - rebased on top of v5.4-rc1
> > - removed changes that are no longer relevant after commit ec665b756e6f
> >   ("backlight: gpio-backlight: Correct initial power state handling")
> > - added patch 7/7
> >
> > v4 -> v5:
> > - in patch 7/7: added a comment replacing the name of the function being
> >   pulled into probe()
> >
> > v5 -> v6:
> > - added a patch making the driver explicitly set the direction of the GPIO
> >   to output
> > - added a patch removing a redundant newline
> >
> > v6 -> v7:
> > - renamed the function calculating the new GPIO value for status update
> > - collected more tags
> >
> > Bartosz Golaszewski (9):
> >   backlight: gpio: remove unneeded include
> >   backlight: gpio: remove stray newline
> >   backlight: gpio: explicitly set the direction of the GPIO
> >   sh: ecovec24: add additional properties to the backlight device
> >   backlight: gpio: simplify the platform data handling
> >   sh: ecovec24: don't set unused fields in platform data
> >   backlight: gpio: remove unused fields from platform data
> >   backlight: gpio: use a helper variable for &pdev->dev
> >   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> >
> >  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
> >  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
> >  include/linux/platform_data/gpio_backlight.h |   3 -
> >  3 files changed, 69 insertions(+), 95 deletions(-)
> >
> > --
> > 2.23.0
> >
> 
> Lee, Daniel, Jingoo,
> 
> Jacopo is travelling until November 1st and won't be able to test this
> again before this date. Do you think you can pick it up and in case
> anything's broken on SH, we can fix it after v5.5-rc1, so that it
> doesn't miss another merge window?

Outside of holidays and other emergencies Lee usually collects up the
patches for backlight. I'm not sure when he plans to close things for
v5.5 .


Daniel.
Lee Jones Oct. 24, 2019, 6:47 a.m. UTC | #3
On Wed, 23 Oct 2019, Daniel Thompson wrote:

> On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> > >
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > While working on my other series related to gpio-backlight[1] I noticed
> > > that we could simplify the driver if we made the only user of platform
> > > data use GPIO lookups and device properties. This series tries to do
> > > that.
> > >
> > > First two patches contain minor fixes. Third patch makes the driver
> > > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > > fields. Last two patches contain additional improvements for the GPIO
> > > backlight driver while we're already modifying it.
> > >
> > > I don't have access to this HW but hopefully this works. Only compile
> > > tested.
> > >
> > > [1] https://lkml.org/lkml/2019/6/25/900
> > >
> > > v1 -> v2:
> > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > > - added additional two patches with minor improvements
> > >
> > > v2 -> v3:
> > > - in patch 7/7: used initializers to set values for pdata and dev local vars
> > >
> > > v3 -> v4:
> > > - rebased on top of v5.4-rc1
> > > - removed changes that are no longer relevant after commit ec665b756e6f
> > >   ("backlight: gpio-backlight: Correct initial power state handling")
> > > - added patch 7/7
> > >
> > > v4 -> v5:
> > > - in patch 7/7: added a comment replacing the name of the function being
> > >   pulled into probe()
> > >
> > > v5 -> v6:
> > > - added a patch making the driver explicitly set the direction of the GPIO
> > >   to output
> > > - added a patch removing a redundant newline
> > >
> > > v6 -> v7:
> > > - renamed the function calculating the new GPIO value for status update
> > > - collected more tags
> > >
> > > Bartosz Golaszewski (9):
> > >   backlight: gpio: remove unneeded include
> > >   backlight: gpio: remove stray newline
> > >   backlight: gpio: explicitly set the direction of the GPIO
> > >   sh: ecovec24: add additional properties to the backlight device
> > >   backlight: gpio: simplify the platform data handling
> > >   sh: ecovec24: don't set unused fields in platform data
> > >   backlight: gpio: remove unused fields from platform data
> > >   backlight: gpio: use a helper variable for &pdev->dev
> > >   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> > >
> > >  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
> > >  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
> > >  include/linux/platform_data/gpio_backlight.h |   3 -
> > >  3 files changed, 69 insertions(+), 95 deletions(-)
> > >
> > >
> > 
> > Lee, Daniel, Jingoo,
> > 
> > Jacopo is travelling until November 1st and won't be able to test this
> > again before this date. Do you think you can pick it up and in case
> > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > doesn't miss another merge window?

November 1st (-rc6) will be fine.

I'd rather apply it late-tested than early-non-tested.

Hopefully Jacopo can prioritise testing this on Thursday or Friday,
since Monday will be -rc7 which is really cutting it fine.

> Outside of holidays and other emergencies Lee usually collects up the
> patches for backlight. I'm not sure when he plans to close things for
> v5.5.

In special cases such as these I can remain flexible.
Jacopo Mondi Oct. 24, 2019, 7:17 a.m. UTC | #4
Hello,

On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote:
> On Wed, 23 Oct 2019, Daniel Thompson wrote:
>
> > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> > > >
> > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > >
> > > > While working on my other series related to gpio-backlight[1] I noticed
> > > > that we could simplify the driver if we made the only user of platform
> > > > data use GPIO lookups and device properties. This series tries to do
> > > > that.
> > > >
> > > > First two patches contain minor fixes. Third patch makes the driver
> > > > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > > > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > > > fields. Last two patches contain additional improvements for the GPIO
> > > > backlight driver while we're already modifying it.
> > > >
> > > > I don't have access to this HW but hopefully this works. Only compile
> > > > tested.
> > > >
> > > > [1] https://lkml.org/lkml/2019/6/25/900
> > > >
> > > > v1 -> v2:
> > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > > > - added additional two patches with minor improvements
> > > >
> > > > v2 -> v3:
> > > > - in patch 7/7: used initializers to set values for pdata and dev local vars
> > > >
> > > > v3 -> v4:
> > > > - rebased on top of v5.4-rc1
> > > > - removed changes that are no longer relevant after commit ec665b756e6f
> > > >   ("backlight: gpio-backlight: Correct initial power state handling")
> > > > - added patch 7/7
> > > >
> > > > v4 -> v5:
> > > > - in patch 7/7: added a comment replacing the name of the function being
> > > >   pulled into probe()
> > > >
> > > > v5 -> v6:
> > > > - added a patch making the driver explicitly set the direction of the GPIO
> > > >   to output
> > > > - added a patch removing a redundant newline
> > > >
> > > > v6 -> v7:
> > > > - renamed the function calculating the new GPIO value for status update
> > > > - collected more tags
> > > >
> > > > Bartosz Golaszewski (9):
> > > >   backlight: gpio: remove unneeded include
> > > >   backlight: gpio: remove stray newline
> > > >   backlight: gpio: explicitly set the direction of the GPIO
> > > >   sh: ecovec24: add additional properties to the backlight device
> > > >   backlight: gpio: simplify the platform data handling
> > > >   sh: ecovec24: don't set unused fields in platform data
> > > >   backlight: gpio: remove unused fields from platform data
> > > >   backlight: gpio: use a helper variable for &pdev->dev
> > > >   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> > > >
> > > >  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
> > > >  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
> > > >  include/linux/platform_data/gpio_backlight.h |   3 -
> > > >  3 files changed, 69 insertions(+), 95 deletions(-)
> > > >
> > > >
> > >
> > > Lee, Daniel, Jingoo,
> > >
> > > Jacopo is travelling until November 1st and won't be able to test this
> > > again before this date. Do you think you can pick it up and in case
> > > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > > doesn't miss another merge window?
>
> November 1st (-rc6) will be fine.
>
> I'd rather apply it late-tested than early-non-tested.
>
> Hopefully Jacopo can prioritise testing this on Thursday or Friday,
> since Monday will be -rc7 which is really cutting it fine.

I'll do my best, I'll get home Friday late afternoon :)


>
> > Outside of holidays and other emergencies Lee usually collects up the
> > patches for backlight. I'm not sure when he plans to close things for
> > v5.5.
>
> In special cases such as these I can remain flexible.
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
Lee Jones Oct. 24, 2019, 12:10 p.m. UTC | #5
On Thu, 24 Oct 2019, Jacopo Mondi wrote:
> On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote:
> > On Wed, 23 Oct 2019, Daniel Thompson wrote:

[...]

> > > > Jacopo is travelling until November 1st and won't be able to test this
> > > > again before this date. Do you think you can pick it up and in case
> > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > > > doesn't miss another merge window?
> >
> > November 1st (-rc6) will be fine.
> >
> > I'd rather apply it late-tested than early-non-tested.
> >
> > Hopefully Jacopo can prioritise testing this on Thursday or Friday,
> > since Monday will be -rc7 which is really cutting it fine.
> 
> I'll do my best, I'll get home Friday late afternoon :)

Thanks. We'd all really appreciate it.
Lee Jones Nov. 1, 2019, 8:58 a.m. UTC | #6
On Thu, 24 Oct 2019, Jacopo Mondi wrote:

> Hello,
> 
> On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote:
> > On Wed, 23 Oct 2019, Daniel Thompson wrote:
> >
> > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> > > > >
> > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > >
> > > > > While working on my other series related to gpio-backlight[1] I noticed
> > > > > that we could simplify the driver if we made the only user of platform
> > > > > data use GPIO lookups and device properties. This series tries to do
> > > > > that.
> > > > >
> > > > > First two patches contain minor fixes. Third patch makes the driver
> > > > > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > > > > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > > > > fields. Last two patches contain additional improvements for the GPIO
> > > > > backlight driver while we're already modifying it.
> > > > >
> > > > > I don't have access to this HW but hopefully this works. Only compile
> > > > > tested.
> > > > >
> > > > > [1] https://lkml.org/lkml/2019/6/25/900
> > > > >
> > > > > v1 -> v2:
> > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > > > > - added additional two patches with minor improvements
> > > > >
> > > > > v2 -> v3:
> > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars
> > > > >
> > > > > v3 -> v4:
> > > > > - rebased on top of v5.4-rc1
> > > > > - removed changes that are no longer relevant after commit ec665b756e6f
> > > > >   ("backlight: gpio-backlight: Correct initial power state handling")
> > > > > - added patch 7/7
> > > > >
> > > > > v4 -> v5:
> > > > > - in patch 7/7: added a comment replacing the name of the function being
> > > > >   pulled into probe()
> > > > >
> > > > > v5 -> v6:
> > > > > - added a patch making the driver explicitly set the direction of the GPIO
> > > > >   to output
> > > > > - added a patch removing a redundant newline
> > > > >
> > > > > v6 -> v7:
> > > > > - renamed the function calculating the new GPIO value for status update
> > > > > - collected more tags
> > > > >
> > > > > Bartosz Golaszewski (9):
> > > > >   backlight: gpio: remove unneeded include
> > > > >   backlight: gpio: remove stray newline
> > > > >   backlight: gpio: explicitly set the direction of the GPIO
> > > > >   sh: ecovec24: add additional properties to the backlight device
> > > > >   backlight: gpio: simplify the platform data handling
> > > > >   sh: ecovec24: don't set unused fields in platform data
> > > > >   backlight: gpio: remove unused fields from platform data
> > > > >   backlight: gpio: use a helper variable for &pdev->dev
> > > > >   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> > > > >
> > > > >  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
> > > > >  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
> > > > >  include/linux/platform_data/gpio_backlight.h |   3 -
> > > > >  3 files changed, 69 insertions(+), 95 deletions(-)
> > > > >
> > > > >
> > > >
> > > > Lee, Daniel, Jingoo,
> > > >
> > > > Jacopo is travelling until November 1st and won't be able to test this
> > > > again before this date. Do you think you can pick it up and in case
> > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > > > doesn't miss another merge window?
> >
> > November 1st (-rc6) will be fine.
> >
> > I'd rather apply it late-tested than early-non-tested.
> >
> > Hopefully Jacopo can prioritise testing this on Thursday or Friday,
> > since Monday will be -rc7 which is really cutting it fine.
> 
> I'll do my best, I'll get home Friday late afternoon :)

Welcome home!

Just a little reminder in your inbox. TIA. :)
Jacopo Mondi Nov. 1, 2019, 3:41 p.m. UTC | #7
Hello,
  as promised...

On Fri, Nov 01, 2019 at 08:58:03AM +0000, Lee Jones wrote:
> On Thu, 24 Oct 2019, Jacopo Mondi wrote:
>
> > Hello,
> >
> > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote:
> > > On Wed, 23 Oct 2019, Daniel Thompson wrote:
> > >
> > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> > > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> > > > > >
> > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > >
> > > > > > While working on my other series related to gpio-backlight[1] I noticed
> > > > > > that we could simplify the driver if we made the only user of platform
> > > > > > data use GPIO lookups and device properties. This series tries to do
> > > > > > that.
> > > > > >
> > > > > > First two patches contain minor fixes. Third patch makes the driver
> > > > > > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > > > > > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > > > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > > > > > fields. Last two patches contain additional improvements for the GPIO
> > > > > > backlight driver while we're already modifying it.
> > > > > >
> > > > > > I don't have access to this HW but hopefully this works. Only compile
> > > > > > tested.
> > > > > >
> > > > > > [1] https://lkml.org/lkml/2019/6/25/900
> > > > > >
> > > > > > v1 -> v2:
> > > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > > > > > - added additional two patches with minor improvements
> > > > > >
> > > > > > v2 -> v3:
> > > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars
> > > > > >
> > > > > > v3 -> v4:
> > > > > > - rebased on top of v5.4-rc1
> > > > > > - removed changes that are no longer relevant after commit ec665b756e6f
> > > > > >   ("backlight: gpio-backlight: Correct initial power state handling")
> > > > > > - added patch 7/7
> > > > > >
> > > > > > v4 -> v5:
> > > > > > - in patch 7/7: added a comment replacing the name of the function being
> > > > > >   pulled into probe()
> > > > > >
> > > > > > v5 -> v6:
> > > > > > - added a patch making the driver explicitly set the direction of the GPIO
> > > > > >   to output
> > > > > > - added a patch removing a redundant newline
> > > > > >
> > > > > > v6 -> v7:
> > > > > > - renamed the function calculating the new GPIO value for status update
> > > > > > - collected more tags
> > > > > >
> > > > > > Bartosz Golaszewski (9):
> > > > > >   backlight: gpio: remove unneeded include
> > > > > >   backlight: gpio: remove stray newline
> > > > > >   backlight: gpio: explicitly set the direction of the GPIO
> > > > > >   sh: ecovec24: add additional properties to the backlight device
> > > > > >   backlight: gpio: simplify the platform data handling
> > > > > >   sh: ecovec24: don't set unused fields in platform data
> > > > > >   backlight: gpio: remove unused fields from platform data
> > > > > >   backlight: gpio: use a helper variable for &pdev->dev
> > > > > >   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> > > > > >
> > > > > >  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
> > > > > >  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
> > > > > >  include/linux/platform_data/gpio_backlight.h |   3 -
> > > > > >  3 files changed, 69 insertions(+), 95 deletions(-)
> > > > > >
> > > > > >
> > > > >
> > > > > Lee, Daniel, Jingoo,
> > > > >
> > > > > Jacopo is travelling until November 1st and won't be able to test this
> > > > > again before this date. Do you think you can pick it up and in case
> > > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > > > > doesn't miss another merge window?
> > >
> > > November 1st (-rc6) will be fine.
> > >
> > > I'd rather apply it late-tested than early-non-tested.
> > >
> > > Hopefully Jacopo can prioritise testing this on Thursday or Friday,
> > > since Monday will be -rc7 which is really cutting it fine.
> >
> > I'll do my best, I'll get home Friday late afternoon :)
>
> Welcome home!
>
> Just a little reminder in your inbox. TIA. :)

For the ecovec part:
Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Thanks
   j


>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Bartosz Golaszewski Nov. 4, 2019, 9:22 a.m. UTC | #8
pt., 1 lis 2019 o 16:39 Jacopo Mondi <jacopo@jmondi.org> napisał(a):
>
> Hello,
>   as promised...
>
> On Fri, Nov 01, 2019 at 08:58:03AM +0000, Lee Jones wrote:
> > On Thu, 24 Oct 2019, Jacopo Mondi wrote:
> >
> > > Hello,
> > >
> > > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote:
> > > > On Wed, 23 Oct 2019, Daniel Thompson wrote:
> > > >
> > > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> > > > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> > > > > > >
> > > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > > >
> > > > > > > While working on my other series related to gpio-backlight[1] I noticed
> > > > > > > that we could simplify the driver if we made the only user of platform
> > > > > > > data use GPIO lookups and device properties. This series tries to do
> > > > > > > that.
> > > > > > >
> > > > > > > First two patches contain minor fixes. Third patch makes the driver
> > > > > > > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > > > > > > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > > > > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > > > > > > fields. Last two patches contain additional improvements for the GPIO
> > > > > > > backlight driver while we're already modifying it.
> > > > > > >
> > > > > > > I don't have access to this HW but hopefully this works. Only compile
> > > > > > > tested.
> > > > > > >
> > > > > > > [1] https://lkml.org/lkml/2019/6/25/900
> > > > > > >
> > > > > > > v1 -> v2:
> > > > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > > > > > > - added additional two patches with minor improvements
> > > > > > >
> > > > > > > v2 -> v3:
> > > > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars
> > > > > > >
> > > > > > > v3 -> v4:
> > > > > > > - rebased on top of v5.4-rc1
> > > > > > > - removed changes that are no longer relevant after commit ec665b756e6f
> > > > > > >   ("backlight: gpio-backlight: Correct initial power state handling")
> > > > > > > - added patch 7/7
> > > > > > >
> > > > > > > v4 -> v5:
> > > > > > > - in patch 7/7: added a comment replacing the name of the function being
> > > > > > >   pulled into probe()
> > > > > > >
> > > > > > > v5 -> v6:
> > > > > > > - added a patch making the driver explicitly set the direction of the GPIO
> > > > > > >   to output
> > > > > > > - added a patch removing a redundant newline
> > > > > > >
> > > > > > > v6 -> v7:
> > > > > > > - renamed the function calculating the new GPIO value for status update
> > > > > > > - collected more tags
> > > > > > >
> > > > > > > Bartosz Golaszewski (9):
> > > > > > >   backlight: gpio: remove unneeded include
> > > > > > >   backlight: gpio: remove stray newline
> > > > > > >   backlight: gpio: explicitly set the direction of the GPIO
> > > > > > >   sh: ecovec24: add additional properties to the backlight device
> > > > > > >   backlight: gpio: simplify the platform data handling
> > > > > > >   sh: ecovec24: don't set unused fields in platform data
> > > > > > >   backlight: gpio: remove unused fields from platform data
> > > > > > >   backlight: gpio: use a helper variable for &pdev->dev
> > > > > > >   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> > > > > > >
> > > > > > >  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
> > > > > > >  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
> > > > > > >  include/linux/platform_data/gpio_backlight.h |   3 -
> > > > > > >  3 files changed, 69 insertions(+), 95 deletions(-)
> > > > > > >
> > > > > > >
> > > > > >
> > > > > > Lee, Daniel, Jingoo,
> > > > > >
> > > > > > Jacopo is travelling until November 1st and won't be able to test this
> > > > > > again before this date. Do you think you can pick it up and in case
> > > > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > > > > > doesn't miss another merge window?
> > > >
> > > > November 1st (-rc6) will be fine.
> > > >
> > > > I'd rather apply it late-tested than early-non-tested.
> > > >
> > > > Hopefully Jacopo can prioritise testing this on Thursday or Friday,
> > > > since Monday will be -rc7 which is really cutting it fine.
> > >
> > > I'll do my best, I'll get home Friday late afternoon :)
> >
> > Welcome home!
> >
> > Just a little reminder in your inbox. TIA. :)
>
> For the ecovec part:
> Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>

Thanks Jacopo!

Lee: I hope it's not too late to get it picked up for v5.5?

Best regards,
Bartosz Golaszewski

> Thanks
>    j
>
>
> >
> > --
> > Lee Jones [李琼斯]
> > Linaro Services Technical Lead
> > Linaro.org │ Open source software for ARM SoCs
> > Follow Linaro: Facebook | Twitter | Blog
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Bartosz Golaszewski Nov. 8, 2019, 9:24 a.m. UTC | #9
pon., 4 lis 2019 o 10:22 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
>
> pt., 1 lis 2019 o 16:39 Jacopo Mondi <jacopo@jmondi.org> napisał(a):
> >
> > Hello,
> >   as promised...
> >
> > On Fri, Nov 01, 2019 at 08:58:03AM +0000, Lee Jones wrote:
> > > On Thu, 24 Oct 2019, Jacopo Mondi wrote:
> > >
> > > > Hello,
> > > >
> > > > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote:
> > > > > On Wed, 23 Oct 2019, Daniel Thompson wrote:
> > > > >
> > > > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> > > > > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> > > > > > > >
> > > > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > > > >
> > > > > > > > While working on my other series related to gpio-backlight[1] I noticed
> > > > > > > > that we could simplify the driver if we made the only user of platform
> > > > > > > > data use GPIO lookups and device properties. This series tries to do
> > > > > > > > that.
> > > > > > > >
> > > > > > > > First two patches contain minor fixes. Third patch makes the driver
> > > > > > > > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > > > > > > > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > > > > > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > > > > > > > fields. Last two patches contain additional improvements for the GPIO
> > > > > > > > backlight driver while we're already modifying it.
> > > > > > > >
> > > > > > > > I don't have access to this HW but hopefully this works. Only compile
> > > > > > > > tested.
> > > > > > > >
> > > > > > > > [1] https://lkml.org/lkml/2019/6/25/900
> > > > > > > >
> > > > > > > > v1 -> v2:
> > > > > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > > > > > > > - added additional two patches with minor improvements
> > > > > > > >
> > > > > > > > v2 -> v3:
> > > > > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars
> > > > > > > >
> > > > > > > > v3 -> v4:
> > > > > > > > - rebased on top of v5.4-rc1
> > > > > > > > - removed changes that are no longer relevant after commit ec665b756e6f
> > > > > > > >   ("backlight: gpio-backlight: Correct initial power state handling")
> > > > > > > > - added patch 7/7
> > > > > > > >
> > > > > > > > v4 -> v5:
> > > > > > > > - in patch 7/7: added a comment replacing the name of the function being
> > > > > > > >   pulled into probe()
> > > > > > > >
> > > > > > > > v5 -> v6:
> > > > > > > > - added a patch making the driver explicitly set the direction of the GPIO
> > > > > > > >   to output
> > > > > > > > - added a patch removing a redundant newline
> > > > > > > >
> > > > > > > > v6 -> v7:
> > > > > > > > - renamed the function calculating the new GPIO value for status update
> > > > > > > > - collected more tags
> > > > > > > >
> > > > > > > > Bartosz Golaszewski (9):
> > > > > > > >   backlight: gpio: remove unneeded include
> > > > > > > >   backlight: gpio: remove stray newline
> > > > > > > >   backlight: gpio: explicitly set the direction of the GPIO
> > > > > > > >   sh: ecovec24: add additional properties to the backlight device
> > > > > > > >   backlight: gpio: simplify the platform data handling
> > > > > > > >   sh: ecovec24: don't set unused fields in platform data
> > > > > > > >   backlight: gpio: remove unused fields from platform data
> > > > > > > >   backlight: gpio: use a helper variable for &pdev->dev
> > > > > > > >   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> > > > > > > >
> > > > > > > >  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
> > > > > > > >  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
> > > > > > > >  include/linux/platform_data/gpio_backlight.h |   3 -
> > > > > > > >  3 files changed, 69 insertions(+), 95 deletions(-)
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > > Lee, Daniel, Jingoo,
> > > > > > >
> > > > > > > Jacopo is travelling until November 1st and won't be able to test this
> > > > > > > again before this date. Do you think you can pick it up and in case
> > > > > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > > > > > > doesn't miss another merge window?
> > > > >
> > > > > November 1st (-rc6) will be fine.
> > > > >
> > > > > I'd rather apply it late-tested than early-non-tested.
> > > > >
> > > > > Hopefully Jacopo can prioritise testing this on Thursday or Friday,
> > > > > since Monday will be -rc7 which is really cutting it fine.
> > > >
> > > > I'll do my best, I'll get home Friday late afternoon :)
> > >
> > > Welcome home!
> > >
> > > Just a little reminder in your inbox. TIA. :)
> >
> > For the ecovec part:
> > Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> >
>
> Thanks Jacopo!
>
> Lee: I hope it's not too late to get it picked up for v5.5?
>

Hi, just a gentle ping for this series, because I'm afraid it will
miss yet another merge window.

Thanks in advance!
Bartosz Golaszewski
Lee Jones Nov. 11, 2019, 7:44 a.m. UTC | #10
On Fri, 08 Nov 2019, Bartosz Golaszewski wrote:

> pon., 4 lis 2019 o 10:22 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> >
> > pt., 1 lis 2019 o 16:39 Jacopo Mondi <jacopo@jmondi.org> napisał(a):
> > >
> > > Hello,
> > >   as promised...
> > >
> > > On Fri, Nov 01, 2019 at 08:58:03AM +0000, Lee Jones wrote:
> > > > On Thu, 24 Oct 2019, Jacopo Mondi wrote:
> > > >
> > > > > Hello,
> > > > >
> > > > > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote:
> > > > > > On Wed, 23 Oct 2019, Daniel Thompson wrote:
> > > > > >
> > > > > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> > > > > > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> > > > > > > > >
> > > > > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > > > > >
> > > > > > > > > While working on my other series related to gpio-backlight[1] I noticed
> > > > > > > > > that we could simplify the driver if we made the only user of platform
> > > > > > > > > data use GPIO lookups and device properties. This series tries to do
> > > > > > > > > that.
> > > > > > > > >
> > > > > > > > > First two patches contain minor fixes. Third patch makes the driver
> > > > > > > > > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > > > > > > > > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > > > > > > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > > > > > > > > fields. Last two patches contain additional improvements for the GPIO
> > > > > > > > > backlight driver while we're already modifying it.
> > > > > > > > >
> > > > > > > > > I don't have access to this HW but hopefully this works. Only compile
> > > > > > > > > tested.
> > > > > > > > >
> > > > > > > > > [1] https://lkml.org/lkml/2019/6/25/900
> > > > > > > > >
> > > > > > > > > v1 -> v2:
> > > > > > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > > > > > > > > - added additional two patches with minor improvements
> > > > > > > > >
> > > > > > > > > v2 -> v3:
> > > > > > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars
> > > > > > > > >
> > > > > > > > > v3 -> v4:
> > > > > > > > > - rebased on top of v5.4-rc1
> > > > > > > > > - removed changes that are no longer relevant after commit ec665b756e6f
> > > > > > > > >   ("backlight: gpio-backlight: Correct initial power state handling")
> > > > > > > > > - added patch 7/7
> > > > > > > > >
> > > > > > > > > v4 -> v5:
> > > > > > > > > - in patch 7/7: added a comment replacing the name of the function being
> > > > > > > > >   pulled into probe()
> > > > > > > > >
> > > > > > > > > v5 -> v6:
> > > > > > > > > - added a patch making the driver explicitly set the direction of the GPIO
> > > > > > > > >   to output
> > > > > > > > > - added a patch removing a redundant newline
> > > > > > > > >
> > > > > > > > > v6 -> v7:
> > > > > > > > > - renamed the function calculating the new GPIO value for status update
> > > > > > > > > - collected more tags
> > > > > > > > >
> > > > > > > > > Bartosz Golaszewski (9):
> > > > > > > > >   backlight: gpio: remove unneeded include
> > > > > > > > >   backlight: gpio: remove stray newline
> > > > > > > > >   backlight: gpio: explicitly set the direction of the GPIO
> > > > > > > > >   sh: ecovec24: add additional properties to the backlight device
> > > > > > > > >   backlight: gpio: simplify the platform data handling
> > > > > > > > >   sh: ecovec24: don't set unused fields in platform data
> > > > > > > > >   backlight: gpio: remove unused fields from platform data
> > > > > > > > >   backlight: gpio: use a helper variable for &pdev->dev
> > > > > > > > >   backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> > > > > > > > >
> > > > > > > > >  arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
> > > > > > > > >  drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
> > > > > > > > >  include/linux/platform_data/gpio_backlight.h |   3 -
> > > > > > > > >  3 files changed, 69 insertions(+), 95 deletions(-)
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > > Lee, Daniel, Jingoo,
> > > > > > > >
> > > > > > > > Jacopo is travelling until November 1st and won't be able to test this
> > > > > > > > again before this date. Do you think you can pick it up and in case
> > > > > > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > > > > > > > doesn't miss another merge window?
> > > > > >
> > > > > > November 1st (-rc6) will be fine.
> > > > > >
> > > > > > I'd rather apply it late-tested than early-non-tested.
> > > > > >
> > > > > > Hopefully Jacopo can prioritise testing this on Thursday or Friday,
> > > > > > since Monday will be -rc7 which is really cutting it fine.
> > > > >
> > > > > I'll do my best, I'll get home Friday late afternoon :)
> > > >
> > > > Welcome home!
> > > >
> > > > Just a little reminder in your inbox. TIA. :)
> > >
> > > For the ecovec part:
> > > Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > >
> >
> > Thanks Jacopo!
> >
> > Lee: I hope it's not too late to get it picked up for v5.5?
> >
> 
> Hi, just a gentle ping for this series, because I'm afraid it will
> miss yet another merge window.

I have it marked to handle it, along with 10's of others.
Lee Jones Nov. 11, 2019, 11:41 a.m. UTC | #11
On Tue, 22 Oct 2019, Bartosz Golaszewski wrote:

> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> While working on my other series related to gpio-backlight[1] I noticed
> that we could simplify the driver if we made the only user of platform
> data use GPIO lookups and device properties. This series tries to do
> that.
> 
> First two patches contain minor fixes. Third patch makes the driver
> explicitly drive the GPIO line. Fourth patch adds all necessary data
> structures to ecovec24. Patch 5/9 unifies much of the code for both
> pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> fields. Last two patches contain additional improvements for the GPIO
> backlight driver while we're already modifying it.

All applied, thanks.