mbox series

[00/18] xfs_scrub: remove moveon space aliens

Message ID 157177022106.1461658.18024534947316119946.stgit@magnolia (mailing list archive)
Headers show
Series xfs_scrub: remove moveon space aliens | expand

Message

Darrick J. Wong Oct. 22, 2019, 6:50 p.m. UTC
Hi all,

This series replaces the unfamiliar boolean variable return values in
xfs_scrub with the somewhat more customary "positive error value or
zero" semantics that are used throughout the rest of xfsprogs.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=scrub-remove-moveon

Comments

Eric Sandeen Nov. 6, 2019, 10:24 p.m. UTC | #1
On 10/22/19 1:50 PM, Darrick J. Wong wrote:
> Hi all,
> 
> This series replaces the unfamiliar boolean variable return values in
> xfs_scrub with the somewhat more customary "positive error value or
> zero" semantics that are used throughout the rest of xfsprogs.
> 
> If you're going to start using this mess, you probably ought to just
> pull from my git trees, which are linked below.
> 
> This is an extraordinary way to destroy everything.  Enjoy!
> Comments and questions are, as always, welcome.
> 
> --D

I had to slightly adjust a couple more patches but modulo eyes glazing
over a bit, this looks ok so for the whole series:

Reviewed-by: Eric Sandeen <sandeen@redhat.com>