| Message ID | 20191022224922.28144-1-sean.j.christopherson@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | x86/sgx: More cleanup for v23 | expand |
On Tue, Oct 22, 2019 at 03:49:19PM -0700, Sean Christopherson wrote: > Two small enchancements, and a rework of the sgx_free_page() split that > was sent in a previous series. > > Sean Christopherson (3): > x86/sgx: Update the free page count in a single operation > x86/sgx: Do not add in-use EPC page to the free page list > x86/sgx: Move reclaim logic out of sgx_free_page() > > arch/x86/kernel/cpu/sgx/encl.c | 3 ++- > arch/x86/kernel/cpu/sgx/main.c | 36 +++++++++---------------------- > arch/x86/kernel/cpu/sgx/reclaim.c | 32 +++++++++++++++++++++++++++ > arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- > 4 files changed, 46 insertions(+), 28 deletions(-) > > -- > 2.22.0 > I think these should be now merged. Always have to do a lot of tweaking to keep diff's straight with these three commits: 1. x86/sgx: Add functions to allocate and free EPC pages 2. x86/sgx: Linux Enclave Driver 3. x86/sgx: Add a page reclaimer If something is different the only reason is most likely that the difference is just side-product of the patch adjustment. I haven't made my own mods on purpose. /Jarkko
On Thu, Oct 24, 2019 at 09:35:32PM +0300, Jarkko Sakkinen wrote: > On Tue, Oct 22, 2019 at 03:49:19PM -0700, Sean Christopherson wrote: > > Two small enchancements, and a rework of the sgx_free_page() split that > > was sent in a previous series. > > > > Sean Christopherson (3): > > x86/sgx: Update the free page count in a single operation > > x86/sgx: Do not add in-use EPC page to the free page list > > x86/sgx: Move reclaim logic out of sgx_free_page() > > > > arch/x86/kernel/cpu/sgx/encl.c | 3 ++- > > arch/x86/kernel/cpu/sgx/main.c | 36 +++++++++---------------------- > > arch/x86/kernel/cpu/sgx/reclaim.c | 32 +++++++++++++++++++++++++++ > > arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- > > 4 files changed, 46 insertions(+), 28 deletions(-) > > > > -- > > 2.22.0 > > > > I think these should be now merged. Always have to do a lot of tweaking > to keep diff's straight with these three commits: > > 1. x86/sgx: Add functions to allocate and free EPC pages > 2. x86/sgx: Linux Enclave Driver > 3. x86/sgx: Add a page reclaimer > > If something is different the only reason is most likely that the > difference is just side-product of the patch adjustment. I haven't > made my own mods on purpose. Diff looks good and smoke test ran clean.
On Thu, Oct 24, 2019 at 01:22:22PM -0700, Sean Christopherson wrote: > On Thu, Oct 24, 2019 at 09:35:32PM +0300, Jarkko Sakkinen wrote: > > On Tue, Oct 22, 2019 at 03:49:19PM -0700, Sean Christopherson wrote: > > > Two small enchancements, and a rework of the sgx_free_page() split that > > > was sent in a previous series. > > > > > > Sean Christopherson (3): > > > x86/sgx: Update the free page count in a single operation > > > x86/sgx: Do not add in-use EPC page to the free page list > > > x86/sgx: Move reclaim logic out of sgx_free_page() > > > > > > arch/x86/kernel/cpu/sgx/encl.c | 3 ++- > > > arch/x86/kernel/cpu/sgx/main.c | 36 +++++++++---------------------- > > > arch/x86/kernel/cpu/sgx/reclaim.c | 32 +++++++++++++++++++++++++++ > > > arch/x86/kernel/cpu/sgx/sgx.h | 3 ++- > > > 4 files changed, 46 insertions(+), 28 deletions(-) > > > > > > -- > > > 2.22.0 > > > > > > > I think these should be now merged. Always have to do a lot of tweaking > > to keep diff's straight with these three commits: > > > > 1. x86/sgx: Add functions to allocate and free EPC pages > > 2. x86/sgx: Linux Enclave Driver > > 3. x86/sgx: Add a page reclaimer > > > > If something is different the only reason is most likely that the > > difference is just side-product of the patch adjustment. I haven't > > made my own mods on purpose. > > Diff looks good and smoke test ran clean. Great! /Jarkko