From patchwork Fri Oct 25 05:14:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 11211325 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 28FD913BD for ; Fri, 25 Oct 2019 05:14:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECA8821D71 for ; Fri, 25 Oct 2019 05:14:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ItQ67ytT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391798AbfJYFOv (ORCPT ); Fri, 25 Oct 2019 01:14:51 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:45228 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729081AbfJYFOv (ORCPT ); Fri, 25 Oct 2019 01:14:51 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9P5Dkg2123722 for ; Fri, 25 Oct 2019 05:14:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : mime-version : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=rYBvfadBAmtbmY7aNbAPAKCvSVKq8sgWHPxyO6G482I=; b=ItQ67ytT2WaDKXWFbexZZL9a9p+RfqvUfAJgpSREDMur7HDUNWvPw7Bv8994oILxMwGM 4CCu8EqEzL2ZYdphsE4RRDRS8irCN2pz4wPnmaRlELc7zFQSJewa9bsaaZYGqK2lLC6h qOPQ8f1nPG0GznboziEBjjHVkRvFGo+uhGJ202JaxIs9Ct4nJaxMzyAVO7ML+7rLTT+e 9WK5ASc6Y7TU1ZvRTuHNLUfw1Ssors0d/6dK1nc1hfUYUi1M2KAHoYQwD2OFg6/ieH5j d9eMRWIuw9IJBh0u5NFG9PToQr1xe8V1QuCEo3K0XhrrD/0mBgBC8XHNpBSYgcJNpU9h 2g== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2vqswu08ks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 25 Oct 2019 05:14:49 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9P5EEjG160738 for ; Fri, 25 Oct 2019 05:14:49 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2vug0d8vsx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 25 Oct 2019 05:14:49 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9P5EmA8001868 for ; Fri, 25 Oct 2019 05:14:48 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 24 Oct 2019 22:14:48 -0700 Subject: [PATCH 0/4] xfs: more metadata verifier tightening From: "Darrick J. Wong" To: darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org Date: Thu, 24 Oct 2019 22:14:45 -0700 Message-ID: <157198048552.2873445.18067788660614948888.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9420 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=905 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910250050 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9420 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910250050 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Hi all, Here are some enhancements I made to the metadata verifiers. The first adds structure checking to the attr leaf verifier. The next two look for obviously invalid dirent and attr names before passing them up to the VFS. The fourth patch fixes some problems where we return EIO on metadata corruption instead of EFSCORRUPTED. If you're going to start using this mess, you probably ought to just pull from my git trees, which are linked below. This is an extraordinary way to destroy everything. Enjoy! Comments and questions are, as always, welcome. --D kernel git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=tighten-verifiers