[v2,00/10] Add quota support to UBIFS
mbox series

Message ID 20191030152702.14269-1-s.hauer@pengutronix.de
Headers show
  • Add quota support to UBIFS
Related show


Sascha Hauer Oct. 30, 2019, 3:26 p.m. UTC
This series adds quota support to UBIFS.

It's been a while since I last time posted this series. Here's an update
with the review feedback I received integrated. There are quite some
if(!inode) sprinkled in the quota code, maybe this could be done more
clever. I think this series is a good improvement to the last one I sent
though, so I decided to send it out like this for now.

This series follows a very simple approach to quota: Neither the quota
limits nor the quota usage are ever written to the medium. The quota
usage is reconstructed from the filesystem during mount time. The quota
limits must be set by the user each time after mount. This is probably
not very convenient for systems that are used interactively, but UBIFS
is targetted to embedded systems and here running a script after mount
shouldn't be a problem. This of course isn't the way quota was thought
to be, but I believe this is a good compromise for a feature that I predict
is only rarely used on UBIFS. The big upside of this approach is that
no on-disk format changes are required and thus we can't get any
broken/corrupt filesystems because of quota support. Reconstructing the
quota data each time during mount has an noticable but I think for many
cases acceptable time overhead. I mounted a ~56MiB rootfs with 1920 files
which takes around 0.7s longer when quota is enabled.

As UBIFS works on mtd there is no block_device involved. The quotactl
system call requires a path to a block device as argument. To overcome
this we add support for passing the mount point instead. This is done
with a new Q_PATH flag to the quotactl syscall indicating that the special
argument belongs to the mount path rather than a path to the block device

The UBIFS quota support itself is based on a series by Dongsheng Yang
posted here:
This part hasn't changed much, except that the code for reading and writing
quota files has been dropped.


Changes since v1:
- Introduce Q_PATH flag to make passing a mountpath explicit
- Do not mess with fs layer as suggested by Al Viro
- create separate usrquota, grpquota and prjquota options rather than just
  a single quota option
- register a UBIFS specific quota_format and use dquot_enable()
- drop "quota: Only module_put the format when existing" which is no
  longer necesary

Sascha Hauer (10):
  quota: Make inode optional
  quota: Pass sb to vfs_load_quota_inode()
  quota: Introduce dquot_enable_sb()
  quota: Allow to pass mount path to quotactl
  ubifs: move checks and preparation into setflags()
  ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls
  ubifs: do not ubifs_inode() on potentially NULL pointer
  ubifs: Add support for project id
  ubifs: export get_znode
  ubifs: Add quota support

 Documentation/filesystems/ubifs.txt |   7 +-
 fs/quota/dquot.c                    |  66 ++-
 fs/quota/quota.c                    |  37 +-
 fs/ubifs/Makefile                   |   1 +
 fs/ubifs/dir.c                      |  31 +-
 fs/ubifs/file.c                     |  43 ++
 fs/ubifs/ioctl.c                    | 222 +++++++++-
 fs/ubifs/journal.c                  |   4 +-
 fs/ubifs/quota.c                    | 609 ++++++++++++++++++++++++++++
 fs/ubifs/super.c                    |  83 +++-
 fs/ubifs/tnc.c                      |  34 +-
 fs/ubifs/ubifs-media.h              |   6 +-
 fs/ubifs/ubifs.h                    |  42 ++
 include/linux/quotaops.h            |   2 +
 include/uapi/linux/quota.h          |   2 +
 15 files changed, 1110 insertions(+), 79 deletions(-)
 create mode 100644 fs/ubifs/quota.c