[0/3] xfs: tidy up corruption reporting

Message

Darrick J. Wong Nov. 3, 2019, 10:23 p.m. UTC

Hi all,

Linus requested that I audit the XFS code base to make sure that we
always log something to dmesg when returning EFSCORRUPTED or EFSBADCRC
to userspace.  These patches are the results of that audit.

The first three patches start by refactoring a few helper methods so
that in the third patch we always report something to dmesg whenever we
decide to return EFSCORRUPTED.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This has been lightly tested with fstests.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=report-corruption

Comments

Christoph Hellwig Nov. 4, 2019, 3:22 p.m. UTC | #1

On Sun, Nov 03, 2019 at 02:23:43PM -0800, Darrick J. Wong wrote:
> Hi all,
> 
> Linus requested that I audit the XFS code base to make sure that we
> always log something to dmesg when returning EFSCORRUPTED or EFSBADCRC
> to userspace.  These patches are the results of that audit.

Do you have a reference to that discussion?

Darrick J. Wong Nov. 4, 2019, 4:34 p.m. UTC | #2

On Mon, Nov 04, 2019 at 07:22:22AM -0800, Christoph Hellwig wrote:
> On Sun, Nov 03, 2019 at 02:23:43PM -0800, Darrick J. Wong wrote:
> > Hi all,
> > 
> > Linus requested that I audit the XFS code base to make sure that we
> > always log something to dmesg when returning EFSCORRUPTED or EFSBADCRC
> > to userspace.  These patches are the results of that audit.
> 
> Do you have a reference to that discussion?

https://lore.kernel.org/linux-xfs/CAHk-=[e-mail]/

--D