[PATCHv2,00/22] crypto: omap-sham: fixes towards 5.5
mbox series

Message ID 20191105140111.20285-1-t-kristo@ti.com
Headers show
Series
  • crypto: omap-sham: fixes towards 5.5
Related show

Message

Tero Kristo Nov. 5, 2019, 2 p.m. UTC
Hi,

This series applies on top of the skcipher API conversion patch from Ard
Biesheuvel [1].

Fixes any known OMAP crypto issues with the crypto manager test suite,
including the extra tests. Tested via ipsec, tcrypt and with an
rmmod/modprobe loop while the extra tests for crypto manager are enabled.

Couple of additional bug fixes are also done, like proper cleanup of the
sysfs entries, and huge data handling for SHA.

Please note patch #9 is not related to omap-crypto, just a nice to have
tweak for testing purposes. I find it quite annoying myself that if
the HW engine is broken for some reason and hangs, the crypto manager
test suite does not throw any failure for that but just hangs itself
also.

-Tero

[1] https://patchwork.kernel.org/patch/11188595/


--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Comments

Tero Kristo Dec. 11, 2019, 8:06 a.m. UTC | #1
On 05/11/2019 16:00, Tero Kristo wrote:
> Hi,
> 
> This series applies on top of the skcipher API conversion patch from Ard
> Biesheuvel [1].
> 
> Fixes any known OMAP crypto issues with the crypto manager test suite,
> including the extra tests. Tested via ipsec, tcrypt and with an
> rmmod/modprobe loop while the extra tests for crypto manager are enabled.
> 
> Couple of additional bug fixes are also done, like proper cleanup of the
> sysfs entries, and huge data handling for SHA.
> 
> Please note patch #9 is not related to omap-crypto, just a nice to have
> tweak for testing purposes. I find it quite annoying myself that if
> the HW engine is broken for some reason and hangs, the crypto manager
> test suite does not throw any failure for that but just hangs itself
> also.
> 
> -Tero
> 
> [1] https://patchwork.kernel.org/patch/11188595/

Herbert, are you planning to pick these for 5.6? These apply cleanly on 
top of 5.5-rc1.

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Herbert Xu Dec. 11, 2019, 8:12 a.m. UTC | #2
On Wed, Dec 11, 2019 at 10:06:41AM +0200, Tero Kristo wrote:
>
> Herbert, are you planning to pick these for 5.6? These apply cleanly on top
> of 5.5-rc1.

Sorry, I had dropped them because I thought they depended on the
crypto_wait_req patch.  I see now that there is no dependency.

I'll add them to this week's batch.

Cheers,
Tero Kristo Dec. 11, 2019, 8:40 a.m. UTC | #3
On 11/12/2019 10:12, Herbert Xu wrote:
> On Wed, Dec 11, 2019 at 10:06:41AM +0200, Tero Kristo wrote:
>>
>> Herbert, are you planning to pick these for 5.6? These apply cleanly on top
>> of 5.5-rc1.
> 
> Sorry, I had dropped them because I thought they depended on the
> crypto_wait_req patch.  I see now that there is no dependency.
> 
> I'll add them to this week's batch.

Ok thanks, just remember to drop patch #9 out of it.

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Herbert Xu Dec. 11, 2019, 9:42 a.m. UTC | #4
On Tue, Nov 05, 2019 at 04:00:49PM +0200, Tero Kristo wrote:
> Hi,
> 
> This series applies on top of the skcipher API conversion patch from Ard
> Biesheuvel [1].
> 
> Fixes any known OMAP crypto issues with the crypto manager test suite,
> including the extra tests. Tested via ipsec, tcrypt and with an
> rmmod/modprobe loop while the extra tests for crypto manager are enabled.
> 
> Couple of additional bug fixes are also done, like proper cleanup of the
> sysfs entries, and huge data handling for SHA.
> 
> Please note patch #9 is not related to omap-crypto, just a nice to have
> tweak for testing purposes. I find it quite annoying myself that if
> the HW engine is broken for some reason and hangs, the crypto manager
> test suite does not throw any failure for that but just hangs itself
> also.
> 
> -Tero
> 
> [1] https://patchwork.kernel.org/patch/11188595/

All applied except for patch 9.  Thanks.