[0/2] block: Fix multiple blockdev-snapshot calls
mbox series

Message ID 20191108085312.27049-1-kwolf@redhat.com
Headers show
Series
  • block: Fix multiple blockdev-snapshot calls
Related show

Message

Kevin Wolf Nov. 8, 2019, 8:53 a.m. UTC
Kevin Wolf (2):
  block: Remove 'backing': null from bs->{explicit_,}options
  iotests: Test multiple blockdev-snapshot calls

 block.c                    |   2 +
 tests/qemu-iotests/273     |  76 +++++++++
 tests/qemu-iotests/273.out | 337 +++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/group   |   1 +
 4 files changed, 416 insertions(+)
 create mode 100755 tests/qemu-iotests/273
 create mode 100644 tests/qemu-iotests/273.out

Comments

Peter Krempa Nov. 18, 2019, 4:26 p.m. UTC | #1
On Fri, Nov 08, 2019 at 09:53:10 +0100, Kevin Wolf wrote:
> Kevin Wolf (2):
>   block: Remove 'backing': null from bs->{explicit_,}options
>   iotests: Test multiple blockdev-snapshot calls

Hi,

I'm not sure how the freeze rules for qemu are at this point thus:

Will this patchset make it into 4.2. I argue it's a pretty important fix
as it ends up in image corruption.

If it won't make into we will need to add a QMP feature flag to detect
presence of the fix so that I can gate libvirt's support of blockdev
with it. (This can also be done if we make it into 4.2 but I'll be okay
infering it from other fixes present in 4.2).

Thanks

Peter
Kevin Wolf Nov. 18, 2019, 4:49 p.m. UTC | #2
Am 18.11.2019 um 17:26 hat Peter Krempa geschrieben:
> On Fri, Nov 08, 2019 at 09:53:10 +0100, Kevin Wolf wrote:
> > Kevin Wolf (2):
> >   block: Remove 'backing': null from bs->{explicit_,}options
> >   iotests: Test multiple blockdev-snapshot calls
> 
> Hi,
> 
> I'm not sure how the freeze rules for qemu are at this point thus:
> 
> Will this patchset make it into 4.2. I argue it's a pretty important fix
> as it ends up in image corruption.
> 
> If it won't make into we will need to add a QMP feature flag to detect
> presence of the fix so that I can gate libvirt's support of blockdev
> with it. (This can also be done if we make it into 4.2 but I'll be okay
> infering it from other fixes present in 4.2).

Yes, this is planned for 4.2. I'm in the process of preparing a pull
request right now.

Kevin