mbox series

[0/2] getting rid of sha1_to_hex()

Message ID 20191111090332.GA2275@sigill.intra.peff.net (mailing list archive)
Headers show
Series getting rid of sha1_to_hex() | expand

Message

Jeff King Nov. 11, 2019, 9:03 a.m. UTC 
I happened to be looking at the oid_to_hex() family of functions today,
and noticed that we can drop some of the sha1-specific ones.

It's a minor cleanup in terms of text, but it feels like a nice
milestone. :)

  [1/2]: hex: drop sha1_to_hex_r()
  [2/2]: hex: drop sha1_to_hex()

 cache.h                            |  4 +---
 contrib/coccinelle/object_id.cocci | 32 ------------------------------
 hex.c                              | 10 ----------
 sha1dc_git.c                       |  2 +-
 4 files changed, 2 insertions(+), 46 deletions(-)

-Peff

Comments

Junio C Hamano Nov. 11, 2019, 9:09 a.m. UTC | #1 
Jeff King <peff@peff.net> writes:

> I happened to be looking at the oid_to_hex() family of functions today,
> and noticed that we can drop some of the sha1-specific ones.
>
> It's a minor cleanup in terms of text, but it feels like a nice
> milestone. :)
>
>   [1/2]: hex: drop sha1_to_hex_r()
>   [2/2]: hex: drop sha1_to_hex()

Nice indeed.

Thanks, Brian! ;-)  oh, and Peff, of courese ;-)
Jeff King Nov. 11, 2019, 9:21 a.m. UTC | #2 
On Mon, Nov 11, 2019 at 06:09:10PM +0900, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > I happened to be looking at the oid_to_hex() family of functions today,
> > and noticed that we can drop some of the sha1-specific ones.
> >
> > It's a minor cleanup in terms of text, but it feels like a nice
> > milestone. :)
> >
> >   [1/2]: hex: drop sha1_to_hex_r()
> >   [2/2]: hex: drop sha1_to_hex()
> 
> Nice indeed.
> 
> Thanks, Brian! ;-)  oh, and Peff, of courese ;-)

I actually worried that I might be stealing brian's thunder. But AFAICT
this cleanup has been waiting for almost a year, so I figured it was
fair game. :)

-Peff
brian m. carlson Nov. 11, 2019, 11:53 p.m. UTC | #3 
On 2019-11-11 at 09:21:44, Jeff King wrote:
> I actually worried that I might be stealing brian's thunder. But AFAICT
> this cleanup has been waiting for almost a year, so I figured it was
> fair game. :)

Oh, no, not at all.  I'm delighted that it can go, and thanks for
sending the patches.

I think I had intended to remove it but hadn't because I was worried
about affecting topics in flight, and then promptly forgot about it.