From patchwork Fri Nov 15 09:21:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11245423 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DF4721393 for ; Fri, 15 Nov 2019 09:21:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C75F92073A for ; Fri, 15 Nov 2019 09:21:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C75F92073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD91E6E1C4; Fri, 15 Nov 2019 09:21:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 594266E1C4 for ; Fri, 15 Nov 2019 09:21:28 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id q70so8899916wme.1 for ; Fri, 15 Nov 2019 01:21:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sFDoyGvE0TElP1DDSvUR0jo1soIAcjtkFOowunx7Ft0=; b=c1RRHQlSlJtuLSceR4JwncZnFTuijreSgBs4CM4n9RhuH/I9r+yAD8NNVzUiS3rufn m4WSKBhIX9Co88IX7XUltRSoo4PsFKKQ5fzUdF1lGju8sXz3CSo+CfzqBNweR1s+WgNK TUpJBA1TTNJKEH5JMtjstAP0RJM91xooPz5mdezn6vWtd975v+19CdrJayjrqqUnSl6B 6/opbyrw/y9FwtplBJYOW2m/jH9naRWruJd/4w9SqszPkTfCsR0VyKPg1cRy4XJ2ND0H Dov4mk8WLrTU4xoVnMORbSIUx6Ylwkkv79AquiBwtFAHcz2DFgJnvZkuvY5qudwj40B3 /zow== X-Gm-Message-State: APjAAAUGGB1GLTzlbEeQegApfbkPbLygUaeMDZq5kap9l9razttYkv0k cLa2gN7xey4x0hFwBQIxxIfWsXXXNjE= X-Google-Smtp-Source: APXvYqyg3LPdsaax7SG114ffaoDz3JvBTc6+BAyTQu6piQWNDV40HI8EvyOFGQYtRVZPXWHXqsIOVg== X-Received: by 2002:a05:600c:218e:: with SMTP id e14mr12481658wme.22.1573809686669; Fri, 15 Nov 2019 01:21:26 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id 11sm8987506wmi.8.2019.11.15.01.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 01:21:26 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 0/8] fb_create drive-through cleanups Date: Fri, 15 Nov 2019 10:21:12 +0100 Message-Id: <20191115092120.4445-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sFDoyGvE0TElP1DDSvUR0jo1soIAcjtkFOowunx7Ft0=; b=SkaBeXTFyOe/KDP07IRWlp1ITkEXumCIHh+XNe97aB0XILvXloVS7HoCRcN5oGRdZN E5y/8AjJVt9xGRBWa+HgyTlCSbUfeJ+3Lf4h9vKv/drx9sHxC6i2AAq6V6ZvmlDC0Mzp sn8gp7zPcihTaw+6r3tghFBP7aSHAfqqEfs9Y= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi all, Inspired by some chatting with Pekka on irc I looked a lot at our ->fb_create implementations. Some cleanups (the simpler ones) and some todos (the more involved stuff). It's not a lot of code that we can collect even with all the todos, but we have so many drivers nowadays it's worth it even for the tiny things. Review and for the driver patches especially some testing very much welcome. Cheers, Daniel Daniel Vetter (8): drm/fb: More paranoia in addfb checks drm/atmel: ditch fb_create wrapper drm/mediatek: don't open-code drm_gem_fb_create drm/rockchip: Use drm_gem_fb_create_with_dirty drm/tilcdc: Drop drm_gem_fb_create wrapper drm/xen: Simplify fb_create drm/hibmc: Use drm_gem_fb_create drm/todo: Add entry for fb funcs related cleanups Documentation/gpu/todo.rst | 26 ++++++ drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 8 +- drivers/gpu/drm/drm_framebuffer.c | 17 ++-- .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 4 +- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 11 +-- .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 5 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 62 +++---------- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 16 +++- drivers/gpu/drm/mediatek/mtk_drm_fb.c | 92 ------------------- drivers/gpu/drm/mediatek/mtk_drm_fb.h | 13 --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 54 +---------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 +- drivers/gpu/drm/xen/xen_drm_front_kms.c | 9 +- 14 files changed, 75 insertions(+), 251 deletions(-) delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.c delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_fb.h