[RFCv1,00/42] drm/omap: Convert DSI code to use drm_mipi_dsi and drm_panel

Message

Sebastian Reichel Nov. 17, 2019, 2:39 a.m. UTC

This updates the existing omapdrm DSI code, so that it uses
common drm_mipi_dsi API and drm_panel instead of custom API.
I did not implement support for drm_bridge, since I do not
own any hardware needing this and it does not seem to be a
supported scenario with the old DSS code.

The patchset has been tested with Droid 4 using Linux console,
X.org and Weston. While I found some issues, I could not find
any regressions compared to the current state (*). Combined with
Laurent's effort this will remove all custom panel/connector
drivers from omapdrm and allow more cleanups in the DSS code.

I pushed this patchset into the following branch:

https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-n900.git/log/?h=omapdrm-dsi-drm-panel

(*) When display is used as console for dmesg one can see an
    ugly deadlock on shutdown. I have not yet found the root
    cause for this problem, but that already exists with
    current mainline implementation.

 -- Sebastian

Sebastian Reichel (42):
  omap/drm: drop unused dsi.configure_pins
  drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_*
  drm/omap: constify write buffers
  drm/omap: dsi: add generic transfer function
  drm/omap: panel-dsi-cm: convert to transfer API
  drm/omap: dsi: unexport specific data transfer functions
  drm/omap: dsi: drop virtual channel logic
  drm/omap: dsi: simplify write function
  drm/omap: dsi: simplify read functions
  drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg
  ARM: dts: omap: add channel to DSI panels
  drm/omap: dsi: introduce mipi_dsi_host
  drm/omap: panel-dsi-cm: use DSI helpers
  drm/omap: dsi: request VC via mipi_dsi_attach
  drm/omap: panel-dsi-cm: drop hardcoded VC
  drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines
  drm/omap: dsi: drop unused memory_read()
  drm/omap: dsi: drop unused get_te()
  drm/omap: dsi: drop unused enable_te()
  drm/omap: dsi: drop useless sync()
  drm/omap: dsi: use pixel-format and mode from attach
  drm/omap: panel-dsi-cm: use bulk regulator API
  drm/omap: dsi: lp/hs switching support for transfer()
  drm/omap: dsi: move TE GPIO handling into core
  drm/omap: dsi: drop custom enable_te() API
  drm/omap: dsi: do bus locking in host driver
  drm/omap: dsi: untangle ulps ops from enable/disable
  drm/dsi: add MIPI_DSI_MODE_ULPS_IDLE
  drm/omap: dsi: do ULPS in host driver
  drm/omap: dsi: move panel refresh function to host
  drm/omap: dsi: Reverse direction of the DSS device enable/disable
    operations
  drm/omap: dsi: convert to drm_panel
  drm/omap: dsi: use atomic helper for dirtyfb
  drm/omap: dsi: implement check timings
  drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO
  drm/omap: panel-dsi-cm: support unbinding
  drm/omap: panel-dsi-cm: fix remove()
  drm/omap: panel-dsi-cm: do not power on/off twice
  drm/omap: dsi: return proper error code from dsi_update_all()
  drm/omap: dsi: support panel un/re-binding
  ARM: dts: omap4-droid4: add panel compatible
  drm/panel: Move OMAP's DSI command mode panel driver

 .../bindings/display/panel/panel-dsi-cm.txt   |    4 +-
 arch/arm/boot/dts/omap3-n950.dts              |    3 +-
 arch/arm/boot/dts/omap3.dtsi                  |    3 +
 arch/arm/boot/dts/omap4-droid4-xt894.dts      |    5 +-
 arch/arm/boot/dts/omap4-sdp.dts               |    6 +-
 arch/arm/boot/dts/omap4.dtsi                  |    6 +
 arch/arm/boot/dts/omap5.dtsi                  |    6 +
 drivers/gpu/drm/omapdrm/displays/Kconfig      |    6 -
 drivers/gpu/drm/omapdrm/displays/Makefile     |    1 -
 .../gpu/drm/omapdrm/displays/panel-dsi-cm.c   | 1387 -----------------
 drivers/gpu/drm/omapdrm/dss/Kconfig           |    1 +
 drivers/gpu/drm/omapdrm/dss/base.c            |    2 +-
 drivers/gpu/drm/omapdrm/dss/dsi.c             | 1019 ++++++++----
 .../gpu/drm/omapdrm/dss/omapdss-boot-init.c   |    1 -
 drivers/gpu/drm/omapdrm/dss/omapdss.h         |   81 +-
 drivers/gpu/drm/omapdrm/omap_crtc.c           |   37 +-
 drivers/gpu/drm/omapdrm/omap_crtc.h           |    1 -
 drivers/gpu/drm/omapdrm/omap_encoder.c        |   20 +-
 drivers/gpu/drm/omapdrm/omap_fb.c             |   21 +-
 drivers/gpu/drm/panel/Kconfig                 |    9 +
 drivers/gpu/drm/panel/Makefile                |    1 +
 drivers/gpu/drm/panel/panel-dsi-cm.c          |  646 ++++++++
 include/drm/drm_mipi_dsi.h                    |    2 +
 23 files changed, 1385 insertions(+), 1883 deletions(-)
 delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
 create mode 100644 drivers/gpu/drm/panel/panel-dsi-cm.c


base-commit: 17cc51390c141662748dbbc2fe98f3ed10f2e13e