mbox series

[0/3] range-diff: don't compare notes

Message ID cover.1574125554.git.liu.denton@gmail.com (mailing list archive)
Headers show
Series range-diff: don't compare notes | expand

Message

Denton Liu Nov. 19, 2019, 1:06 a.m. UTC 
When I was using range-diff at $DAYJOB earlier, I realised that it
includes commit notes as part of the commit message comparison. This is
undesired behaviour so this patchset documents it and stops it from
happening.

Denton Liu (3):
  t3206: remove spaces after redirect operators
  t3206: demonstrate failure with notes
  range-diff: use --no-notes to generate patches

 range-diff.c          |  2 +-
 t/t3206-range-diff.sh | 17 ++++++++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

Comments

Junio C Hamano Nov. 19, 2019, 2:56 a.m. UTC | #1 
Denton Liu <liu.denton@gmail.com> writes:

> When I was using range-diff at $DAYJOB earlier, I realised that it
> includes commit notes as part of the commit message comparison. This is
> undesired behaviour so this patchset documents it and stops it from
> happening.

I actually wish it allowed me to compare them _with_ --notes=<ref>
specified by the user.  If you are passing --no-notes through,
perhaps you can also pass through such an option while at it.