From patchwork Wed Nov 20 14:03:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 11253985 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 99B70109A for ; Wed, 20 Nov 2019 14:04:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70A4222445 for ; Wed, 20 Nov 2019 14:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RxEoKVPz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70A4222445 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:58442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXQbF-0007r8-1T for patchwork-qemu-devel@patchwork.kernel.org; Wed, 20 Nov 2019 09:04:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47266) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXQaD-0006MV-71 for qemu-devel@nongnu.org; Wed, 20 Nov 2019 09:03:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXQaB-0000rO-8S for qemu-devel@nongnu.org; Wed, 20 Nov 2019 09:03:48 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:54075 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iXQaB-0000rF-5D for qemu-devel@nongnu.org; Wed, 20 Nov 2019 09:03:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574258626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kmSz5I3iQu8nBCc4Tx2gBHa6XFQ3euGJ0RJ0tEksSC0=; b=RxEoKVPzn2rUvcfBoOKw7SGBgm34I6XuglbkUnltobK5hLtlcPWrwRbKs3ouT1ZsjGD/SM lp3Q6K6dnzOQqrBrk6C919bHatANhxhsy0J0s2H+3n+G4uMNbezNZsVsqevYgSGE++/PRM pxJAu9Ia97zP5PErqJt+zxO5BFwq26c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-178-5vpkOQnAO9KhpHPSM8_4KQ-1; Wed, 20 Nov 2019 09:03:43 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8445F8024E1; Wed, 20 Nov 2019 14:03:42 +0000 (UTC) Received: from linux.fritz.box.com (unknown [10.36.118.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 43A9E60499; Wed, 20 Nov 2019 14:03:36 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PATCH for-4.2? 0/6] block: Fix resize (extending) of short overlays Date: Wed, 20 Nov 2019 15:03:13 +0100 Message-Id: <20191120140319.1505-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 5vpkOQnAO9KhpHPSM8_4KQ-1 X-Mimecast-Spam-Score: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Consider the following scenario where the overlay is shorter than its backing file: base.qcow2: AAAAAAAA overlay.qcow2: BBBB When resizing (extending) overlay.qcow2, the new blocks should not stay unallocated and make the additional As from base.qcow2 visible like before this series, but zeros should be read. A similar case happens with the various variants of a commit job when an intermediate file is short (- for unallocated): base.qcow2: A-A-AAAA mid.qcow2: BB-B top.qcow2: C--C--C- After commit top.qcow2 to mid.qcow2, the following happens: mid.qcow2: CB-C00C0 (correct result) mid.qcow2: CB-C--C- (before this fix) Without the fix, blocks that previously read as zeros on top.qcow2 suddenly turn into A. Kevin Wolf (6): block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter block: truncate: Don't make backing file data visible iotests: Add qemu_io_log() iotests: Fix timeout in run_job() iotests: Support job-complete in run_job() iotests: Test committing to short backing file block/io.c | 31 ++++++- tests/qemu-iotests/274 | 131 +++++++++++++++++++++++++++++ tests/qemu-iotests/274.out | 150 ++++++++++++++++++++++++++++++++++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 11 ++- 5 files changed, 319 insertions(+), 5 deletions(-) create mode 100755 tests/qemu-iotests/274 create mode 100644 tests/qemu-iotests/274.out