[0/4] add runtime pm support for AMD display audio
mbox series

Message ID 20191122214353.582899-1-alexander.deucher@amd.com
Headers show
Series
  • add runtime pm support for AMD display audio
Related show

Message

Alex Deucher Nov. 22, 2019, 9:43 p.m. UTC
These patches were originally part of a larger set of patches
to enabled runtime pm support on the GPU side[1].  However, the
patches are useful on their own there are really no dependencies,
other than the fact that you need both for runtime pm to kick in
on the GPU side.  The GPU side will be landing for 5.6; I'd like
to land the audio side as well.

Thanks,

Alex

[1]: https://patchwork.freedesktop.org/series/67885/

Alex Deucher (4):
  ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD
  ALSA: hda/hdmi - Add new pci ids for AMD GPU display audio
  ALSA: hda/hdmi - enable runtime pm for newer AMD display audio
  ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by
    default

 sound/pci/hda/hda_intel.c  | 80 +++++++++++++++++++++++++++++++++++---
 sound/pci/hda/patch_hdmi.c |  1 +
 2 files changed, 76 insertions(+), 5 deletions(-)

Comments

Takashi Iwai Nov. 23, 2019, 8:57 a.m. UTC | #1
On Fri, 22 Nov 2019 22:43:49 +0100,
Alex Deucher wrote:
> 
> These patches were originally part of a larger set of patches
> to enabled runtime pm support on the GPU side[1].  However, the
> patches are useful on their own there are really no dependencies,
> other than the fact that you need both for runtime pm to kick in
> on the GPU side.  The GPU side will be landing for 5.6; I'd like
> to land the audio side as well.

Do you mean that these can go into 5.5-rc1, or they need waiting until
5.5-rc1 release?  I guess these won't break things even without the
runtime PM support in GPU side, as the ELD notification is done via
audio component, so I'm fine to apply them at any time.


thanks,

Takashi


> 
> Thanks,
> 
> Alex
> 
> [1]: https://patchwork.freedesktop.org/series/67885/
> 
> Alex Deucher (4):
>   ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD
>   ALSA: hda/hdmi - Add new pci ids for AMD GPU display audio
>   ALSA: hda/hdmi - enable runtime pm for newer AMD display audio
>   ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by
>     default
> 
>  sound/pci/hda/hda_intel.c  | 80 +++++++++++++++++++++++++++++++++++---
>  sound/pci/hda/patch_hdmi.c |  1 +
>  2 files changed, 76 insertions(+), 5 deletions(-)
> 
> -- 
> 2.23.0
>
Alex Deucher Nov. 25, 2019, 2:40 p.m. UTC | #2
On Sat, Nov 23, 2019 at 3:57 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Fri, 22 Nov 2019 22:43:49 +0100,
> Alex Deucher wrote:
> >
> > These patches were originally part of a larger set of patches
> > to enabled runtime pm support on the GPU side[1].  However, the
> > patches are useful on their own there are really no dependencies,
> > other than the fact that you need both for runtime pm to kick in
> > on the GPU side.  The GPU side will be landing for 5.6; I'd like
> > to land the audio side as well.
>
> Do you mean that these can go into 5.5-rc1, or they need waiting until
> 5.5-rc1 release?  I guess these won't break things even without the
> runtime PM support in GPU side, as the ELD notification is done via
> audio component, so I'm fine to apply them at any time.

Up to you.  I'm ok to wait for the next merge window if you'd prefer.

Alex

>
>
> thanks,
>
> Takashi
>
>
> >
> > Thanks,
> >
> > Alex
> >
> > [1]: https://patchwork.freedesktop.org/series/67885/
> >
> > Alex Deucher (4):
> >   ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD
> >   ALSA: hda/hdmi - Add new pci ids for AMD GPU display audio
> >   ALSA: hda/hdmi - enable runtime pm for newer AMD display audio
> >   ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by
> >     default
> >
> >  sound/pci/hda/hda_intel.c  | 80 +++++++++++++++++++++++++++++++++++---
> >  sound/pci/hda/patch_hdmi.c |  1 +
> >  2 files changed, 76 insertions(+), 5 deletions(-)
> >
> > --
> > 2.23.0
> >
Takashi Iwai Nov. 26, 2019, 2:53 p.m. UTC | #3
On Mon, 25 Nov 2019 15:40:43 +0100,
Alex Deucher wrote:
> 
> On Sat, Nov 23, 2019 at 3:57 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Fri, 22 Nov 2019 22:43:49 +0100,
> > Alex Deucher wrote:
> > >
> > > These patches were originally part of a larger set of patches
> > > to enabled runtime pm support on the GPU side[1].  However, the
> > > patches are useful on their own there are really no dependencies,
> > > other than the fact that you need both for runtime pm to kick in
> > > on the GPU side.  The GPU side will be landing for 5.6; I'd like
> > > to land the audio side as well.
> >
> > Do you mean that these can go into 5.5-rc1, or they need waiting until
> > 5.5-rc1 release?  I guess these won't break things even without the
> > runtime PM support in GPU side, as the ELD notification is done via
> > audio component, so I'm fine to apply them at any time.
> 
> Up to you.  I'm ok to wait for the next merge window if you'd prefer.

OK, I'm going to apply them for 5.5-rc1 inclusion.

BTW, should I apply these patches with your gmail address as author
(while sign-off is AMD address)?  Or should I align both to your AMD
address?

It's nothing wrong to have different addresses in the commit, but if
unintended, it's better to align both.


thanks,

Takashi
Alex Deucher Nov. 26, 2019, 3:31 p.m. UTC | #4
On Tue, Nov 26, 2019 at 9:53 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Mon, 25 Nov 2019 15:40:43 +0100,
> Alex Deucher wrote:
> >
> > On Sat, Nov 23, 2019 at 3:57 AM Takashi Iwai <tiwai@suse.de> wrote:
> > >
> > > On Fri, 22 Nov 2019 22:43:49 +0100,
> > > Alex Deucher wrote:
> > > >
> > > > These patches were originally part of a larger set of patches
> > > > to enabled runtime pm support on the GPU side[1].  However, the
> > > > patches are useful on their own there are really no dependencies,
> > > > other than the fact that you need both for runtime pm to kick in
> > > > on the GPU side.  The GPU side will be landing for 5.6; I'd like
> > > > to land the audio side as well.
> > >
> > > Do you mean that these can go into 5.5-rc1, or they need waiting until
> > > 5.5-rc1 release?  I guess these won't break things even without the
> > > runtime PM support in GPU side, as the ELD notification is done via
> > > audio component, so I'm fine to apply them at any time.
> >
> > Up to you.  I'm ok to wait for the next merge window if you'd prefer.
>
> OK, I'm going to apply them for 5.5-rc1 inclusion.
>
> BTW, should I apply these patches with your gmail address as author
> (while sign-off is AMD address)?  Or should I align both to your AMD
> address?
>
> It's nothing wrong to have different addresses in the commit, but if
> unintended, it's better to align both.

I guess my AMD address.  I usually use my gmail address for sending
patches out of laziness.

Alex
Takashi Iwai Nov. 26, 2019, 3:58 p.m. UTC | #5
On Tue, 26 Nov 2019 16:31:37 +0100,
Alex Deucher wrote:
> 
> On Tue, Nov 26, 2019 at 9:53 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Mon, 25 Nov 2019 15:40:43 +0100,
> > Alex Deucher wrote:
> > >
> > > On Sat, Nov 23, 2019 at 3:57 AM Takashi Iwai <tiwai@suse.de> wrote:
> > > >
> > > > On Fri, 22 Nov 2019 22:43:49 +0100,
> > > > Alex Deucher wrote:
> > > > >
> > > > > These patches were originally part of a larger set of patches
> > > > > to enabled runtime pm support on the GPU side[1].  However, the
> > > > > patches are useful on their own there are really no dependencies,
> > > > > other than the fact that you need both for runtime pm to kick in
> > > > > on the GPU side.  The GPU side will be landing for 5.6; I'd like
> > > > > to land the audio side as well.
> > > >
> > > > Do you mean that these can go into 5.5-rc1, or they need waiting until
> > > > 5.5-rc1 release?  I guess these won't break things even without the
> > > > runtime PM support in GPU side, as the ELD notification is done via
> > > > audio component, so I'm fine to apply them at any time.
> > >
> > > Up to you.  I'm ok to wait for the next merge window if you'd prefer.
> >
> > OK, I'm going to apply them for 5.5-rc1 inclusion.
> >
> > BTW, should I apply these patches with your gmail address as author
> > (while sign-off is AMD address)?  Or should I align both to your AMD
> > address?
> >
> > It's nothing wrong to have different addresses in the commit, but if
> > unintended, it's better to align both.
> 
> I guess my AMD address.  I usually use my gmail address for sending
> patches out of laziness.

OK, now merged all four patches.

thanks,

Takashi
Alex Deucher Nov. 26, 2019, 4:19 p.m. UTC | #6
On Tue, Nov 26, 2019 at 10:58 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Tue, 26 Nov 2019 16:31:37 +0100,
> Alex Deucher wrote:
> >
> > On Tue, Nov 26, 2019 at 9:53 AM Takashi Iwai <tiwai@suse.de> wrote:
> > >
> > > On Mon, 25 Nov 2019 15:40:43 +0100,
> > > Alex Deucher wrote:
> > > >
> > > > On Sat, Nov 23, 2019 at 3:57 AM Takashi Iwai <tiwai@suse.de> wrote:
> > > > >
> > > > > On Fri, 22 Nov 2019 22:43:49 +0100,
> > > > > Alex Deucher wrote:
> > > > > >
> > > > > > These patches were originally part of a larger set of patches
> > > > > > to enabled runtime pm support on the GPU side[1].  However, the
> > > > > > patches are useful on their own there are really no dependencies,
> > > > > > other than the fact that you need both for runtime pm to kick in
> > > > > > on the GPU side.  The GPU side will be landing for 5.6; I'd like
> > > > > > to land the audio side as well.
> > > > >
> > > > > Do you mean that these can go into 5.5-rc1, or they need waiting until
> > > > > 5.5-rc1 release?  I guess these won't break things even without the
> > > > > runtime PM support in GPU side, as the ELD notification is done via
> > > > > audio component, so I'm fine to apply them at any time.
> > > >
> > > > Up to you.  I'm ok to wait for the next merge window if you'd prefer.
> > >
> > > OK, I'm going to apply them for 5.5-rc1 inclusion.
> > >
> > > BTW, should I apply these patches with your gmail address as author
> > > (while sign-off is AMD address)?  Or should I align both to your AMD
> > > address?
> > >
> > > It's nothing wrong to have different addresses in the commit, but if
> > > unintended, it's better to align both.
> >
> > I guess my AMD address.  I usually use my gmail address for sending
> > patches out of laziness.
>
> OK, now merged all four patches.

Thanks!

Alex

>
> thanks,
>
> Takashi