| Message ID | 20191204133639.2382-1-jth@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | remove BUG_ON()s in btrfs_close_one_device() | expand |
On Wed, Dec 04, 2019 at 02:36:37PM +0100, Johannes Thumshirn wrote: > This series attempts to remove the BUG_ON()s in btrfs_close_one_device(). > Therefore some reorganization of btrfs_close_one_device() was needed, to > avoid the memory allocation. > > This series has passed fstests without any deviation from the baseline. > > Changes to v4: > - Clear dev_stat_ccnt on removal (Dave) > - Don't clear BTRFS_DEV_STATE_MISSING and BTRFS_DEV_STATE_FS_METADATA as > they'll be handled elsewhere > - Release extent_io_tree (fstests) Passed fstests, I don't see any other obvious problems so I'll add it to misc-next.
This series attempts to remove the BUG_ON()s in btrfs_close_one_device(). Therefore some reorganization of btrfs_close_one_device() was needed, to avoid the memory allocation. This series has passed fstests without any deviation from the baseline. Changes to v4: - Clear dev_stat_ccnt on removal (Dave) - Don't clear BTRFS_DEV_STATE_MISSING and BTRFS_DEV_STATE_FS_METADATA as they'll be handled elsewhere - Release extent_io_tree (fstests) Changes to v3: - Clear BTRFS_DEV_STATE_WRITEABLE after calling btrfs_close_bdev() so btrfs_close_bdev() can call sync_blockdev() and invalidate_bdev() (Nikolay) Changes to v2: - Completly different approach to the origianl patchset, instead of handling eventual allocation failures. - Dropped already merged patches for ' btrfs_fs_devices::rotating' and 'btrfs_fs_devices::seeding' - Kept the 1st patch of the old series, as it's a nice cleanup Changes to v1: - Fixed the decremt of btrfs_fs_devices::seeding. - In addition to this, I've added two patches changing btrfs_fs_devices::seeding and btrfs_fs_devices::rotating to bool, as they are in fact used as booleans. Johannes Thumshirn (2): btrfs: decrement number of open devices after closing the device not before btrfs: reset device back to allocation state when removing fs/btrfs/volumes.c | 31 ++++++++++++------------------- 1 file changed, 12 insertions(+), 19 deletions(-)