[0/5] Refactor ioctl_fibmap() internal interface
mbox series

Message ID 20191210150344.112181-1-cmaiolino@redhat.com
Headers show
  • Refactor ioctl_fibmap() internal interface
Related show


Carlos Maiolino Dec. 10, 2019, 3:03 p.m. UTC

This series refactor the internal structure of FIBMAP so that the filesystem can
properly report errors back to VFS, and also simplifies its usage by
standardizing all ->bmap() method usage via bmap() function.

The last patch is a bug fix for ioctl_fibmap() calls with negative block values.

This new version just includes small kbuild test robot warnings caused by
ommited parameter names, and remove changelogs from patches description, moving
them to this cover-letter.



	- Rebased over linux-next
	- Add parameters names to function declarations
	  Reported-by: kbuild test robot <lkp@intel.com>
	- Remove changelog entries from patches's commit logs


        - Add a dummy bmap() definition so build does not break if
          CONFIG_BLOCK is not set
          Reported-by: kbuild test robot <lkp@intel.com>

        - ASSERT only if filesystem does not support bmap() to
          match the original logic

	- Fix bmap() doc function
	  Reported-by: kbuild test robot <lkp@intel.com>


        - Rebasing against 5.3 required changes to the f2fs
          check_swap_activate() function


        - Ensure ioctl_fibmap() returns 0 in case of error returned from
          bmap(). Otherwise we'll be changing the user interface (which
          returns 0 in case of error)
        - Rename usr_blk to ur_block

        - Use a local sector_t variable to asign the block number
          instead of using direct casting.

Carlos Maiolino (5):
  fs: Enable bmap() function to properly return errors
  cachefiles: drop direct usage of ->bmap method.
  ecryptfs: drop direct calls to ->bmap
  fibmap: Use bmap instead of ->bmap method in ioctl_fibmap
  fibmap: Reject negative block numbers

 drivers/md/md-bitmap.c | 16 ++++++++++------
 fs/cachefiles/rdwr.c   | 27 ++++++++++++++-------------
 fs/ecryptfs/mmap.c     | 16 ++++++----------
 fs/f2fs/data.c         | 16 +++++++++++-----
 fs/inode.c             | 30 +++++++++++++++++-------------
 fs/ioctl.c             | 32 ++++++++++++++++++++++----------
 fs/jbd2/journal.c      | 22 +++++++++++++++-------
 include/linux/fs.h     |  9 ++++++++-
 mm/page_io.c           | 11 +++++++----
 9 files changed, 110 insertions(+), 69 deletions(-)