[v2,00/15] ASoC: soc-core cleanup step7
mbox series

Message ID 87mubx59la.wl-kuninori.morimoto.gx@renesas.com
Headers show
Series
  • ASoC: soc-core cleanup step7
Related show

Message

Kuninori Morimoto Dec. 13, 2019, 12:54 a.m. UTC
Hi Mark

These are v2 of codec_conf cleanup.

ASoC has codec_conf, and we are using original
dev_name, of_node for it to finding codec.
But, we already have snd_soc_dai_link_component method.
We can reuse it for codec_conf, too.
This patches are for it.

Big change from v1 is

	- COMP_CODEC_CNF(_name)
	+ COMP_CODEC_CONF(_name)

Kuninori Morimoto (15):
  ASoC: soc-core: support snd_soc_dai_link_component for codec_conf
  ASoC: fsl: imx-audmix: use snd_soc_dai_link_component for codec_conf
  ASoC: intel: kbl_da7219_max98927: use snd_soc_dai_link_component for codec_conf
  ASoC: intel: kbl_rt5663_max98927: use snd_soc_dai_link_component for codec_conf
  ASoC: intel: kbl_rt5663_rt5514_max98927: use snd_soc_dai_link_component for codec_conf
  ASoC: intel: skl_nau88l25_ssm4567: use snd_soc_dai_link_component for codec_conf
  ASoC: mediatek: mt8173-rt5650-rt5514: use snd_soc_dai_link_component for codec_conf
  ASoC: mediatek: mt8173-rt5650-rt5676: use snd_soc_dai_link_component for codec_conf
  ASoC: mediatek: mt8183-da7219-max98357: use snd_soc_dai_link_component for codec_conf
  ASoC: samsung: bells: use snd_soc_dai_link_component for codec_conf
  ASoC: samsung: lowland: use snd_soc_dai_link_component for codec_conf
  ASoC: samsung: neo1973_wm8753: use snd_soc_dai_link_component for codec_conf
  ASoC: samsung: speyside: use snd_soc_dai_link_component for codec_conf
  ASoC: ti: rx51: use snd_soc_dai_link_component for codec_conf
  ASoC: soc-core: remove legacy style of codec_conf

 include/sound/soc.h                                 |  4 ++--
 sound/soc/fsl/imx-audmix.c                          |  2 +-
 sound/soc/intel/boards/kbl_da7219_max98927.c        |  8 ++++----
 sound/soc/intel/boards/kbl_rt5663_max98927.c        |  4 ++--
 sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c |  4 ++--
 sound/soc/intel/boards/skl_nau88l25_ssm4567.c       |  4 ++--
 sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c    |  2 +-
 sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c    |  2 +-
 sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c  |  2 +-
 sound/soc/samsung/bells.c                           |  2 +-
 sound/soc/samsung/lowland.c                         |  2 +-
 sound/soc/samsung/neo1973_wm8753.c                  |  2 +-
 sound/soc/samsung/speyside.c                        |  2 +-
 sound/soc/soc-core.c                                | 12 +++++-------
 sound/soc/ti/rx51.c                                 | 12 ++++++------
 15 files changed, 31 insertions(+), 33 deletions(-)

Comments

Pierre-Louis Bossart Dec. 13, 2019, 3:49 a.m. UTC | #1
On 12/12/19 6:54 PM, Kuninori Morimoto wrote:
> 
> Hi Mark
> 
> These are v2 of codec_conf cleanup.
> 
> ASoC has codec_conf, and we are using original
> dev_name, of_node for it to finding codec.
> But, we already have snd_soc_dai_link_component method.
> We can reuse it for codec_conf, too.
> This patches are for it.

Looks good to me

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> Big change from v1 is
> 
> 	- COMP_CODEC_CNF(_name)
> 	+ COMP_CODEC_CONF(_name)
> 
> Kuninori Morimoto (15):
>    ASoC: soc-core: support snd_soc_dai_link_component for codec_conf
>    ASoC: fsl: imx-audmix: use snd_soc_dai_link_component for codec_conf
>    ASoC: intel: kbl_da7219_max98927: use snd_soc_dai_link_component for codec_conf
>    ASoC: intel: kbl_rt5663_max98927: use snd_soc_dai_link_component for codec_conf
>    ASoC: intel: kbl_rt5663_rt5514_max98927: use snd_soc_dai_link_component for codec_conf
>    ASoC: intel: skl_nau88l25_ssm4567: use snd_soc_dai_link_component for codec_conf
>    ASoC: mediatek: mt8173-rt5650-rt5514: use snd_soc_dai_link_component for codec_conf
>    ASoC: mediatek: mt8173-rt5650-rt5676: use snd_soc_dai_link_component for codec_conf
>    ASoC: mediatek: mt8183-da7219-max98357: use snd_soc_dai_link_component for codec_conf
>    ASoC: samsung: bells: use snd_soc_dai_link_component for codec_conf
>    ASoC: samsung: lowland: use snd_soc_dai_link_component for codec_conf
>    ASoC: samsung: neo1973_wm8753: use snd_soc_dai_link_component for codec_conf
>    ASoC: samsung: speyside: use snd_soc_dai_link_component for codec_conf
>    ASoC: ti: rx51: use snd_soc_dai_link_component for codec_conf
>    ASoC: soc-core: remove legacy style of codec_conf
> 
>   include/sound/soc.h                                 |  4 ++--
>   sound/soc/fsl/imx-audmix.c                          |  2 +-
>   sound/soc/intel/boards/kbl_da7219_max98927.c        |  8 ++++----
>   sound/soc/intel/boards/kbl_rt5663_max98927.c        |  4 ++--
>   sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c |  4 ++--
>   sound/soc/intel/boards/skl_nau88l25_ssm4567.c       |  4 ++--
>   sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c    |  2 +-
>   sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c    |  2 +-
>   sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c  |  2 +-
>   sound/soc/samsung/bells.c                           |  2 +-
>   sound/soc/samsung/lowland.c                         |  2 +-
>   sound/soc/samsung/neo1973_wm8753.c                  |  2 +-
>   sound/soc/samsung/speyside.c                        |  2 +-
>   sound/soc/soc-core.c                                | 12 +++++-------
>   sound/soc/ti/rx51.c                                 | 12 ++++++------
>   15 files changed, 31 insertions(+), 33 deletions(-)
>
Sridharan, Ranjani Dec. 13, 2019, 5:22 p.m. UTC | #2
On Thu, Dec 12, 2019 at 4:56 PM Kuninori Morimoto <
kuninori.morimoto.gx@renesas.com> wrote:

>
> Hi Mark
>
> These are v2 of codec_conf cleanup.
>
> ASoC has codec_conf, and we are using original
> dev_name, of_node for it to finding codec.
> But, we already have snd_soc_dai_link_component method.
> We can reuse it for codec_conf, too.
> This patches are for it.
>
> Big change from v1 is
>
>         - COMP_CODEC_CNF(_name)
>         + COMP_CODEC_CONF(_name)
>
LGTM. Thanks, Morimoto-san!
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>