[v5,0/2] Some debugfs enhancements
mbox series

Message ID 20191213210050.33611-1-andi@etezian.org
Headers show
  • Some debugfs enhancements
Related show


Andi Shyti Dec. 13, 2019, 9 p.m. UTC
From: Andi Shyti <andi.shyti@intel.com>


this two patches are few debugfs improvements. The first adds
some helpers for reading the GT frequency, while the second patch
moves all the power management debufs functions into gt/

Thanks Chris and Michal for the reviews.


v4-v5: (v4: https://lists.freedesktop.org/archives/intel-gfx/2019-December/223431.html)
 - renamed files:
        renamed:    drivers/gpu/drm/i915/gt/debugfs_gt.c -> drivers/gpu/drm/i915/gt/intel_debugfs_gt.c
        renamed:    drivers/gpu/drm/i915/gt/debugfs_gt.h -> drivers/gpu/drm/i915/gt/intel_debugfs_gt.h
        renamed:    drivers/gpu/drm/i915/gt/debugfs_pm.c -> drivers/gpu/drm/i915/gt/intel_debugfs_pm.c
        renamed:    drivers/gpu/drm/i915/gt/debugfs_pm.h -> drivers/gpu/drm/i915/gt/intel_debugfs_pm.h
 - change the spdx identifier's comment from the /* */ to the // style.

v3-v4: (v3: https://lists.freedesktop.org/archives/intel-gfx/2019-December/223368.html)
 - added wakeref in frequency reading (patch 1)
 - added Chris reviewed-by in patch 1
 - sorted in alphabetical order the debugfs functions
 - removed dentry reference in the gt structure, because it's useless.

v2-v3: (v2: https://lists.freedesktop.org/archives/intel-gfx/2019-December/223277.html)
Fixed the three reviews from Chris
 - removed the 'i915' prefix from the gt pm debugfs files
 - fixed my laziness and made the debugfs pm files more gt
   oriented. Now the only dependency remaining from the
   'drm_i915_private' structure is for platform generation check.
 - restored the 'node_to_i915' to its original position, as it's
   not needed anymore.

v1-v2: (v1: https://lists.freedesktop.org/archives/intel-gfx/2019-December/222758.html)
 - renamed functions from
	intel_cagf_freq_read to intel_rps_read_actual_frequency
	intel_cagf_read to intel_rps_read_cagf
 - created an independent gt/ directory in debugfs

Andi Shyti (2):
  drm/i915/rps: Add frequency translation helpers
  drm/i915/gt: Move power management debug files into a gt aware debugfs

 drivers/gpu/drm/i915/Makefile              |   2 +
 drivers/gpu/drm/i915/gt/intel_debugfs_gt.c |  23 +
 drivers/gpu/drm/i915/gt/intel_debugfs_gt.h |  27 +
 drivers/gpu/drm/i915/gt/intel_debugfs_pm.c | 623 +++++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_debugfs_pm.h |  16 +
 drivers/gpu/drm/i915/gt/intel_rps.c        |  30 +
 drivers/gpu/drm/i915/gt/intel_rps.h        |   2 +
 drivers/gpu/drm/i915/i915_debugfs.c        | 590 +------------------
 drivers/gpu/drm/i915/i915_sysfs.c          |  14 +-
 9 files changed, 734 insertions(+), 593 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gt/intel_debugfs_gt.c
 create mode 100644 drivers/gpu/drm/i915/gt/intel_debugfs_gt.h
 create mode 100644 drivers/gpu/drm/i915/gt/intel_debugfs_pm.c
 create mode 100644 drivers/gpu/drm/i915/gt/intel_debugfs_pm.h