[00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef

Message

Philippe Mathieu-Daudé Dec. 17, 2019, 4:37 p.m. UTC

Hi,

After this chat on #qemu IRC:
13:20 <stsquad> so what is the difference between a IOReadHandler and IOEventHandler?
13:25 <f4bug> stsquad: one is in-band and the other out-of-band?
13:26 <stsquad> f4bug: ahh yes it seems so - connect/disconnect etc...
13:27 <f4bug> see QEMUChrEvent for IOEventHandler

I thought it might be a good opportunity to make the IOEventHandler
typedef meaning more obvious, by using the QEMUChrEvent enum.

To be able to build I had to explicit a 'default' case when frontends
use a switch(event) case and do not handle all events.

Then I used a coccinelle spatch to change the various IOEventHandler.
I don't think the last patch can be split, but suggestions are welcome!

Regards,

Phil.

PD: I use git-publish. To avoid spamming too much, I'm using per-patch
Cc tag, after the '---' separator. This way each recipient should get
the cover and the specific patches of interests, + the last one.

Sent with: 'git publish --suppress-cc=cccmd'

Cc: "Gonglei (Arei)" <[e-mail]>
Cc: "Marc-André Lureau" <[e-mail]>
Cc: Paolo Bonzini <[e-mail]>
Cc: "Alex Bennée" <[e-mail]>
Cc: "Philippe Mathieu-Daudé" <[e-mail]>
Cc: Andrzej Zaborowski <[e-mail]>
Cc: Peter Maydell <[e-mail]>
Cc: "Michael S. Tsirkin" <[e-mail]>
Cc: Kevin Wolf <[e-mail]>
Cc: Max Reitz <[e-mail]>
Cc: "Edgar E. Iglesias" <[e-mail]>
Cc: Alistair Francis <[e-mail]>
Cc: Antony Pavlov <[e-mail]>
Cc: Igor Mitsyanko <[e-mail]>
Cc: Fabien Chouteau <[e-mail]>
Cc: KONRAD Frederic <[e-mail]>
Cc: Peter Chubb <[e-mail]>
Cc: Alberto Garcia <[e-mail]>
Cc: Michael Walle <[e-mail]>
Cc: Thomas Huth <[e-mail]>
Cc: Joel Stanley <[e-mail]>
Cc: Cornelia Huck <[e-mail]>
Cc: Halil Pasic <[e-mail]>
Cc: Christian Borntraeger <[e-mail]>
Cc: Laurent Vivier <[e-mail]>
Cc: Amit Shah <[e-mail]>
Cc: Corey Minyard <[e-mail]>
Cc: Paul Burton <[e-mail]>
Cc: Aleksandar Rikalo <[e-mail]>
Cc: Aurelien Jarno <[e-mail]>
Cc: Aleksandar Markovic <[e-mail]>
Cc: Palmer Dabbelt <[e-mail]>
Cc: Sagar Karandikar <[e-mail]>
Cc: Bastian Koppelmann <[e-mail]>
Cc: Gerd Hoffmann <[e-mail]>
Cc: Samuel Thibault <[e-mail]>
Cc: "Dr. David Alan Gilbert" <[e-mail]>
Cc: Markus Armbruster <[e-mail]>
Cc: Zhang Chen <[e-mail]>
Cc: Li Zhijian <[e-mail]>
Cc: Jason Wang <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]

Philippe Mathieu-Daudé (14):
  hw/ipmi: Remove unnecessary declarations
  chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler
  vhost-user: Explicit we ignore some QEMUChrEvent in IOEventHandler
  virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler
  hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler
  hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler
  ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler
  hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler
  monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler
  monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler
  net/vhost-user: Explicit we ignore few QEMUChrEvent in IOEventHandler
  vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler
  hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler
  chardev: Use QEMUChrEvent enum in IOEventHandler typedef

 include/chardev/char-fe.h       |  2 +-
 include/chardev/char-mux.h      |  2 +-
 include/chardev/char.h          |  4 ++--
 backends/cryptodev-vhost-user.c |  5 ++++-
 chardev/char-mux.c              |  8 ++++----
 chardev/char.c                  |  7 +++++--
 gdbstub.c                       |  2 +-
 hw/arm/pxa2xx.c                 |  2 +-
 hw/arm/strongarm.c              |  2 +-
 hw/block/vhost-user-blk.c       |  5 ++++-
 hw/char/cadence_uart.c          |  2 +-
 hw/char/digic-uart.c            |  2 +-
 hw/char/escc.c                  |  2 +-
 hw/char/etraxfs_ser.c           |  2 +-
 hw/char/exynos4210_uart.c       |  2 +-
 hw/char/grlib_apbuart.c         |  2 +-
 hw/char/imx_serial.c            |  2 +-
 hw/char/ipoctal232.c            |  2 +-
 hw/char/lm32_juart.c            |  2 +-
 hw/char/lm32_uart.c             |  2 +-
 hw/char/mcf_uart.c              |  2 +-
 hw/char/milkymist-uart.c        |  2 +-
 hw/char/nrf51_uart.c            |  2 +-
 hw/char/pl011.c                 |  2 +-
 hw/char/serial.c                |  2 +-
 hw/char/sh_serial.c             |  2 +-
 hw/char/terminal3270.c          |  5 ++++-
 hw/char/virtio-console.c        |  5 ++++-
 hw/char/xilinx_uartlite.c       |  2 +-
 hw/ipmi/ipmi_bmc_extern.c       | 10 +++++-----
 hw/mips/boston.c                |  2 +-
 hw/mips/mips_malta.c            |  2 +-
 hw/riscv/riscv_htif.c           |  2 +-
 hw/riscv/sifive_uart.c          |  2 +-
 hw/usb/ccid-card-passthru.c     |  5 ++++-
 hw/usb/dev-serial.c             |  5 ++++-
 hw/usb/redirect.c               |  5 ++++-
 monitor/hmp.c                   |  6 +++++-
 monitor/qmp.c                   |  5 ++++-
 net/filter-mirror.c             |  2 +-
 net/vhost-user.c                |  7 +++++--
 qtest.c                         |  2 +-
 tests/test-char.c               |  6 +++---
 tests/vhost-user-test.c         |  2 +-
 44 files changed, 90 insertions(+), 56 deletions(-)

Comments

Philippe Mathieu-Daudé Dec. 17, 2019, 4:50 p.m. UTC | #1

On 12/17/19 5:37 PM, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> After this chat on #qemu IRC:
> 13:20 <stsquad> so what is the difference between a IOReadHandler and IOEventHandler?
> 13:25 <f4bug> stsquad: one is in-band and the other out-of-band?
> 13:26 <stsquad> f4bug: ahh yes it seems so - connect/disconnect etc...
> 13:27 <f4bug> see QEMUChrEvent for IOEventHandler
> 
> I thought it might be a good opportunity to make the IOEventHandler
> typedef meaning more obvious, by using the QEMUChrEvent enum.
> 
> To be able to build I had to explicit a 'default' case when frontends
> use a switch(event) case and do not handle all events.
> 
> Then I used a coccinelle spatch to change the various IOEventHandler.
> I don't think the last patch can be split, but suggestions are welcome!
> 
> Regards,
> 
> Phil.
> 
> PD: I use git-publish. To avoid spamming too much, I'm using per-patch
> Cc tag, after the '---' separator. This way each recipient should get
> the cover and the specific patches of interests, + the last one.
> 
> Sent with: 'git publish --suppress-cc=cccmd'

While 'git-publish --verbose' show it was adding recipient from the tags:
(mbox) Adding cc: ...
(mbox) Adding cc: ...

It still sent each patch to everybody from the cover:
Server:
MAIL FROM:
RCPT TO: ...
RCPT TO: ...

Maybe the list was cached in the tag and I should have use the 
--override-cc flag too:

   --override-cc     Ignore any profile or saved CC emails

I apologize for the no-relevant patches I spammed you with :(

> Cc: "Gonglei (Arei)" <[e-mail]>
> Cc: "Marc-André Lureau" <[e-mail]>
> Cc: Paolo Bonzini <[e-mail]>
> Cc: "Alex Bennée" <[e-mail]>
> Cc: "Philippe Mathieu-Daudé" <[e-mail]>
> Cc: Andrzej Zaborowski <[e-mail]>
> Cc: Peter Maydell <[e-mail]>
> Cc: "Michael S. Tsirkin" <[e-mail]>
> Cc: Kevin Wolf <[e-mail]>
> Cc: Max Reitz <[e-mail]>
> Cc: "Edgar E. Iglesias" <[e-mail]>
> Cc: Alistair Francis <[e-mail]>
> Cc: Antony Pavlov <[e-mail]>
> Cc: Igor Mitsyanko <[e-mail]>
> Cc: Fabien Chouteau <[e-mail]>
> Cc: KONRAD Frederic <[e-mail]>
> Cc: Peter Chubb <[e-mail]>
> Cc: Alberto Garcia <[e-mail]>
> Cc: Michael Walle <[e-mail]>
> Cc: Thomas Huth <[e-mail]>
> Cc: Joel Stanley <[e-mail]>
> Cc: Cornelia Huck <[e-mail]>
> Cc: Halil Pasic <[e-mail]>
> Cc: Christian Borntraeger <[e-mail]>
> Cc: Laurent Vivier <[e-mail]>
> Cc: Amit Shah <[e-mail]>
> Cc: Corey Minyard <[e-mail]>
> Cc: Paul Burton <[e-mail]>
> Cc: Aleksandar Rikalo <[e-mail]>
> Cc: Aurelien Jarno <[e-mail]>
> Cc: Aleksandar Markovic <[e-mail]>
> Cc: Palmer Dabbelt <[e-mail]>
> Cc: Sagar Karandikar <[e-mail]>
> Cc: Bastian Koppelmann <[e-mail]>
> Cc: Gerd Hoffmann <[e-mail]>
> Cc: Samuel Thibault <[e-mail]>
> Cc: "Dr. David Alan Gilbert" <[e-mail]>
> Cc: Markus Armbruster <[e-mail]>
> Cc: Zhang Chen <[e-mail]>
> Cc: Li Zhijian <[e-mail]>
> Cc: Jason Wang <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]