[v2,00/11] Add PX30 LVDS support
mbox series

Message ID 20191224143900.23567-1-miquel.raynal@bootlin.com
Headers show
Series
  • Add PX30 LVDS support
Related show

Message

Miquel Raynal Dec. 24, 2019, 2:38 p.m. UTC
Hello,

This series aims at supporting LVDS on PX30.

A first couple of patches update the documentation with the new
compatible and the presence of a PHY. Then, the existing Rockchip
driver is cleaned and extended to support PX30 specificities. Finally,
the PX30 DTSI is updated with CRTC routes, the DSI DPHY and the LVDS
IP itself.

Cheers,
Miquèl

Changes since v1:
* Added Rob's Ack.
* Used "must" instead of "should" in the bindings.
* Precised that phy-names is an optional property in the case of
  PX30.
* Renamed the WRITE_EN macro into HIWORD_UPDATE to be aligned with
  other files.
* Removed extra configuration, not needed for generic panels (see
  Sandy Huang answer).
* Dropped the display-subsystem routes (useless).
* Merged two patches to avoid phandle interdependencies in graphs and
  intermediate build errors.

Miquel Raynal (11):
  dt-bindings: display: rockchip-lvds: Declare PX30 compatible
  dt-bindings: display: rockchip-lvds: Document PX30 PHY
  drm/rockchip: lvds: Fix indentation of a #define
  drm/rockchip: lvds: Harmonize function names
  drm/rockchip: lvds: Change platform data
  drm/rockchip: lvds: Create an RK3288 specific probe function
  drm/rockchip: lvds: Helpers should return decent values
  drm/rockchip: lvds: Pack functions together
  drm/rockchip: lvds: Add PX30 support
  arm64: dts: rockchip: Add PX30 DSI DPHY
  arm64: dts: rockchip: Add PX30 LVDS

 .../display/rockchip/rockchip-lvds.txt        |   4 +
 arch/arm64/boot/dts/rockchip/px30.dtsi        |  48 ++
 drivers/gpu/drm/rockchip/rockchip_lvds.c      | 486 ++++++++++++------
 drivers/gpu/drm/rockchip/rockchip_lvds.h      |  19 +-
 4 files changed, 401 insertions(+), 156 deletions(-)

Comments

Heiko Stübner Jan. 5, 2020, 2:05 p.m. UTC | #1
Am Dienstag, 24. Dezember 2019, 15:38:49 CET schrieb Miquel Raynal:
> Hello,
> 
> This series aims at supporting LVDS on PX30.
> 
> A first couple of patches update the documentation with the new
> compatible and the presence of a PHY. Then, the existing Rockchip
> driver is cleaned and extended to support PX30 specificities. Finally,
> the PX30 DTSI is updated with CRTC routes, the DSI DPHY and the LVDS
> IP itself.
> 
> Cheers,
> Miquèl
> 
> Changes since v1:
> * Added Rob's Ack.
> * Used "must" instead of "should" in the bindings.
> * Precised that phy-names is an optional property in the case of
>   PX30.
> * Renamed the WRITE_EN macro into HIWORD_UPDATE to be aligned with
>   other files.
> * Removed extra configuration, not needed for generic panels (see
>   Sandy Huang answer).
> * Dropped the display-subsystem routes (useless).
> * Merged two patches to avoid phandle interdependencies in graphs and
>   intermediate build errors.
> 
> Miquel Raynal (11):
>   dt-bindings: display: rockchip-lvds: Declare PX30 compatible
>   dt-bindings: display: rockchip-lvds: Document PX30 PHY
>   drm/rockchip: lvds: Fix indentation of a #define
>   drm/rockchip: lvds: Harmonize function names
>   drm/rockchip: lvds: Change platform data
>   drm/rockchip: lvds: Create an RK3288 specific probe function
>   drm/rockchip: lvds: Helpers should return decent values
>   drm/rockchip: lvds: Pack functions together

applied patches 1-8 to drm-misc-next

>   drm/rockchip: lvds: Add PX30 support

drm-misc-next is currently still at 5.4-rc4, so I'll need to find out how
to get newer kernel changes in there, as right now we're missing
the PHY_MODE_LVDS constant.


Heiko

>   arm64: dts: rockchip: Add PX30 DSI DPHY
>   arm64: dts: rockchip: Add PX30 LVDS
> 
>  .../display/rockchip/rockchip-lvds.txt        |   4 +
>  arch/arm64/boot/dts/rockchip/px30.dtsi        |  48 ++
>  drivers/gpu/drm/rockchip/rockchip_lvds.c      | 486 ++++++++++++------
>  drivers/gpu/drm/rockchip/rockchip_lvds.h      |  19 +-
>  4 files changed, 401 insertions(+), 156 deletions(-)
> 
>
Heiko Stübner Jan. 6, 2020, 11:09 a.m. UTC | #2
Am Sonntag, 5. Januar 2020, 15:05:26 CET schrieb Heiko Stuebner:
> Am Dienstag, 24. Dezember 2019, 15:38:49 CET schrieb Miquel Raynal:
> > Hello,
> > 
> > This series aims at supporting LVDS on PX30.
> > 
> > A first couple of patches update the documentation with the new
> > compatible and the presence of a PHY. Then, the existing Rockchip
> > driver is cleaned and extended to support PX30 specificities. Finally,
> > the PX30 DTSI is updated with CRTC routes, the DSI DPHY and the LVDS
> > IP itself.
> > 
> > Cheers,
> > Miquèl
> > 
> > Changes since v1:
> > * Added Rob's Ack.
> > * Used "must" instead of "should" in the bindings.
> > * Precised that phy-names is an optional property in the case of
> >   PX30.
> > * Renamed the WRITE_EN macro into HIWORD_UPDATE to be aligned with
> >   other files.
> > * Removed extra configuration, not needed for generic panels (see
> >   Sandy Huang answer).
> > * Dropped the display-subsystem routes (useless).
> > * Merged two patches to avoid phandle interdependencies in graphs and
> >   intermediate build errors.
> > 
> > Miquel Raynal (11):
> >   dt-bindings: display: rockchip-lvds: Declare PX30 compatible
> >   dt-bindings: display: rockchip-lvds: Document PX30 PHY
> >   drm/rockchip: lvds: Fix indentation of a #define
> >   drm/rockchip: lvds: Harmonize function names
> >   drm/rockchip: lvds: Change platform data
> >   drm/rockchip: lvds: Create an RK3288 specific probe function
> >   drm/rockchip: lvds: Helpers should return decent values
> >   drm/rockchip: lvds: Pack functions together
> 
> applied patches 1-8 to drm-misc-next
> 
> >   drm/rockchip: lvds: Add PX30 support
> 
> drm-misc-next is currently still at 5.4-rc4, so I'll need to find out how
> to get newer kernel changes in there, as right now we're missing
> the PHY_MODE_LVDS constant.

applied now to drm-misc-next as well, after drm-misc maintainers did the
requested back-merge to get that constant.

Heiko
Miquel Raynal Jan. 6, 2020, 12:15 p.m. UTC | #3
Hi Heiko,

Heiko Stübner <heiko@sntech.de> wrote on Mon, 06 Jan 2020 12:09:19
+0100:

> Am Sonntag, 5. Januar 2020, 15:05:26 CET schrieb Heiko Stuebner:
> > Am Dienstag, 24. Dezember 2019, 15:38:49 CET schrieb Miquel Raynal:  
> > > Hello,
> > > 
> > > This series aims at supporting LVDS on PX30.
> > > 
> > > A first couple of patches update the documentation with the new
> > > compatible and the presence of a PHY. Then, the existing Rockchip
> > > driver is cleaned and extended to support PX30 specificities. Finally,
> > > the PX30 DTSI is updated with CRTC routes, the DSI DPHY and the LVDS
> > > IP itself.
> > > 
> > > Cheers,
> > > Miquèl
> > > 
> > > Changes since v1:
> > > * Added Rob's Ack.
> > > * Used "must" instead of "should" in the bindings.
> > > * Precised that phy-names is an optional property in the case of
> > >   PX30.
> > > * Renamed the WRITE_EN macro into HIWORD_UPDATE to be aligned with
> > >   other files.
> > > * Removed extra configuration, not needed for generic panels (see
> > >   Sandy Huang answer).
> > > * Dropped the display-subsystem routes (useless).
> > > * Merged two patches to avoid phandle interdependencies in graphs and
> > >   intermediate build errors.
> > > 
> > > Miquel Raynal (11):
> > >   dt-bindings: display: rockchip-lvds: Declare PX30 compatible
> > >   dt-bindings: display: rockchip-lvds: Document PX30 PHY
> > >   drm/rockchip: lvds: Fix indentation of a #define
> > >   drm/rockchip: lvds: Harmonize function names
> > >   drm/rockchip: lvds: Change platform data
> > >   drm/rockchip: lvds: Create an RK3288 specific probe function
> > >   drm/rockchip: lvds: Helpers should return decent values
> > >   drm/rockchip: lvds: Pack functions together  
> > 
> > applied patches 1-8 to drm-misc-next
> >   
> > >   drm/rockchip: lvds: Add PX30 support  
> > 
> > drm-misc-next is currently still at 5.4-rc4, so I'll need to find out how
> > to get newer kernel changes in there, as right now we're missing
> > the PHY_MODE_LVDS constant.  
> 
> applied now to drm-misc-next as well, after drm-misc maintainers did the
> requested back-merge to get that constant.

Great! Thanks a lot for your time!

Miquèl