[0/2] make generic-adc-thermal less noisy

Message

Martin Blumenstingl Jan. 7, 2020, 11:20 p.m. UTC

I want to use generic-adc-thermal on the 32-bit Amlogic SoCs in the
future. These have a thermal sensors which can be read through the
SAR ADC (for which we have an IIO driver) on those SoCs.

While testing I found the generic-adc-thermal driver to be a bit
noisy when operating in well supported environment:
- the SoC temperature sensor on the 32-bit Amlogic SoCs is typically
  loaded late because of it's dependencies (it needs data from the
  eFuse and a syscon to calibrate). Yet I still got a message stating
  there's no lookup table for the generic-adc-thermal defined (which
  is expected and perfectly valid on these Amlogic SoCs, as the IIO
  channel returns the temperature).
- the IIO channel is correctly defined with type IIO_TEMP, yet the
  generic-adc-thermal driver still prints a message which first lead
  me to believe that I passed an incorrect IIO channel (one that
  returns a voltage).


Martin Blumenstingl (2):
  thermal: generic-adc: silence "no lookup table" on deferred probe
  thermal: generic-adc: silence info message for IIO_TEMP channels

 drivers/thermal/thermal-generic-adc.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

Comments

Daniel Lezcano Jan. 9, 2020, 10:43 p.m. UTC | #1

On 08/01/2020 00:20, Martin Blumenstingl wrote:
> I want to use generic-adc-thermal on the 32-bit Amlogic SoCs in the
> future. These have a thermal sensors which can be read through the
> SAR ADC (for which we have an IIO driver) on those SoCs.
> 
> While testing I found the generic-adc-thermal driver to be a bit
> noisy when operating in well supported environment:
> - the SoC temperature sensor on the 32-bit Amlogic SoCs is typically
>   loaded late because of it's dependencies (it needs data from the
>   eFuse and a syscon to calibrate). Yet I still got a message stating
>   there's no lookup table for the generic-adc-thermal defined (which
>   is expected and perfectly valid on these Amlogic SoCs, as the IIO
>   channel returns the temperature).
> - the IIO channel is correctly defined with type IIO_TEMP, yet the
>   generic-adc-thermal driver still prints a message which first lead
>   me to believe that I passed an incorrect IIO channel (one that
>   returns a voltage).
> 
> 
> Martin Blumenstingl (2):
>   thermal: generic-adc: silence "no lookup table" on deferred probe
>   thermal: generic-adc: silence info message for IIO_TEMP channels
> 
>  drivers/thermal/thermal-generic-adc.c | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)

Applied, thanks