[V5,0/4] ARM: Enable thermal support for Raspberry Pi 4
mbox series

Message ID 1578941778-23321-1-git-send-email-stefan.wahren@i2se.com
Headers show
Series
  • ARM: Enable thermal support for Raspberry Pi 4
Related show

Message

Stefan Wahren Jan. 13, 2020, 6:56 p.m. UTC
This series enables thermal support for the Raspberry Pi 4. Neither the
bcm2835_thermal nor the brcmstb_thermal are suitable for the BCM2711.
So add a new thermal driver to read out the SoC temperature from the
AVS RO block of the BCM2711.

Changes in V5:
- git the rid of device member in private structure
- improve readability of bcm2711_get_temp
- avoid trace message in get_temp callback

Changes in V4:
- change my email address to avoid spurious characters

Changes in V3:
- add Rob's, Florian's and Nicolas' reviewed-by/tested-by
- adjust binding license
- make error pointer handling consistent

Changes in V2:
- rebase on thermal/linux-next
- convert binding to YAML
- make AVS RO block a subnode of AVS monitor and access it via syscon
- drop unnecessary TSENS clock and get the rid of remove callback
- add Florian's reviewed-by to last/unchanged patch

Stefan Wahren (4):
  dt-bindings: Add Broadcom AVS RO thermal
  thermal: Add BCM2711 thermal driver
  ARM: dts: bcm2711: Enable thermal
  ARM: configs: Build BCM2711 thermal as module

 .../bindings/thermal/brcm,avs-ro-thermal.yaml      |  45 ++++++++
 arch/arm/boot/dts/bcm2711.dtsi                     |  12 ++
 arch/arm/configs/multi_v7_defconfig                |   1 +
 arch/arm64/configs/defconfig                       |   1 +
 drivers/thermal/broadcom/Kconfig                   |   7 ++
 drivers/thermal/broadcom/Makefile                  |   1 +
 drivers/thermal/broadcom/bcm2711_thermal.c         | 123 +++++++++++++++++++++
 7 files changed, 190 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
 create mode 100644 drivers/thermal/broadcom/bcm2711_thermal.c

Comments

Daniel Lezcano Jan. 13, 2020, 7:10 p.m. UTC | #1
Hi Stefan,

how do you want the series merged?

On 13/01/2020 19:56, Stefan Wahren wrote:
> This series enables thermal support for the Raspberry Pi 4. Neither the
> bcm2835_thermal nor the brcmstb_thermal are suitable for the BCM2711.
> So add a new thermal driver to read out the SoC temperature from the
> AVS RO block of the BCM2711.
> 
> Changes in V5:
> - git the rid of device member in private structure
> - improve readability of bcm2711_get_temp
> - avoid trace message in get_temp callback
> 
> Changes in V4:
> - change my email address to avoid spurious characters
> 
> Changes in V3:
> - add Rob's, Florian's and Nicolas' reviewed-by/tested-by
> - adjust binding license
> - make error pointer handling consistent
> 
> Changes in V2:
> - rebase on thermal/linux-next
> - convert binding to YAML
> - make AVS RO block a subnode of AVS monitor and access it via syscon
> - drop unnecessary TSENS clock and get the rid of remove callback
> - add Florian's reviewed-by to last/unchanged patch
> 
> Stefan Wahren (4):
>   dt-bindings: Add Broadcom AVS RO thermal
>   thermal: Add BCM2711 thermal driver
>   ARM: dts: bcm2711: Enable thermal
>   ARM: configs: Build BCM2711 thermal as module
> 
>  .../bindings/thermal/brcm,avs-ro-thermal.yaml      |  45 ++++++++
>  arch/arm/boot/dts/bcm2711.dtsi                     |  12 ++
>  arch/arm/configs/multi_v7_defconfig                |   1 +
>  arch/arm64/configs/defconfig                       |   1 +
>  drivers/thermal/broadcom/Kconfig                   |   7 ++
>  drivers/thermal/broadcom/Makefile                  |   1 +
>  drivers/thermal/broadcom/bcm2711_thermal.c         | 123 +++++++++++++++++++++
>  7 files changed, 190 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml
>  create mode 100644 drivers/thermal/broadcom/bcm2711_thermal.c
>
Stefan Wahren Jan. 13, 2020, 7:20 p.m. UTC | #2
Hi Daniel,

Am 13.01.20 um 20:10 schrieb Daniel Lezcano:
> Hi Stefan,
>
> how do you want the series merged?

i'm not BCM2835 maintainer anymore, so the final decision is up to
Nicolas or Florian.

But if i can make a wish, it would be nice to take as much as possible
via the thermal tree, because Nicolas already sent the pull requests for
5.6.

Thanks
Stefan
Daniel Lezcano Jan. 13, 2020, 7:24 p.m. UTC | #3
On 13/01/2020 20:20, Stefan Wahren wrote:
> Hi Daniel,
> 
> Am 13.01.20 um 20:10 schrieb Daniel Lezcano:
>> Hi Stefan,
>>
>> how do you want the series merged?
> 
> i'm not BCM2835 maintainer anymore, so the final decision is up to
> Nicolas or Florian.
> 
> But if i can make a wish, it would be nice to take as much as possible
> via the thermal tree, because Nicolas already sent the pull requests for
> 5.6.

Ok, I can take the series if it is fine for everyone else.
Nicolas Saenz Julienne Jan. 13, 2020, 7:54 p.m. UTC | #4
On Mon, 2020-01-13 at 20:24 +0100, Daniel Lezcano wrote:
> On 13/01/2020 20:20, Stefan Wahren wrote:
> > Hi Daniel,
> > 
> > Am 13.01.20 um 20:10 schrieb Daniel Lezcano:
> > > Hi Stefan,
> > > 
> > > how do you want the series merged?
> > 
> > i'm not BCM2835 maintainer anymore, so the final decision is up to
> > Nicolas or Florian.
> > 
> > But if i can make a wish, it would be nice to take as much as possible
> > via the thermal tree, because Nicolas already sent the pull requests for
> > 5.6.
> 
> Ok, I can take the series if it is fine for everyone else.

Sounds good to me. Thanks!

Nicolas
Florian Fainelli Jan. 15, 2020, 11:44 p.m. UTC | #5
On 1/13/20 11:54 AM, Nicolas Saenz Julienne wrote:
> On Mon, 2020-01-13 at 20:24 +0100, Daniel Lezcano wrote:
>> On 13/01/2020 20:20, Stefan Wahren wrote:
>>> Hi Daniel,
>>>
>>> Am 13.01.20 um 20:10 schrieb Daniel Lezcano:
>>>> Hi Stefan,
>>>>
>>>> how do you want the series merged?
>>>
>>> i'm not BCM2835 maintainer anymore, so the final decision is up to
>>> Nicolas or Florian.
>>>
>>> But if i can make a wish, it would be nice to take as much as possible
>>> via the thermal tree, because Nicolas already sent the pull requests for
>>> 5.6.
>>
>> Ok, I can take the series if it is fine for everyone else.
> 
> Sounds good to me. Thanks!

Works for me as well, thanks!