[v6,00/16] xfs: Delay Ready Attributes
mbox series

Message ID 20200118225035.19503-1-allison.henderson@oracle.com
Headers show
  • xfs: Delay Ready Attributes
Related show


Allison Collins Jan. 18, 2020, 10:50 p.m. UTC
Hi all,

This set is a subset of a larger series for delayed attributes. Which is a
subset of an even larger series, parent pointers. Delayed attributes allow
attribute operations (set and remove) to be logged and committed in the same way
that other delayed operations do. This allows more complex operations (like
parent pointers) to be broken up into multiple smaller transactions. To do this,
the existing attr operations must be modified to operate as either a delayed
operation or a inline operation since older filesystems will not be able to use
the new log entries. This means that they cannot roll, commit, or finish
transactions. Instead, they return  EAGAIN an allow the calling function to
handle the transaction. In this series, we focus on only the clean up and
refactoring needed to accomplish this. We will introduce delayed attrs and
parent pointers in a later set.

I know there are some other sets waiting for review that intersect with this
one, and I still need to go through those (not forgotten, just queued).  But I
wanted to get an update out before too much time gets away.

Changes since v5:
Mostly review updates and nits collected since v5.  Patches 12, 13 and 14 are
new, and help to modularize and simplify the larger routines in 15 and 16.

I've also made the corresponding updates to the user space side as well.

Questions, comment and feedback appreciated! 

Thanks all!

Allison Collins (15):
  xfs: Replace attribute parameters with struct xfs_name
  xfs: Embed struct xfs_name in xfs_da_args
  xfs: Factor out new helper functions xfs_attr_rmtval_set
  xfs: Factor out trans handling in xfs_attr3_leaf_flipflags
  xfs: Factor out xfs_attr_leaf_addname helper
  xfs: Refactor xfs_attr_try_sf_addname
  xfs: Factor out trans roll from xfs_attr3_leaf_setflag
  xfs: Factor out xfs_attr_rmtval_invalidate
  xfs: Factor out trans roll in xfs_attr3_leaf_clearflag
  xfs: Check for -ENOATTR or -EEXIST
  xfs: Add helper function xfs_attr_init_unmapstate
  xfs: Add helper function xfs_attr_rmtval_unmap
  xfs: Simplify xfs_attr_set_args
  xfs: Add delay ready attr remove routines
  xfs: Add delay ready attr set routines

Allison Henderson (1):
  xfs: Add xfs_has_attr and subroutines

 fs/xfs/libxfs/xfs_attr.c        | 866 +++++++++++++++++++++++++++-------------
 fs/xfs/libxfs/xfs_attr.h        |  15 +-
 fs/xfs/libxfs/xfs_attr_leaf.c   | 220 +++++-----
 fs/xfs/libxfs/xfs_attr_leaf.h   |   3 +
 fs/xfs/libxfs/xfs_attr_remote.c | 265 +++++++++---
 fs/xfs/libxfs/xfs_attr_remote.h |   7 +-
 fs/xfs/libxfs/xfs_da_btree.c    |   6 +-
 fs/xfs/libxfs/xfs_da_btree.h    |  41 +-
 fs/xfs/libxfs/xfs_dir2.c        |  18 +-
 fs/xfs/libxfs/xfs_dir2_block.c  |   6 +-
 fs/xfs/libxfs/xfs_dir2_leaf.c   |   6 +-
 fs/xfs/libxfs/xfs_dir2_node.c   |   8 +-
 fs/xfs/libxfs/xfs_dir2_sf.c     |  30 +-
 fs/xfs/libxfs/xfs_types.c       |  11 +
 fs/xfs/libxfs/xfs_types.h       |   1 +
 fs/xfs/scrub/attr.c             |  12 +-
 fs/xfs/scrub/common.c           |   2 +
 fs/xfs/xfs_acl.c                |  27 +-
 fs/xfs/xfs_attr_list.c          |   1 +
 fs/xfs/xfs_ioctl.c              |  25 +-
 fs/xfs/xfs_ioctl32.c            |   2 +
 fs/xfs/xfs_iops.c               |   8 +-
 fs/xfs/xfs_trace.h              |  20 +-
 fs/xfs/xfs_xattr.c              |  29 +-
 24 files changed, 1095 insertions(+), 534 deletions(-)