[0/7] ASoC: soc-pcm: add soc_rtd_xxx()

Message

Kuninori Morimoto Jan. 22, 2020, 12:44 a.m. UTC

Hi Mark

My ALSA SoC cleanup series focus to soc-pcm as 2nd step :)
These create new soc_rtd_xxx() function, and cleanup soc-pcm.c
(It will be more cleanup later)

Kuninori Morimoto (7):
  ASoC: soc-pcm: add soc_rtd_startup()
  ASoC: soc-pcm: add soc_rtd_shutdown()
  ASoC: soc-pcm: add soc_rtd_prepare()
  ASoC: soc-pcm: add soc_rtd_hw_params()
  ASoC: soc-pcm: add soc_rtd_hw_free()
  ASoC: soc-pcm: add soc_rtd_trigger()
  ASoC: soc-core: remove null_snd_soc_ops

 sound/soc/soc-core.c |   4 --
 sound/soc/soc-pcm.c  | 118 ++++++++++++++++++++++++++++++++++-----------------
 2 files changed, 79 insertions(+), 43 deletions(-)

Comments

Sridharan, Ranjani Jan. 22, 2020, 4:30 a.m. UTC | #1

On Tue, Jan 21, 2020 at 4:46 PM Kuninori Morimoto <
[e-mail]> wrote:

>
> Hi Mark
>
> My ALSA SoC cleanup series focus to soc-pcm as 2nd step :)
> These create new soc_rtd_xxx() function, and cleanup soc-pcm.c
> (It will be more cleanup later)
>
> Kuninori Morimoto (7):
>   ASoC: soc-pcm: add soc_rtd_startup()
>   ASoC: soc-pcm: add soc_rtd_shutdown()
>   ASoC: soc-pcm: add soc_rtd_prepare()
>   ASoC: soc-pcm: add soc_rtd_hw_params()
>   ASoC: soc-pcm: add soc_rtd_hw_free()
>   ASoC: soc-pcm: add soc_rtd_trigger()
>   ASoC: soc-core: remove null_snd_soc_ops

The series looks good. Thanks, Morimoto-san.

Reviewed-by: Ranjani Sridharan <[e-mail]>

Pierre-Louis Bossart Jan. 22, 2020, 10:42 a.m. UTC | #2

>> My ALSA SoC cleanup series focus to soc-pcm as 2nd step :)
>> These create new soc_rtd_xxx() function, and cleanup soc-pcm.c
>> (It will be more cleanup later)
>>
>> Kuninori Morimoto (7):
>>    ASoC: soc-pcm: add soc_rtd_startup()
>>    ASoC: soc-pcm: add soc_rtd_shutdown()
>>    ASoC: soc-pcm: add soc_rtd_prepare()
>>    ASoC: soc-pcm: add soc_rtd_hw_params()
>>    ASoC: soc-pcm: add soc_rtd_hw_free()
>>    ASoC: soc-pcm: add soc_rtd_trigger()
>>    ASoC: soc-core: remove null_snd_soc_ops
> 
> The series looks good. Thanks, Morimoto-san.
> 
> Reviewed-by: Ranjani Sridharan <[e-mail]>

LGTM as well.

Reviewed-by: Pierre-Louis Bossart <[e-mail]>