mbox series

[v9,0/4] purge free_shared_domheap_page()

Message ID 20200203105654.22998-1-pdurrant@amazon.com (mailing list archive)
Headers show
Series purge free_shared_domheap_page() | expand

Message

Paul Durrant Feb. 3, 2020, 10:56 a.m. UTC
Paul Durrant (4):
  x86 / vmx: move teardown from domain_destroy()...
  add a domain_tot_pages() helper function
  mm: make pages allocated with MEMF_no_refcount safe to assign
  x86 / vmx: use a MEMF_no_refcount domheap page for
    APIC_DEFAULT_PHYS_BASE

 xen/arch/arm/arm64/domctl.c     |  2 +-
 xen/arch/x86/domain.c           |  2 +-
 xen/arch/x86/hvm/vmx/vmx.c      | 25 ++++++++---
 xen/arch/x86/mm.c               | 15 ++-----
 xen/arch/x86/mm/p2m-pod.c       | 10 ++---
 xen/arch/x86/mm/shadow/common.c |  2 +-
 xen/arch/x86/msi.c              |  2 +-
 xen/arch/x86/numa.c             |  2 +-
 xen/arch/x86/pv/dom0_build.c    | 25 ++++++-----
 xen/arch/x86/pv/domain.c        |  2 +-
 xen/arch/x86/pv/shim.c          |  4 +-
 xen/common/domctl.c             |  2 +-
 xen/common/grant_table.c        |  4 +-
 xen/common/keyhandler.c         |  2 +-
 xen/common/memory.c             |  2 +-
 xen/common/page_alloc.c         | 78 ++++++++++++++++++++++++---------
 xen/include/asm-arm/mm.h        |  5 ++-
 xen/include/asm-x86/mm.h        |  9 ++--
 xen/include/public/memory.h     |  4 +-
 xen/include/xen/sched.h         | 27 +++++++++---
 20 files changed, 143 insertions(+), 81 deletions(-)
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Julien Grall <julien@xen.org>
Cc: Jun Nakajima <jun.nakajima@intel.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Wei Liu <wl@xen.org>

Comments

Durrant, Paul Feb. 6, 2020, 8:28 a.m. UTC | #1
AFAICT these patches have the necessary A-b/R-b-s, or are there some missing that I need to chase?

  Paul

> -----Original Message-----
> From: Paul Durrant <pdurrant@amazon.com>
> Sent: 03 February 2020 10:57
> To: xen-devel@lists.xenproject.org
> Cc: Durrant, Paul <pdurrant@amazon.co.uk>; Andrew Cooper
> <andrew.cooper3@citrix.com>; George Dunlap <george.dunlap@citrix.com>; Ian
> Jackson <ian.jackson@eu.citrix.com>; Julien Grall <julien@xen.org>; Jun
> Nakajima <jun.nakajima@intel.com>; Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com>; Roger Pau Monné <roger.pau@citrix.com>; Stefano
> Stabellini <sstabellini@kernel.org>; Tim Deegan <tim@xen.org>; Volodymyr
> Babchuk <Volodymyr_Babchuk@epam.com>; Wei Liu <wl@xen.org>
> Subject: [PATCH v9 0/4] purge free_shared_domheap_page()
> 
> Paul Durrant (4):
>   x86 / vmx: move teardown from domain_destroy()...
>   add a domain_tot_pages() helper function
>   mm: make pages allocated with MEMF_no_refcount safe to assign
>   x86 / vmx: use a MEMF_no_refcount domheap page for
>     APIC_DEFAULT_PHYS_BASE
> 
>  xen/arch/arm/arm64/domctl.c     |  2 +-
>  xen/arch/x86/domain.c           |  2 +-
>  xen/arch/x86/hvm/vmx/vmx.c      | 25 ++++++++---
>  xen/arch/x86/mm.c               | 15 ++-----
>  xen/arch/x86/mm/p2m-pod.c       | 10 ++---
>  xen/arch/x86/mm/shadow/common.c |  2 +-
>  xen/arch/x86/msi.c              |  2 +-
>  xen/arch/x86/numa.c             |  2 +-
>  xen/arch/x86/pv/dom0_build.c    | 25 ++++++-----
>  xen/arch/x86/pv/domain.c        |  2 +-
>  xen/arch/x86/pv/shim.c          |  4 +-
>  xen/common/domctl.c             |  2 +-
>  xen/common/grant_table.c        |  4 +-
>  xen/common/keyhandler.c         |  2 +-
>  xen/common/memory.c             |  2 +-
>  xen/common/page_alloc.c         | 78 ++++++++++++++++++++++++---------
>  xen/include/asm-arm/mm.h        |  5 ++-
>  xen/include/asm-x86/mm.h        |  9 ++--
>  xen/include/public/memory.h     |  4 +-
>  xen/include/xen/sched.h         | 27 +++++++++---
>  20 files changed, 143 insertions(+), 81 deletions(-)
> ---
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Jun Nakajima <jun.nakajima@intel.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: "Roger Pau Monné" <roger.pau@citrix.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Tim Deegan <tim@xen.org>
> Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> Cc: Wei Liu <wl@xen.org>
> --
> 2.20.1
Jan Beulich Feb. 6, 2020, 8:45 a.m. UTC | #2
On 06.02.2020 09:28, Durrant, Paul wrote:
> AFAICT these patches have the necessary A-b/R-b-s, or are there some missing that I need to chase?

According to my records ...

>> -----Original Message-----
>> From: Paul Durrant <pdurrant@amazon.com>
>> Sent: 03 February 2020 10:57
>>
>> Paul Durrant (4):
>>   x86 / vmx: move teardown from domain_destroy()...
>>   add a domain_tot_pages() helper function
>>   mm: make pages allocated with MEMF_no_refcount safe to assign
>>   x86 / vmx: use a MEMF_no_refcount domheap page for
>>     APIC_DEFAULT_PHYS_BASE
>>
>>  xen/arch/arm/arm64/domctl.c     |  2 +-

... this (Arm), ...

>>  xen/arch/x86/domain.c           |  2 +-
>>  xen/arch/x86/hvm/vmx/vmx.c      | 25 ++++++++---

... this (VMX), ...

>>  xen/arch/x86/mm.c               | 15 ++-----
>>  xen/arch/x86/mm/p2m-pod.c       | 10 ++---

... this (MM), ...

>>  xen/arch/x86/mm/shadow/common.c |  2 +-

... this (shadow), ...

>>  xen/arch/x86/msi.c              |  2 +-
>>  xen/arch/x86/numa.c             |  2 +-
>>  xen/arch/x86/pv/dom0_build.c    | 25 ++++++-----
>>  xen/arch/x86/pv/domain.c        |  2 +-
>>  xen/arch/x86/pv/shim.c          |  4 +-
>>  xen/common/domctl.c             |  2 +-
>>  xen/common/grant_table.c        |  4 +-
>>  xen/common/keyhandler.c         |  2 +-
>>  xen/common/memory.c             |  2 +-
>>  xen/common/page_alloc.c         | 78 ++++++++++++++++++++++++---------
>>  xen/include/asm-arm/mm.h        |  5 ++-

... and this (Arm again). I think almost all are for patch 2, with
an Arm one needed on patch 3. If I overlooked any, please point me
at them.

Jan
Durrant, Paul Feb. 6, 2020, 9:17 a.m. UTC | #3
> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: 06 February 2020 08:46
> To: Durrant, Paul <pdurrant@amazon.co.uk>
> Cc: xen-devel@lists.xenproject.org; Stefano Stabellini
> <sstabellini@kernel.org>; Julien Grall <julien@xen.org>; Wei Liu
> <wl@xen.org>; Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; Andrew
> Cooper <andrew.cooper3@citrix.com>; Ian Jackson
> <ian.jackson@eu.citrix.com>; George Dunlap <george.dunlap@citrix.com>; Tim
> Deegan <tim@xen.org>; Jun Nakajima <jun.nakajima@intel.com>; Volodymyr
> Babchuk <Volodymyr_Babchuk@epam.com>; Roger Pau Monné
> <roger.pau@citrix.com>
> Subject: Re: [Xen-devel] [PATCH v9 0/4] purge free_shared_domheap_page()
> 
> On 06.02.2020 09:28, Durrant, Paul wrote:
> > AFAICT these patches have the necessary A-b/R-b-s, or are there some
> missing that I need to chase?
> 
> According to my records ...
> 
> >> -----Original Message-----
> >> From: Paul Durrant <pdurrant@amazon.com>
> >> Sent: 03 February 2020 10:57
> >>
> >> Paul Durrant (4):
> >>   x86 / vmx: move teardown from domain_destroy()...
> >>   add a domain_tot_pages() helper function
> >>   mm: make pages allocated with MEMF_no_refcount safe to assign
> >>   x86 / vmx: use a MEMF_no_refcount domheap page for
> >>     APIC_DEFAULT_PHYS_BASE
> >>
> >>  xen/arch/arm/arm64/domctl.c     |  2 +-
> 
> ... this (Arm), ...
> 
> >>  xen/arch/x86/domain.c           |  2 +-
> >>  xen/arch/x86/hvm/vmx/vmx.c      | 25 ++++++++---
> 
> ... this (VMX), ...
> 
> >>  xen/arch/x86/mm.c               | 15 ++-----
> >>  xen/arch/x86/mm/p2m-pod.c       | 10 ++---
> 
> ... this (MM), ...
> 
> >>  xen/arch/x86/mm/shadow/common.c |  2 +-
> 
> ... this (shadow), ...
> 
> >>  xen/arch/x86/msi.c              |  2 +-
> >>  xen/arch/x86/numa.c             |  2 +-
> >>  xen/arch/x86/pv/dom0_build.c    | 25 ++++++-----
> >>  xen/arch/x86/pv/domain.c        |  2 +-
> >>  xen/arch/x86/pv/shim.c          |  4 +-
> >>  xen/common/domctl.c             |  2 +-
> >>  xen/common/grant_table.c        |  4 +-
> >>  xen/common/keyhandler.c         |  2 +-
> >>  xen/common/memory.c             |  2 +-
> >>  xen/common/page_alloc.c         | 78 ++++++++++++++++++++++++---------
> >>  xen/include/asm-arm/mm.h        |  5 ++-
> 
> ... and this (Arm again). I think almost all are for patch 2, with
> an Arm one needed on patch 3. If I overlooked any, please point me
> at them.

Ok, thanks. Kevin has completed his acks (patches #1 and #4).

George, Julien, Tim,

  Can I have acks or otherwise, please?

  Paul

> 
> Jan
Tim Deegan Feb. 8, 2020, 6:58 a.m. UTC | #4
At 09:17 +0000 on 06 Feb (1580980664), Durrant, Paul wrote:
> > -----Original Message-----
> > From: Jan Beulich <jbeulich@suse.com>
> > On 06.02.2020 09:28, Durrant, Paul wrote:
> > >>  xen/arch/x86/mm/shadow/common.c |  2 +-

> George, Julien, Tim,
> 
>   Can I have acks or otherwise, please?

Acked-by: Tim Deegan <tim@xen.org>

Cheers,

Tim.
Durrant, Paul Feb. 13, 2020, 12:53 p.m. UTC | #5
> -----Original Message-----
[snip]
> 
> Ok, thanks. Kevin has completed his acks (patches #1 and #4).
> 
> George, Julien, Tim,
> 
>   Can I have acks or otherwise, please?
> 

I have acks from Julien and Tim. George, can you ack or otherwise please?

  Paul