[0/3,v2] Fix btrfs check handling of missing file extents

Message

Josef Bacik Feb. 4, 2020, 2:32 p.m. UTC

v1->v2:
- While running full xfstests with the new progs I noticed failures for tests
  that should have been fine.  Turns out our check will not wander down shared
  blocks, instead it'll merge inode records, which makes setting the
  rec->extent_start to key.offset very important.  So instead fix the problem by
  checking for the start gap once we're done doing all the merging.
- Added a third patch to make the hole error message actually correct when we
  have a gap at the beginning.

--------------- Original message ------------------

While adding an xfstest for the missing file extent problem I fixed with the
series

  btrfs: fix hole corruption issue with !NO_HOLES

I was failing to fail my test without my patches, despite the file system being
actually wrong.

It turns out because the normal check mode sets its expected start to the first
file extent it finds, instead of 0.  This means it misses any gaps between 0 and
the first file extent item in the inode.

The lowmem check does not have this issue, instead it doesn't take into account
the isize of the inode, so improperly fails when we have a gap but that is
outside of the isize.  I fixed this as well.

With these patches we're able to properly find another set of corruptions, and
now my xfstest acts sanely.  Thanks,

Josef