[0/5] disable drm_global_mutex for most drivers, take 2
mbox series

Message ID 20200204150146.2006481-1-daniel.vetter@ffwll.ch
Headers show
Series
  • disable drm_global_mutex for most drivers, take 2
Related show

Message

Daniel Vetter Feb. 4, 2020, 3:01 p.m. UTC
CI didn't like my test-with tag :-/

Test-with: 20200128112549.172135-1-daniel.vetter@ffwll.ch

Daniel Vetter (5):
  drm: Complain if drivers still use the ->load callback
  drm/fbdev-helper: don't force restores
  drm/client: Rename _force to _locked
  drm: Push drm_global_mutex locking in drm_open
  drm: Nerf drm_global_mutex BKL for good drivers

 drivers/gpu/drm/drm_client_modeset.c | 12 +++++---
 drivers/gpu/drm/drm_drv.c            | 26 +++++++++-------
 drivers/gpu/drm/drm_fb_helper.c      | 16 ++--------
 drivers/gpu/drm/drm_file.c           | 46 ++++++++++++++++++++++++++--
 drivers/gpu/drm/drm_internal.h       |  1 +
 include/drm/drm_client.h             |  7 ++++-
 include/drm/drm_drv.h                |  3 ++
 7 files changed, 79 insertions(+), 32 deletions(-)

Comments

Thomas Zimmermann Feb. 7, 2020, 1:37 p.m. UTC | #1
Hi,

On patches 2 to 5:

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

I'm not overly knowledgeable on DRM locking semantics, but the patches
appear to be correct in general.

Best regards
Thomas


Am 04.02.20 um 16:01 schrieb Daniel Vetter:
> CI didn't like my test-with tag :-/
> 
> Test-with: 20200128112549.172135-1-daniel.vetter@ffwll.ch
> 
> Daniel Vetter (5):
>   drm: Complain if drivers still use the ->load callback
>   drm/fbdev-helper: don't force restores
>   drm/client: Rename _force to _locked
>   drm: Push drm_global_mutex locking in drm_open
>   drm: Nerf drm_global_mutex BKL for good drivers
> 
>  drivers/gpu/drm/drm_client_modeset.c | 12 +++++---
>  drivers/gpu/drm/drm_drv.c            | 26 +++++++++-------
>  drivers/gpu/drm/drm_fb_helper.c      | 16 ++--------
>  drivers/gpu/drm/drm_file.c           | 46 ++++++++++++++++++++++++++--
>  drivers/gpu/drm/drm_internal.h       |  1 +
>  include/drm/drm_client.h             |  7 ++++-
>  include/drm/drm_drv.h                |  3 ++
>  7 files changed, 79 insertions(+), 32 deletions(-)
>
Thomas Zimmermann Feb. 10, 2020, 9:47 a.m. UTC | #2
Hi,

I smoke-tested the patchset by running X11, Weston and fbdev emulation
on ast and udl. No apparent problems found, so

Tested-by: Thomas Zimmermann <tzimmermann@suse.de>

Best regards
Thomas

Am 04.02.20 um 16:01 schrieb Daniel Vetter:
> CI didn't like my test-with tag :-/
> 
> Test-with: 20200128112549.172135-1-daniel.vetter@ffwll.ch
> 
> Daniel Vetter (5):
>   drm: Complain if drivers still use the ->load callback
>   drm/fbdev-helper: don't force restores
>   drm/client: Rename _force to _locked
>   drm: Push drm_global_mutex locking in drm_open
>   drm: Nerf drm_global_mutex BKL for good drivers
> 
>  drivers/gpu/drm/drm_client_modeset.c | 12 +++++---
>  drivers/gpu/drm/drm_drv.c            | 26 +++++++++-------
>  drivers/gpu/drm/drm_fb_helper.c      | 16 ++--------
>  drivers/gpu/drm/drm_file.c           | 46 ++++++++++++++++++++++++++--
>  drivers/gpu/drm/drm_internal.h       |  1 +
>  include/drm/drm_client.h             |  7 ++++-
>  include/drm/drm_drv.h                |  3 ++
>  7 files changed, 79 insertions(+), 32 deletions(-)
>
Daniel Vetter Feb. 11, 2020, 11:20 a.m. UTC | #3
On Mon, Feb 10, 2020 at 10:47:36AM +0100, Thomas Zimmermann wrote:
> Hi,
> 
> I smoke-tested the patchset by running X11, Weston and fbdev emulation
> on ast and udl. No apparent problems found, so
> 
> Tested-by: Thomas Zimmermann <tzimmermann@suse.de>

Merged patches 2-5 (first one needs to wait for amdgpu/radeon patches),
thanks everyone for review&testing.
-Daniel

> 
> Best regards
> Thomas
> 
> Am 04.02.20 um 16:01 schrieb Daniel Vetter:
> > CI didn't like my test-with tag :-/
> > 
> > Test-with: 20200128112549.172135-1-daniel.vetter@ffwll.ch
> > 
> > Daniel Vetter (5):
> >   drm: Complain if drivers still use the ->load callback
> >   drm/fbdev-helper: don't force restores
> >   drm/client: Rename _force to _locked
> >   drm: Push drm_global_mutex locking in drm_open
> >   drm: Nerf drm_global_mutex BKL for good drivers
> > 
> >  drivers/gpu/drm/drm_client_modeset.c | 12 +++++---
> >  drivers/gpu/drm/drm_drv.c            | 26 +++++++++-------
> >  drivers/gpu/drm/drm_fb_helper.c      | 16 ++--------
> >  drivers/gpu/drm/drm_file.c           | 46 ++++++++++++++++++++++++++--
> >  drivers/gpu/drm/drm_internal.h       |  1 +
> >  include/drm/drm_client.h             |  7 ++++-
> >  include/drm/drm_drv.h                |  3 ++
> >  7 files changed, 79 insertions(+), 32 deletions(-)
> > 
> 
> -- 
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>