[PATCHv2,0/4] btrfs-progs: Add BTRFS_IOC_SNAP_DESTROY_V2 support
mbox series

Message ID 20200207131028.9977-1-marcos.souza.org@gmail.com
Headers show
Series
  • btrfs-progs: Add BTRFS_IOC_SNAP_DESTROY_V2 support
Related show

Message

Marcos Paulo de Souza Feb. 7, 2020, 1:10 p.m. UTC
From: Marcos Paulo de Souza <mpdesouza@suse.com>

Second version of the patchset, which pairs with v3 of kernel changes.

Changes from v1:
* Moved subvolid member to the same union containing name and devid (David)
* Dropped patch that was bumping the libbtrfsutils version (David, Wenruo)

Marcos Paulo de Souza (4):
  btrfs-progs: add IOC_SNAP_DESTROY_V2 to ioctl.h
  libbtrfsutil: add IOC_SNAP_DESTROY_V2 to ioctl.h
  libbtrfsutil: Introduce btrfs_util_delete_subvolume_by_id_fd
  cmds: subvolume: Add --subvolid argument to subvol_delete

 Documentation/btrfs-subvolume.asciidoc        |  8 ++-
 cmds/subvolume.c                              | 53 ++++++++++++++++---
 ioctl.h                                       |  8 ++-
 libbtrfsutil/btrfs.h                          |  7 ++-
 libbtrfsutil/btrfsutil.h                      | 11 ++++
 libbtrfsutil/subvolume.c                      | 16 ++++++
 tests/misc-tests/038-delete-subvolume/test.sh | 40 ++++++++++++++
 7 files changed, 134 insertions(+), 9 deletions(-)
 create mode 100755 tests/misc-tests/038-delete-subvolume/test.sh

Comments

David Sterba March 3, 2020, 6:34 p.m. UTC | #1
On Fri, Feb 07, 2020 at 10:10:24AM -0300, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
> 
> Second version of the patchset, which pairs with v3 of kernel changes.
> 
> Changes from v1:
> * Moved subvolid member to the same union containing name and devid (David)
> * Dropped patch that was bumping the libbtrfsutils version (David, Wenruo)
> 
> Marcos Paulo de Souza (4):
>   btrfs-progs: add IOC_SNAP_DESTROY_V2 to ioctl.h
>   libbtrfsutil: add IOC_SNAP_DESTROY_V2 to ioctl.h
>   libbtrfsutil: Introduce btrfs_util_delete_subvolume_by_id_fd
>   cmds: subvolume: Add --subvolid argument to subvol_delete

I've reworked it a bit, the libbtrfsutil changes can be done in one, and
the test should be separate.

The short option would be probably -i as I have some patches regarding
'sync' after deletion (ie. the 'subvolume sync') and 'i' resembles the
id more. The fstests might need to be updated once the final version is
in progs git but the internal test has a good coverage.

As for release target, this will be in 5.5 once it appears. Thanks.