mbox series

[v3,0/5] dt-bindings: convert timing + panel-dpi to DT schema

Message ID 20200216181513.28109-1-sam@ravnborg.org (mailing list archive)
Headers show
Series dt-bindings: convert timing + panel-dpi to DT schema | expand

Message

Sam Ravnborg Feb. 16, 2020, 6:15 p.m. UTC
This set of patches convert display-timing.txt to DT schema.
To do that add a panel-timing.yaml file that include all the
panel-timing properties and use this in panel-common and in display-timings.

panel-dpi was also converted so we have no .txt users left of panel-timing
in panel/

Everything passed dt_binding_check - and the trivial errors I tried in
the examples was all catched during validation.

This work was triggered by a patch-set from Oleksandr Suvorov aiming
at updating panel-lvds to support panel-dpi.
This will make it simple to add additional properties to panel-dpi.

Thanks for the quick responses on v2 and likewise the quick
feedback on the request for the license change!

Highlight from v3 - se individual patches for details.
- Added panel-dpi support to panel-simple.
  We can now add a simple panel just by addding timing parameters
  in a DT node
  The patch [5/5] is RFC as test is pending
- To support panel-dpi in panel-simple - add a data-mapping
  property to panel-dpi

Highlights from v2 - see individual patches for details.
- Got acks for the license change
- Simplfied panel-timings bindings
- panel-dpi can now be used without a panel specific compatible
  So panel-dpi can be used as a generic binding for dumb panels

Feedback welcome!

	Sam

Sam Ravnborg (5):
      dt-bindings: display: add panel-timing.yaml
      dt-bindings: display: convert display-timings to DT schema
      dt-bindings: display: convert panel-dpi to DT schema
      dt-bindings: display: add data-mapping to panel-dpi
      drm/panel: simple: add panel-dpi support

 .../bindings/display/panel/display-timing.txt      | 124 +----------
 .../bindings/display/panel/display-timings.yaml    |  77 +++++++
 .../bindings/display/panel/panel-common.yaml       |  15 +-
 .../bindings/display/panel/panel-dpi.txt           |  50 -----
 .../bindings/display/panel/panel-dpi.yaml          |  82 ++++++++
 .../bindings/display/panel/panel-timing.yaml       | 227 +++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c               |  74 ++++++-
 7 files changed, 470 insertions(+), 179 deletions(-)

Comments

Sam Ravnborg Feb. 29, 2020, 6:13 p.m. UTC | #1
On Sun, Feb 16, 2020 at 07:15:08PM +0100, Sam Ravnborg wrote:
> This set of patches convert display-timing.txt to DT schema.
> To do that add a panel-timing.yaml file that include all the
> panel-timing properties and use this in panel-common and in display-timings.
> 
> panel-dpi was also converted so we have no .txt users left of panel-timing
> in panel/
> 
> Everything passed dt_binding_check - and the trivial errors I tried in
> the examples was all catched during validation.
> 
> This work was triggered by a patch-set from Oleksandr Suvorov aiming
> at updating panel-lvds to support panel-dpi.
> This will make it simple to add additional properties to panel-dpi.
> 
> Thanks for the quick responses on v2 and likewise the quick
> feedback on the request for the license change!
> 
> Highlight from v3 - se individual patches for details.
> - Added panel-dpi support to panel-simple.
>   We can now add a simple panel just by addding timing parameters
>   in a DT node
>   The patch [5/5] is RFC as test is pending
> - To support panel-dpi in panel-simple - add a data-mapping
>   property to panel-dpi
> 
> Highlights from v2 - see individual patches for details.
> - Got acks for the license change
> - Simplfied panel-timings bindings
> - panel-dpi can now be used without a panel specific compatible
>   So panel-dpi can be used as a generic binding for dumb panels
> 
> Feedback welcome!
> 
> 	Sam
> 
> Sam Ravnborg (5):
>       dt-bindings: display: add panel-timing.yaml
>       dt-bindings: display: convert display-timings to DT schema
>       dt-bindings: display: convert panel-dpi to DT schema
>       dt-bindings: display: add data-mapping to panel-dpi
>       drm/panel: simple: add panel-dpi support

All patches now pushed to drm-misc-next.
Dropped lvds666 when applying the patches.

	Sam

> 
>  .../bindings/display/panel/display-timing.txt      | 124 +----------
>  .../bindings/display/panel/display-timings.yaml    |  77 +++++++
>  .../bindings/display/panel/panel-common.yaml       |  15 +-
>  .../bindings/display/panel/panel-dpi.txt           |  50 -----
>  .../bindings/display/panel/panel-dpi.yaml          |  82 ++++++++
>  .../bindings/display/panel/panel-timing.yaml       | 227 +++++++++++++++++++++
>  drivers/gpu/drm/panel/panel-simple.c               |  74 ++++++-
>  7 files changed, 470 insertions(+), 179 deletions(-)
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Laurent Pinchart March 3, 2020, 6:48 p.m. UTC | #2
Hi Sam,

On Sat, Feb 29, 2020 at 07:13:20PM +0100, Sam Ravnborg wrote:
> On Sun, Feb 16, 2020 at 07:15:08PM +0100, Sam Ravnborg wrote:
> > This set of patches convert display-timing.txt to DT schema.
> > To do that add a panel-timing.yaml file that include all the
> > panel-timing properties and use this in panel-common and in display-timings.
> > 
> > panel-dpi was also converted so we have no .txt users left of panel-timing
> > in panel/
> > 
> > Everything passed dt_binding_check - and the trivial errors I tried in
> > the examples was all catched during validation.
> > 
> > This work was triggered by a patch-set from Oleksandr Suvorov aiming
> > at updating panel-lvds to support panel-dpi.
> > This will make it simple to add additional properties to panel-dpi.
> > 
> > Thanks for the quick responses on v2 and likewise the quick
> > feedback on the request for the license change!
> > 
> > Highlight from v3 - se individual patches for details.
> > - Added panel-dpi support to panel-simple.
> >   We can now add a simple panel just by addding timing parameters
> >   in a DT node
> >   The patch [5/5] is RFC as test is pending
> > - To support panel-dpi in panel-simple - add a data-mapping
> >   property to panel-dpi
> > 
> > Highlights from v2 - see individual patches for details.
> > - Got acks for the license change
> > - Simplfied panel-timings bindings
> > - panel-dpi can now be used without a panel specific compatible
> >   So panel-dpi can be used as a generic binding for dumb panels
> > 
> > Feedback welcome!
> > 
> > 	Sam
> > 
> > Sam Ravnborg (5):
> >       dt-bindings: display: add panel-timing.yaml
> >       dt-bindings: display: convert display-timings to DT schema
> >       dt-bindings: display: convert panel-dpi to DT schema
> >       dt-bindings: display: add data-mapping to panel-dpi
> >       drm/panel: simple: add panel-dpi support
> 
> All patches now pushed to drm-misc-next.
> Dropped lvds666 when applying the patches.

My feedback is a bit late. Would you like to still take it into
consideration yourself, or would you like me to submit patches ?

> > 
> >  .../bindings/display/panel/display-timing.txt      | 124 +----------
> >  .../bindings/display/panel/display-timings.yaml    |  77 +++++++
> >  .../bindings/display/panel/panel-common.yaml       |  15 +-
> >  .../bindings/display/panel/panel-dpi.txt           |  50 -----
> >  .../bindings/display/panel/panel-dpi.yaml          |  82 ++++++++
> >  .../bindings/display/panel/panel-timing.yaml       | 227 +++++++++++++++++++++
> >  drivers/gpu/drm/panel/panel-simple.c               |  74 ++++++-
> >  7 files changed, 470 insertions(+), 179 deletions(-)