[0/2] slabinfo: parse all NUMA attributes
mbox series

Message ID 20200217084828.9092-1-tobin@kernel.org
Headers show
Series
  • slabinfo: parse all NUMA attributes
Related show

Message

Tobin C. Harding Feb. 17, 2020, 8:48 a.m. UTC
Hi Christoph,

I found a few files in /sys/kernel/slab/foo/ that contain NUMA info that
is not currently being parsed by `slabinfo.c`.  I do not know whether
this is intentional or not?  Since I did not know this I just printed
the info in the NUMA report section like is done for the per node slabs
and partial slabs info.

Just for your interest; I found these while re-writing slabinfo in Rust,
thanks to the type-system.  I guess that if they were unintentionally
missed then this is a small win, if they were intentionally missed then
this series is just noise :)

Patch one is a one line whitespace fix.

To test I comment out the code that inhibits NUMA output for single node
machines and then the output looks like this (relevant bit at the bottom)

$ sudo slabinfo kmem_cache_node
Slabcache: kmem_cache_node  Aliases:  0 Order :  0 Objects: 1877
** Hardware cacheline aligned

Sizes (bytes)     Slabs              Debug                Memory
------------------------------------------------------------------------
Object :      64  Total  :      34   Sanity Checks : Off  Total:  139264
SlabObj:      64  Full   :      15   Redzoning     : Off  Used :  120128
SlabSiz:    4096  Partial:      17   Poisoning     : Off  Loss :   19136
Loss   :       0  CpuSlab:       2   Tracking      : Off  Lalig:       0
Align  :      64  Objects:      64   Tracing       : Off  Lpadd:       0

kmem_cache_node has no kmem_cache operations

kmem_cache_node: Kernel object allocation
-----------------------------------------------------------------------
No Data

kmem_cache_node: Kernel object freeing
------------------------------------------------------------------------
No Data

NUMA nodes           :    0
---------------------------
All slabs                34
Partial slabs            17
CPU slabs                 2
Objects                1.8K
Partial objects         789
Total objects          2.1K

Tobin C. Harding (2):
  tools: vm: slabinfo: Replace tabs with spaces
  tools: vm: slabinfo: Add numa information for objects

 tools/vm/slabinfo.c | 69 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 63 insertions(+), 6 deletions(-)

Comments

Christopher Lameter Feb. 18, 2020, 4:16 p.m. UTC | #1
On Mon, 17 Feb 2020, Tobin C. Harding wrote:

> I found a few files in /sys/kernel/slab/foo/ that contain NUMA info that
> is not currently being parsed by `slabinfo.c`.  I do not know whether
> this is intentional or not?  Since I did not know this I just printed
> the info in the NUMA report section like is done for the per node slabs
> and partial slabs info.
>
> Just for your interest; I found these while re-writing slabinfo in Rust,
> thanks to the type-system.  I guess that if they were unintentionally
> missed then this is a small win, if they were intentionally missed then
> this series is just noise :)

It was just to make the display simpler and I did not get around to the
full implementation (by adding some sort of NUMA option) since other
things kept coming up.