From patchwork Mon Feb 17 18:43:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 11387181 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9E24817EF for ; Mon, 17 Feb 2020 18:44:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 759AF222D9 for ; Mon, 17 Feb 2020 18:44:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="SsAoDNzK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 759AF222D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j3lN3-0000jY-F8; Mon, 17 Feb 2020 18:43:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j3lN2-0000j9-Ku for xen-devel@lists.xenproject.org; Mon, 17 Feb 2020 18:43:52 +0000 X-Inumbo-ID: 7062c59c-51b5-11ea-ade5-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7062c59c-51b5-11ea-ade5-bc764e2007e4; Mon, 17 Feb 2020 18:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1581965031; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=PSjrpyWOnBjKZaPsxLjnCRSym2/6g9ulQp9N6kUFtqA=; b=SsAoDNzKmHqHhSj3forjuD2e3FSGGu/HVVdiIMnpJkIcmTNP1yCUhO7N 5JpeTC/M4Xf4e+X/jO6cNLyMgzVuHpWFNHd0icVFjxdhEmVmd5bDxXm5d 00uEhNHTB7mUzNgvuNvT8K5MqkNQ/qodnZDuKbFE7NF/QZN+uWJR//CGg 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: /DGzG4OTu0h1VzVRsdkct73Cwkv9jIzLmMlXtN/wJy39ZjO/XAlPJz07tG9SBDCty3qJxJ1w1s EQCgeQuddCyb7svH3GvZawUi2xfuDmW+KA7Ad3QX/y63oqnOaDU6bDyUlRcXF3+8WrwxQ39VEh 84i+T34cueae09OaLl4anG1bKS8ruIB0g/mRDLk5AVlZTGmExFBYf32NupQZa6EEgHlhrw102+ nC99SysC+n61IG+SeQYXWybzSP6iG31DbTCqugJWqMwIyuX1AIV3pwOQuXNa0LMAJSr1OBzArd wrM= X-SBRS: 2.7 X-MesageID: 12584066 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,453,1574139600"; d="scan'208";a="12584066" From: Roger Pau Monne To: Date: Mon, 17 Feb 2020 19:43:18 +0100 Message-ID: <20200217184324.73762-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2 0/6] x86: fixes/improvements for scratch cpumask X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Jan Beulich , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hello, Commit: 5500d265a2a8fa63d60c08beb549de8ec82ff7a5 x86/smp: use APIC ALLBUT destination shorthand when possible Introduced a bogus usage of the scratch cpumask: it was used in a function that could be called from interrupt context, and hence using the scratch cpumask there is not safe. Patch #5 is a fix for that usage, together with also preventing the usage of any per-CPU variables when send_IPI_mask is called from #MC or #NMI context. Previous patches are preparatory changes. Patch #6 adds some debug infrastructure to make sure the scratch cpumask is used in the right context, and hence should prevent further missuses. Thanks, Roger. Roger Pau Monne (6): x86/smp: unify header includes in smp.h x86: introduce a nmi_count tracking variable x86: track when in #MC context x86: track when in #NMI context x86/smp: use a dedicated scratch cpumask in send_IPI_mask x86: add accessors for scratch cpu mask xen/arch/x86/cpu/mcheck/mce.c | 2 ++ xen/arch/x86/io_apic.c | 6 +++-- xen/arch/x86/irq.c | 13 ++++++--- xen/arch/x86/mm.c | 30 ++++++++++++++------- xen/arch/x86/msi.c | 4 ++- xen/arch/x86/nmi.c | 11 ++++---- xen/arch/x86/smp.c | 51 ++++++++++++++++++++++++++++++++++- xen/arch/x86/smpboot.c | 10 +++++-- xen/arch/x86/traps.c | 10 ++++++- xen/include/asm-x86/hardirq.h | 23 +++++++++++++++- xen/include/asm-x86/nmi.h | 2 ++ xen/include/asm-x86/smp.h | 15 ++++++++--- xen/include/xen/irq_cpustat.h | 1 + 13 files changed, 148 insertions(+), 30 deletions(-)