[0/5] hwmon: (adt7475) attenuator bypass and pwm invert
mbox series

Message ID 20200217234657.9413-1-chris.packham@alliedtelesis.co.nz
Headers show
Series
  • hwmon: (adt7475) attenuator bypass and pwm invert
Related show

Message

Chris Packham Feb. 17, 2020, 11:46 p.m. UTC
I've picked up Logan's changes[1] and am combining them with an old series of
mine[2] to hopefully get them both over the line.

This series updates the binding documentation for the adt7475 and adds two new
sets of properties.

[1] - https://lore.kernel.org/linux-hwmon/20191219033213.30364-1-logan.shaw@alliedtelesis.co.nz/
[2] - https://lore.kernel.org/linux-hwmon/20181107040010.27436-1-chris.packham@alliedtelesis.co.nz/

Chris Packham (2):
  dt-bindings: hwmon: Document adt7475 invert-pwm property
  hwmon: (adt7475) Add support for inverting pwm output

Logan Shaw (3):
  dt-bindings: hwmon: Document adt7475 binding
  dt-bindings: hwmon: Document adt7475 bypass-attenuator property
  hwmon: (adt7475) Add attenuator bypass support

 .../devicetree/bindings/hwmon/adt7475.yaml    |  82 ++++++++++++++
 .../devicetree/bindings/trivial-devices.yaml  |   8 --
 drivers/hwmon/adt7475.c                       | 100 +++++++++++++++++-
 3 files changed, 179 insertions(+), 11 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.yaml

Comments

Guenter Roeck Feb. 18, 2020, 12:32 a.m. UTC | #1
On 2/17/20 3:46 PM, Chris Packham wrote:
> I've picked up Logan's changes[1] and am combining them with an old series of
> mine[2] to hopefully get them both over the line.
> 

No change log and/or history, so I guess your expectation is that it will be up
to me to figure out what may have changed and if previous comments have been
addressed or not.

Guenter

> This series updates the binding documentation for the adt7475 and adds two new
> sets of properties.
> 
> [1] - https://lore.kernel.org/linux-hwmon/20191219033213.30364-1-logan.shaw@alliedtelesis.co.nz/
> [2] - https://lore.kernel.org/linux-hwmon/20181107040010.27436-1-chris.packham@alliedtelesis.co.nz/
> 
> Chris Packham (2):
>    dt-bindings: hwmon: Document adt7475 invert-pwm property
>    hwmon: (adt7475) Add support for inverting pwm output
> 
> Logan Shaw (3):
>    dt-bindings: hwmon: Document adt7475 binding
>    dt-bindings: hwmon: Document adt7475 bypass-attenuator property
>    hwmon: (adt7475) Add attenuator bypass support
> 
>   .../devicetree/bindings/hwmon/adt7475.yaml    |  82 ++++++++++++++
>   .../devicetree/bindings/trivial-devices.yaml  |   8 --
>   drivers/hwmon/adt7475.c                       | 100 +++++++++++++++++-
>   3 files changed, 179 insertions(+), 11 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.yaml
>
Chris Packham Feb. 18, 2020, 12:43 a.m. UTC | #2
On Mon, 2020-02-17 at 16:32 -0800, Guenter Roeck wrote:
> On 2/17/20 3:46 PM, Chris Packham wrote:
> > I've picked up Logan's changes[1] and am combining them with an old series of
> > mine[2] to hopefully get them both over the line.
> > 
> 
> No change log and/or history, so I guess your expectation is that it will be up
> to me to figure out what may have changed and if previous comments have been
> addressed or not.
> 
> Guenter

Yeah sorry about that. I got as far as "is this v3 of Logan's series or
v1 of a new series" and jumped the gun.

Changes since Logan's series.
- Move existing dt-binding in patch 1/5.
- New dt-bindings in patch 2/5 and 3/5
- Patch 4/5:
-- move config2 to struct adt7475_data
-- set_property_bit() new helper function to set/clear bit based on dt
property value.
-- rename to use load_attenuators()
- Patch 5/5 rework older patch on top of this series.

> 
> > This series updates the binding documentation for the adt7475 and adds two new
> > sets of properties.
> > 
> > [1] - https://lore.kernel.org/linux-hwmon/20191219033213.30364-1-logan.shaw@alliedtelesis.co.nz/
> > [2] - https://lore.kernel.org/linux-hwmon/20181107040010.27436-1-chris.packham@alliedtelesis.co.nz/
> > 
> > Chris Packham (2):
> >    dt-bindings: hwmon: Document adt7475 invert-pwm property
> >    hwmon: (adt7475) Add support for inverting pwm output
> > 
> > Logan Shaw (3):
> >    dt-bindings: hwmon: Document adt7475 binding
> >    dt-bindings: hwmon: Document adt7475 bypass-attenuator property
> >    hwmon: (adt7475) Add attenuator bypass support
> > 
> >   .../devicetree/bindings/hwmon/adt7475.yaml    |  82 ++++++++++++++
> >   .../devicetree/bindings/trivial-devices.yaml  |   8 --
> >   drivers/hwmon/adt7475.c                       | 100 +++++++++++++++++-
> >   3 files changed, 179 insertions(+), 11 deletions(-)
> >   create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.yaml
> > 
> 
>