[0/3] ASoC: snprintf() usage fixes

Message

Takashi Iwai Feb. 18, 2020, 11:17 a.m. UTC

Hi,

this is a series of patches I spotted during debugging other code.
Intel skl and ASoC PCM core invokes succeeding calls of snprintf()
with the incorrect expectation of the return value, which may lead to
a buffer overflow.

The first patch is yet another bug I found during working on this, and
it's rather a real bug that can be seen clearly.


Takashi

===

Takashi Iwai (3):
  ASoC: intel: skl: Fix pin debug prints
  ASoC: intel: skl: Fix possible buffer overflow in debug outputs
  ASoC: pcm: Fix possible buffer overflow in dpcm state sysfs output

 sound/soc/intel/skylake/skl-debug.c | 32 +++++++++++++++++---------------
 sound/soc/soc-pcm.c                 | 16 ++++++++--------
 2 files changed, 25 insertions(+), 23 deletions(-)

Comments

Cezary Rojewski Feb. 18, 2020, 6:53 p.m. UTC | #1

On 2020-02-18 12:17, Takashi Iwai wrote:
> Hi,
> 
> this is a series of patches I spotted during debugging other code.
> Intel skl and ASoC PCM core invokes succeeding calls of snprintf()
> with the incorrect expectation of the return value, which may lead to
> a buffer overflow.
> 
> The first patch is yet another bug I found during working on this, and
> it's rather a real bug that can be seen clearly.
> 
> 
> Takashi
> 
> ===
> 
> Takashi Iwai (3):
>    ASoC: intel: skl: Fix pin debug prints
>    ASoC: intel: skl: Fix possible buffer overflow in debug outputs
>    ASoC: pcm: Fix possible buffer overflow in dpcm state sysfs output

Thank you, Takashi for the fixes.

s/skl/skylake/g but I don't mind the shortcut usage at all.
For the /intel/skylake patches:

Acked-by: Cezary Rojewski <[e-mail]>