mbox series

[v2,0/3] Add support for Pine64 PinePhone Linux Smartphone

Message ID 20200227012650.1179151-1-megous@megous.com (mailing list archive)
Headers show
Series Add support for Pine64 PinePhone Linux Smartphone | expand

Message

Ondřej Jirman Feb. 27, 2020, 1:26 a.m. UTC 
This series adds an initial support for Pine64 PinePhone.

Please take a look.

thank you and regards,
  Ondrej Jirman


Changes in v2:
- make i2c2_pins default pinctrl config for i2c2 node
- add description of the differences between 1.0 and 1.1 to the
  commit message
- added copyright header for Martijn Braam
- drop pinctrl config from i2c1 and i2c2 nodes, since it's
  now the default
- extend comments on i2c2 and uart3 nodes to be more clear
- rebased on top of linux-next and resolved conflicts
- dropped the function-enumerator from leds

Changes not made:
- I didn't drop pinctrl configs on mmc0, mmc2 and uart3
  - these are actually not default in dtsi, as was suggested
- gpio-leds kept with the new function/color binding, but I dropped
  the function-enumerator

It seems intention for the future (since about 06-2019[0]) is for LEDs to not
have a devicename in their class name, because that's determinable
from the sysfs in other ways, and to use the function and color
properties instead of label in DT.

[0] https://lore.kernel.org/lkml/20190609190803.14815-5-jacek.anaszewski@gmail.com/T/

function-enumerator is supposed to be used if function/color don't
make the LED name unique for the board. [1] So I dropped function-enumerator
from my series, as it just added a numeric suffix to the LED name
for no reason.

[1] https://lore.kernel.org/patchwork/patch/1063388/

This follow the recent new board binding additions to the kernel (in 5.6):

https://elixir.bootlin.com/linux/v5.6-rc3/source/arch/arm64/boot/dts/amlogic/meson-gx-libretech-pc.dtsi#L96

Ondrej Jirman (3):
  arm64: dts: sun50i-a64: Add i2c2 pins
  dt-bindings: arm: sunxi: Add PinePhone 1.0 and 1.1 bindings
  arm64: dts: allwinner: Add initial support for Pine64 PinePhone

 .../devicetree/bindings/arm/sunxi.yaml        |  10 +
 arch/arm64/boot/dts/allwinner/Makefile        |   2 +
 .../allwinner/sun50i-a64-pinephone-1.0.dts    |  11 +
 .../allwinner/sun50i-a64-pinephone-1.1.dts    |  11 +
 .../dts/allwinner/sun50i-a64-pinephone.dtsi   | 379 ++++++++++++++++++
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi |   8 +-
 6 files changed, 420 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi

Comments

Maxime Ripard Feb. 27, 2020, 1:04 p.m. UTC | #1 
On Thu, Feb 27, 2020 at 02:26:47AM +0100, Ondrej Jirman wrote:
> This series adds an initial support for Pine64 PinePhone.
>
> Please take a look.
>
> thank you and regards,
>   Ondrej Jirman

Applied all three, thanks

Maxime
Ondřej Jirman Feb. 27, 2020, 3:52 p.m. UTC | #2 
On Thu, Feb 27, 2020 at 02:04:27PM +0100, Maxime Ripard wrote:
> On Thu, Feb 27, 2020 at 02:26:47AM +0100, Ondrej Jirman wrote:
> > This series adds an initial support for Pine64 PinePhone.
> >
> > Please take a look.
> >
> > thank you and regards,
> >   Ondrej Jirman
> 
> Applied all three, thanks

Thank you too! :)

regards,
	o.

> Maxime