[PATCHv2,0/3] Lost key-up interrupt handling for omap4-keypad
mbox series

Message ID 20200228171223.11444-1-tony@atomide.com
Headers show
Series
  • Lost key-up interrupt handling for omap4-keypad
Related show

Message

Tony Lindgren Feb. 28, 2020, 5:12 p.m. UTC
Hi all,

This series updates omap4-keypad to configure the interrupt level and
disables unused long interrupts. And then it implements the missing parts
for the lost key-up interrupt quirk as described in the silicon errata pdf.

I can still reproduce one issue where a fast shift-shift-j can produce an
upper case J instead of j for example. This seems unrelated to the controller
idling with state issue probably, maybe it's some debouncing related issue.
So far playing with the debouncing configuration has not helped with this
issue though. Anyways, please test if you're seeing stuck keys on droid4.

Regards,

Tony


Tony Lindgren (3):
  Input: omap4-keypad - configure interrupt as level
  Input: omap4-keypad - disable unused long interrupts
  Input: omap4-keypad - check state again for lost key-up interrupts

 drivers/input/keyboard/omap4-keypad.c | 64 ++++++++++++++++++++++-----
 1 file changed, 54 insertions(+), 10 deletions(-)

Comments

Tony Lindgren Feb. 28, 2020, 6:04 p.m. UTC | #1
* Tony Lindgren <tony@atomide.com> [200228 17:13]:
> I can still reproduce one issue where a fast shift-shift-j can produce an
> upper case J instead of j for example. This seems unrelated to the controller
> idling with state issue probably, maybe it's some debouncing related issue.
> So far playing with the debouncing configuration has not helped with this
> issue though. Anyways, please test if you're seeing stuck keys on droid4.

Oh so turns out this can be dealt with by first scanning for any lost
key-up events. I just sent out patch 4/3 to this series to fix that.

Regards,

Tony