mbox series

[0/2] iio: dac: ad5770r: dt bindings fixes

Message ID 20200320160531.23732-1-alexandru.tachici@analog.com (mailing list archive)
Headers show
Series iio: dac: ad5770r: dt bindings fixes | expand

Message

Alexandru Tachici March 20, 2020, 4:05 p.m. UTC 
This aims to replace use of num property from dt nodes with
reg property both in dt bindings and driver and fix
dt bindings errors.

1. read from fwnode reg property instead of num property

2. replace num property with reg property and fix dt
bindings errors

Alexandru Tachici (2):
  iio: dac: ad5770r: read channel nr from reg
  dt-bindings: iio: dac: AD5570R fix bindings errors

 .../bindings/iio/dac/adi,ad5770r.yaml         | 77 ++++++++++---------
 drivers/iio/dac/ad5770r.c                     |  2 +-
 2 files changed, 41 insertions(+), 38 deletions(-)

Comments

Alexandru Ardelean March 21, 2020, 7:17 a.m. UTC | #1 
On Fri, 2020-03-20 at 18:05 +0200, Alexandru Tachici wrote:
> [External]
> 
> This aims to replace use of num property from dt nodes with
> reg property both in dt bindings and driver and fix
> dt bindings errors.
> 

Maybe do a RESEND for this and add
--to=devicetree@vger.kernel.org --cc=robh+dt@kernel.org
to the git send-mail command

Specifically for this, the DT list should be addressed.
But [naturally] the IIO list should also be included.


> 1. read from fwnode reg property instead of num property
> 
> 2. replace num property with reg property and fix dt
> bindings errors
> 
> Alexandru Tachici (2):
>   iio: dac: ad5770r: read channel nr from reg
>   dt-bindings: iio: dac: AD5570R fix bindings errors
> 
>  .../bindings/iio/dac/adi,ad5770r.yaml         | 77 ++++++++++---------
>  drivers/iio/dac/ad5770r.c                     |  2 +-
>  2 files changed, 41 insertions(+), 38 deletions(-)
>
Jonathan Cameron March 21, 2020, 5:27 p.m. UTC | #2 
On Sat, 21 Mar 2020 07:17:30 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Fri, 2020-03-20 at 18:05 +0200, Alexandru Tachici wrote:
> > [External]
> > 
> > This aims to replace use of num property from dt nodes with
> > reg property both in dt bindings and driver and fix
> > dt bindings errors.
> >   
> 
> Maybe do a RESEND for this and add
> --to=devicetree@vger.kernel.org --cc=robh+dt@kernel.org
> to the git send-mail command
> 
> Specifically for this, the DT list should be addressed.
> But [naturally] the IIO list should also be included.

Definitely do this resend.  I'll want an review from Rob.

Thanks,

Jonathan

> 
> 
> > 1. read from fwnode reg property instead of num property
> > 
> > 2. replace num property with reg property and fix dt
> > bindings errors
> > 
> > Alexandru Tachici (2):
> >   iio: dac: ad5770r: read channel nr from reg
> >   dt-bindings: iio: dac: AD5570R fix bindings errors
> > 
> >  .../bindings/iio/dac/adi,ad5770r.yaml         | 77 ++++++++++---------
> >  drivers/iio/dac/ad5770r.c                     |  2 +-
> >  2 files changed, 41 insertions(+), 38 deletions(-)
> >