[00/18] Prefer drm_WARN* over WARN*
mbox series

Message ID 20200406112800.23762-1-pankaj.laxminarayan.bharadiya@intel.com
Headers show
Series
  • Prefer drm_WARN* over WARN*
Related show

Message

Laxminarayan Bharadiya, Pankaj April 6, 2020, 11:27 a.m. UTC
Now we have struct drm_device specific drm_WARN* macros which include
device information in the backtrace, so we know what device the
warnings originate from.

This series converts WARN* with drm_WARN* where struct drm_device
pointer can be extracted.

This series is the continuation of:
https://patchwork.freedesktop.org/series/72035/

Pankaj Bharadiya (18):
  drm/i915/display/icl_dsi: Prefer drm_WARN_ON over WARN_ON
  drm/i915/display/atomic_plane: Prefer drm_WARN_ON over WARN_ON
  drm/i915/display/ddi: Prefer drm_WARN* over WARN*
  drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON
  drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON
  drm/i915/display/dp: Prefer drm_WARN* over WARN*
  drm/i915/display/dpll_mgr: Prefer drm_WARN_ON over WARN_ON
  drm/i915/display/frontbuffer: Prefer drm_WARN_ON over WARN_ON
  drm/i915/display/global_state: Prefer drm_WARN* over WARN*
  drm/i915/display/overlay: Prefer drm_WARN_ON over WARN_ON
  drm/i915/display/sdvo: Prefer drm_WARN* over WARN*
  drm/i915/display/tc: Prefer drm_WARN_ON over WARN_ON
  drm/i915/display/vlv_dsi: Prefer drm_WARN_ON over WARN_ON
  drm/i915/gem: Prefer drm_WARN* over WARN*
  drm/i915/i915_drv: Prefer drm_WARN_ON over WARN_ON
  drm/i915/pmu: Prefer drm_WARN_ON over WARN_ON
  drm/i915/pm: Prefer drm_WARN_ON over WARN_ON
  drm/i915/runtime_pm: Prefer drm_WARN* over WARN*

 drivers/gpu/drm/i915/display/icl_dsi.c        |  2 +-
 .../gpu/drm/i915/display/intel_atomic_plane.c |  4 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      | 14 +++--
 drivers/gpu/drm/i915/display/intel_display.c  | 24 ++++----
 .../drm/i915/display/intel_display_power.c    | 35 ++++++++----
 drivers/gpu/drm/i915/display/intel_dp.c       | 26 ++++++---
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  8 +--
 .../gpu/drm/i915/display/intel_frontbuffer.c  |  6 +-
 .../gpu/drm/i915/display/intel_global_state.c |  4 +-
 drivers/gpu/drm/i915/display/intel_overlay.c  |  6 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c     | 16 +++---
 drivers/gpu/drm/i915/display/intel_tc.c       | 12 ++--
 drivers/gpu/drm/i915/display/vlv_dsi.c        |  2 +-
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    |  2 +-
 drivers/gpu/drm/i915/gem/i915_gem_phys.c      |  3 +-
 drivers/gpu/drm/i915/gem/i915_gem_userptr.c   |  2 +-
 drivers/gpu/drm/i915/i915_drv.h               |  3 +-
 drivers/gpu/drm/i915/i915_pmu.c               | 11 +++-
 drivers/gpu/drm/i915/intel_pm.c               | 57 +++++++++++--------
 drivers/gpu/drm/i915/intel_runtime_pm.c       | 39 +++++++++----
 20 files changed, 170 insertions(+), 106 deletions(-)

Comments

Jani Nikula April 21, 2020, 8:35 a.m. UTC | #1
On Mon, 06 Apr 2020, Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> wrote:
> Now we have struct drm_device specific drm_WARN* macros which include
> device information in the backtrace, so we know what device the
> warnings originate from.
>
> This series converts WARN* with drm_WARN* where struct drm_device
> pointer can be extracted.

I think I pushed all the patches that I didn't comment on separately,
and that still applied.

BR,
Jani.
Laxminarayan Bharadiya, Pankaj April 21, 2020, 10:01 a.m. UTC | #2
On Tue, Apr 21, 2020 at 11:35:08AM +0300, Jani Nikula wrote:
> On Mon, 06 Apr 2020, Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> wrote:
> > Now we have struct drm_device specific drm_WARN* macros which include
> > device information in the backtrace, so we know what device the
> > warnings originate from.
> >
> > This series converts WARN* with drm_WARN* where struct drm_device
> > pointer can be extracted.
> 
> I think I pushed all the patches that I didn't comment on separately,
> and that still applied.

Thank you Jani. Will rework on pending patches and resubmit.

Thanks,
Pankaj

> 
> BR,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center