[RFC,v2,0/6] cpuidle: Make cpuidle governor switchable to be the default behaviour

Message

Hanjun Guo April 30, 2020, 8:39 a.m. UTC

For now cpuidle governor can be switched via sysfs only when the
boot option "cpuidle_sysfs_switch" is passed, but it's important
to switch the governor to adapt to different workloads, especially
after TEO and haltpoll governor were introduced.

Make cpuidle governor switchable to be the default behaviour by removing
the sysfs_switch and switch attributes, also update the document as well.

v1->v2:
 - Add two bugfix patch which can be triggered if the governor name is 15
   characters, it is not a 'real' bug for now as we don't have such usecases
   so we can merge them together via this patchset.
 - Remove the sysfs_switch, not introduce a CONFIG option to make cpuidle
   governor switchable in default, suggested by Daniel.
 - Update the document after cpuidle_sysfs_switch is removed, suggested by
   Doug Smythies.

Hanjun Guo (6):
  cpuidle: sysfs: Fix the overlap for showing available governors
  cpuidle: sysfs: Accept governor name with 15 characters
  cpuidle: Make cpuidle governor switchable to be the default behaviour
  cpuidle: sysfs: Remove sysfs_switch and switch attributes
  Documentation: cpuidle: update the document
  Documentation: ABI: make current_governer_ro as a candidate for
    removal

 Documentation/ABI/obsolete/sysfs-cpuidle           |  9 ++++
 Documentation/ABI/testing/sysfs-devices-system-cpu | 24 ++++------
 Documentation/admin-guide/pm/cpuidle.rst           | 20 ++++----
 Documentation/driver-api/pm/cpuidle.rst            |  5 +-
 drivers/cpuidle/sysfs.c                            | 56 ++++++----------------
 5 files changed, 44 insertions(+), 70 deletions(-)
 create mode 100644 Documentation/ABI/obsolete/sysfs-cpuidle

Comments

Doug Smythies May 12, 2020, 9:17 p.m. UTC | #1

On 2020.04.30 01:40 Hanjun Guo wrote:

> For now cpuidle governor can be switched via sysfs only when the
> boot option "cpuidle_sysfs_switch" is passed, but it's important
>to switch the governor to adapt to different workloads, especially
> after TEO and haltpoll governor were introduced.
>
> Make cpuidle governor switchable to be the default behaviour by removing
> the sysfs_switch and switch attributes, also update the document as well.
>
> v1->v2:
> - Add two bugfix patch which can be triggered if the governor name is 15
>   characters, it is not a 'real' bug for now as we don't have such usecases
>   so we can merge them together via this patchset.
> - Remove the sysfs_switch, not introduce a CONFIG option to make cpuidle
>   governor switchable in default, suggested by Daniel.
> - Update the document after cpuidle_sysfs_switch is removed, suggested by
>   Doug Smythies.
>
> Hanjun Guo (6):
>  cpuidle: sysfs: Fix the overlap for showing available governors
>  cpuidle: sysfs: Accept governor name with 15 characters
>  cpuidle: Make cpuidle governor switchable to be the default behaviour
>  cpuidle: sysfs: Remove sysfs_switch and switch attributes
>  Documentation: cpuidle: update the document
>  Documentation: ABI: make current_governer_ro as a candidate for
>    removal
>
> Documentation/ABI/obsolete/sysfs-cpuidle           |  9 ++++
> Documentation/ABI/testing/sysfs-devices-system-cpu | 24 ++++------
> Documentation/admin-guide/pm/cpuidle.rst           | 20 ++++----
> Documentation/driver-api/pm/cpuidle.rst            |  5 +-
> drivers/cpuidle/sysfs.c                            | 56 ++++++----------------
> 5 files changed, 44 insertions(+), 70 deletions(-)
> create mode 100644 Documentation/ABI/obsolete/sysfs-cpuidle

Thanks,

Reviewed and tested by Doug Smythies <[e-mail]>