[0/3] selftests/ftrace: Fix ftracetest testcases for dash, etc.
mbox series

Message ID 158834025077.28357.15141584656220094821.stgit@devnote2
Headers show
Series
  • selftests/ftrace: Fix ftracetest testcases for dash, etc.
Related show

Message

Masami Hiramatsu May 1, 2020, 1:37 p.m. UTC
Hi,

Here are some patches to update ftracetest to fix some issues.
 - [1/3] Fix coloring of XFAIL
 - [2/3] Fix a testcase not to expect just one event entry
 - [3/3] Do not use built-in echo because the behavior is different
         on dash and bash. (Thanks Liu for reporting!)

Thank you,

---

Masami Hiramatsu (3):
      selftests/ftrace: Make XFAIL green color
      selftests/ftrace: Pick only the first kprobe event to test
      selftests/ftrace: Use /bin/echo instead of built-in echo


 tools/testing/selftests/ftrace/ftracetest          |    2 +-
 tools/testing/selftests/ftrace/test.d/functions    |    3 +++
 .../ftrace/test.d/kprobe/kprobe_args_type.tc       |    2 +-
 .../test.d/trigger/trigger-trace-marker-hist.tc    |    2 +-
 .../trigger-trace-marker-synthetic-kernel.tc       |    4 ++++
 .../trigger/trigger-trace-marker-synthetic.tc      |    4 ++--
 6 files changed, 12 insertions(+), 5 deletions(-)

--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>

Comments

Steven Rostedt May 1, 2020, 2:21 p.m. UTC | #1
[ FYI, Shuah responds better from her linuxfoundation.org email ]

Shuah,

Feel free to take the first two patches of this series (I acked one, and
reviewed the other).

The last patch I had some issues with, and is still under discussion.

Thanks!

-- Steve



On Fri,  1 May 2020 22:37:31 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Hi,
> 
> Here are some patches to update ftracetest to fix some issues.
>  - [1/3] Fix coloring of XFAIL
>  - [2/3] Fix a testcase not to expect just one event entry
>  - [3/3] Do not use built-in echo because the behavior is different
>          on dash and bash. (Thanks Liu for reporting!)
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (3):
>       selftests/ftrace: Make XFAIL green color
>       selftests/ftrace: Pick only the first kprobe event to test
>       selftests/ftrace: Use /bin/echo instead of built-in echo
> 
> 
>  tools/testing/selftests/ftrace/ftracetest          |    2 +-
>  tools/testing/selftests/ftrace/test.d/functions    |    3 +++
>  .../ftrace/test.d/kprobe/kprobe_args_type.tc       |    2 +-
>  .../test.d/trigger/trigger-trace-marker-hist.tc    |    2 +-
>  .../trigger-trace-marker-synthetic-kernel.tc       |    4 ++++
>  .../trigger/trigger-trace-marker-synthetic.tc      |    4 ++--
>  6 files changed, 12 insertions(+), 5 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
Shuah Khan May 1, 2020, 2:28 p.m. UTC | #2
On 5/1/20 8:21 AM, Steven Rostedt wrote:
> 
> [ FYI, Shuah responds better from her linuxfoundation.org email ]
> 
> Shuah,
> 
> Feel free to take the first two patches of this series (I acked one, and
> reviewed the other).
> 
> The last patch I had some issues with, and is still under discussion.
> 
> Thanks!
> 
> -- Steve
> 

Will apply the first two.

thanks,
-- Shuah