| Message ID | 1588854799-13710-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add endpoint driver for R-Car PCIe controller | expand |
On Thu, May 07, 2020 at 01:33:11PM +0100, Lad Prabhakar wrote: > Hi All, > > This patch series adds support for endpoint driver for R-Car PCIe controller on > R-Car/RZ-G2x SoC's, this also extends the epf framework to handle multiple windows > supported by the controller for mapping PCI address locally. > > Note: > The rockchip/dwc endpoint drivers are build tested only and was tested on cadence > by Kishon (https://lkml.org/lkml/2020/5/6/1535) > > Changes for v10: > * Rebased patches on top of pci/rcar branch on tree > https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git > * Made pci_epc_get_matching_window() as static > * Included Ack's from Kishon for patches 4/8 and 5/8 > * Included Reviewed-by tag from Shimoda-san for patches 4/8 and 5/8 > > Changes for v9: > * Rebased patches on top of v5.7.rc1 > * Replaced mdelay(1) with usleep_range(1000, 1001) in rcar_pcie_ep_assert_intx() > * Added a check for max_functions read from DT to restrict with > RCAR_EPC_MAX_FUNCTIONS > * Replaced MSICAP0_MMENUM with MSICAP0_MMESE > * Retry ioremap for other windows on failure in pci_epc_mem_alloc_addr() > * Fixed looping for number windows in pci_epc_mem_exit() > * Set maximum to 1 for max-functions in DT binding (I have restored the acks > from Rob and Shimoda-san) > * Sorted the entry in MAINTAINERS > > Changes for v8: > * Dropped adding R8A774C0 (0x002d) pci-id in pci_ids.h > * Fixed typo in commit message for patch 2/8 > * Reworded commit message for patch 5/8 as suggested by Bjorn > * Split up patch to add pci_epc_mem_init() interface to add page_size argument > as suggested by Bjorn. > > Changes for v7: > * Fixed review comments pointed by Shimoda-san > 1] Made DT bindings dual licensed, added Shimoda-san as maintainer and fixed > the example as its built with #{address,size}-cells = <1>. I have still > restored the Ack from Rob and Shimoda-san with these changes. > 2] Split up the patches so that they can be picked up by respective subsystem > patches 1/4-9/11 are now part of this series. > 3] Dropped altering a comment in pci-epc.h > 4] Used a local variable align_size in pci_epc_mem_alloc_addr() so that size > variable doesn't get overwritten in the loop. > 5] Replaced i-=1 with i-- > 6] Replaced rcar with R-Car in patch subject and description. > 7] Set MACCTLR in init() callback > > Changes for v6: > 1] Rebased patches on endpoint branch of https://git.kernel.org/pub/ > scm/linux/kernel/git/lpieralisi/pci.git/ > 2] Fixed review comments from Shimoda-san > a] Made sure defconfig changes were in separate patch > b] Created rcar_pcie_host/rcar_pcie_ep structures > c] Added pci-id for R8A774C0 > d] Added entry in MAINTAINERS for dt-binding > e] Dropped unnecessary braces > 3] Added support for msi. > > Changes for v5: > 1] Rebased patches on next branch of https://git.kernel.org/pub/scm/ > linux/kernel/git/helgaas/pci.git > 2] Fixed review comments reported by Kishon while fetching the matching > window in function pci_epc_get_matching_window() > 3] Fixed review comments reported by Bjorn > a] Split patch up first patch so that its easier to review and incremental > b] Fixed typos > 4] Included Reviewed tag from Rob for the dt-binding patch > 5] Fixed issue reported by Nathan for assigning variable to itself > > Changes for v4: > 1] Fixed dtb_check error reported by Rob > 2] Fixed review comments reported by Kishon > a] Dropped pci_epc_find_best_fit_window() > b] Fixed initializing mem ptr in __pci_epc_mem_init() > c] Dropped map_size from pci_epc_mem_window structure > > Changes for v3: > 1] Fixed review comments from Bjorn and Kishon. > 3] Converted to DT schema > > Changes for v2: > 1] Fixed review comments from Biju for dt-bindings to include an example > for a tested platform. > 2] Fixed review comments from Kishon to extend the features of outbound > regions in epf framework. > 3] Added support to parse outbound-ranges in OF. > > Lad Prabhakar (8): > PCI: rcar: Rename pcie-rcar.c to pcie-rcar-host.c > PCI: rcar: Move shareable code to a common file > PCI: rcar: Fix calculating mask for PCIEPAMR register > PCI: endpoint: Pass page size as argument to pci_epc_mem_init() > PCI: endpoint: Add support to handle multiple base for mapping > outbound memory > dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint > controller > PCI: rcar: Add endpoint mode support > MAINTAINERS: Add file patterns for rcar PCI device tree bindings > > .../devicetree/bindings/pci/rcar-pci-ep.yaml | 77 + > MAINTAINERS | 1 + > drivers/pci/controller/Kconfig | 18 + > drivers/pci/controller/Makefile | 3 +- > .../pci/controller/cadence/pcie-cadence-ep.c | 2 +- > .../pci/controller/dwc/pcie-designware-ep.c | 16 +- > drivers/pci/controller/pcie-rcar-ep.c | 563 ++++++++ > drivers/pci/controller/pcie-rcar-host.c | 1130 +++++++++++++++ > drivers/pci/controller/pcie-rcar.c | 1268 +---------------- > drivers/pci/controller/pcie-rcar.h | 140 ++ > drivers/pci/controller/pcie-rockchip-ep.c | 2 +- > drivers/pci/endpoint/pci-epc-mem.c | 204 ++- > include/linux/pci-epc.h | 38 +- > 13 files changed, 2150 insertions(+), 1312 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > create mode 100644 drivers/pci/controller/pcie-rcar-ep.c > create mode 100644 drivers/pci/controller/pcie-rcar-host.c > create mode 100644 drivers/pci/controller/pcie-rcar.h Applied to pci/rcar, thanks ! Lorenzo
Hi All, This patch series adds support for endpoint driver for R-Car PCIe controller on R-Car/RZ-G2x SoC's, this also extends the epf framework to handle multiple windows supported by the controller for mapping PCI address locally. Note: The rockchip/dwc endpoint drivers are build tested only and was tested on cadence by Kishon (https://lkml.org/lkml/2020/5/6/1535) Changes for v10: * Rebased patches on top of pci/rcar branch on tree https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git * Made pci_epc_get_matching_window() as static * Included Ack's from Kishon for patches 4/8 and 5/8 * Included Reviewed-by tag from Shimoda-san for patches 4/8 and 5/8 Changes for v9: * Rebased patches on top of v5.7.rc1 * Replaced mdelay(1) with usleep_range(1000, 1001) in rcar_pcie_ep_assert_intx() * Added a check for max_functions read from DT to restrict with RCAR_EPC_MAX_FUNCTIONS * Replaced MSICAP0_MMENUM with MSICAP0_MMESE * Retry ioremap for other windows on failure in pci_epc_mem_alloc_addr() * Fixed looping for number windows in pci_epc_mem_exit() * Set maximum to 1 for max-functions in DT binding (I have restored the acks from Rob and Shimoda-san) * Sorted the entry in MAINTAINERS Changes for v8: * Dropped adding R8A774C0 (0x002d) pci-id in pci_ids.h * Fixed typo in commit message for patch 2/8 * Reworded commit message for patch 5/8 as suggested by Bjorn * Split up patch to add pci_epc_mem_init() interface to add page_size argument as suggested by Bjorn. Changes for v7: * Fixed review comments pointed by Shimoda-san 1] Made DT bindings dual licensed, added Shimoda-san as maintainer and fixed the example as its built with #{address,size}-cells = <1>. I have still restored the Ack from Rob and Shimoda-san with these changes. 2] Split up the patches so that they can be picked up by respective subsystem patches 1/4-9/11 are now part of this series. 3] Dropped altering a comment in pci-epc.h 4] Used a local variable align_size in pci_epc_mem_alloc_addr() so that size variable doesn't get overwritten in the loop. 5] Replaced i-=1 with i-- 6] Replaced rcar with R-Car in patch subject and description. 7] Set MACCTLR in init() callback Changes for v6: 1] Rebased patches on endpoint branch of https://git.kernel.org/pub/ scm/linux/kernel/git/lpieralisi/pci.git/ 2] Fixed review comments from Shimoda-san a] Made sure defconfig changes were in separate patch b] Created rcar_pcie_host/rcar_pcie_ep structures c] Added pci-id for R8A774C0 d] Added entry in MAINTAINERS for dt-binding e] Dropped unnecessary braces 3] Added support for msi. Changes for v5: 1] Rebased patches on next branch of https://git.kernel.org/pub/scm/ linux/kernel/git/helgaas/pci.git 2] Fixed review comments reported by Kishon while fetching the matching window in function pci_epc_get_matching_window() 3] Fixed review comments reported by Bjorn a] Split patch up first patch so that its easier to review and incremental b] Fixed typos 4] Included Reviewed tag from Rob for the dt-binding patch 5] Fixed issue reported by Nathan for assigning variable to itself Changes for v4: 1] Fixed dtb_check error reported by Rob 2] Fixed review comments reported by Kishon a] Dropped pci_epc_find_best_fit_window() b] Fixed initializing mem ptr in __pci_epc_mem_init() c] Dropped map_size from pci_epc_mem_window structure Changes for v3: 1] Fixed review comments from Bjorn and Kishon. 3] Converted to DT schema Changes for v2: 1] Fixed review comments from Biju for dt-bindings to include an example for a tested platform. 2] Fixed review comments from Kishon to extend the features of outbound regions in epf framework. 3] Added support to parse outbound-ranges in OF. Lad Prabhakar (8): PCI: rcar: Rename pcie-rcar.c to pcie-rcar-host.c PCI: rcar: Move shareable code to a common file PCI: rcar: Fix calculating mask for PCIEPAMR register PCI: endpoint: Pass page size as argument to pci_epc_mem_init() PCI: endpoint: Add support to handle multiple base for mapping outbound memory dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller PCI: rcar: Add endpoint mode support MAINTAINERS: Add file patterns for rcar PCI device tree bindings .../devicetree/bindings/pci/rcar-pci-ep.yaml | 77 + MAINTAINERS | 1 + drivers/pci/controller/Kconfig | 18 + drivers/pci/controller/Makefile | 3 +- .../pci/controller/cadence/pcie-cadence-ep.c | 2 +- .../pci/controller/dwc/pcie-designware-ep.c | 16 +- drivers/pci/controller/pcie-rcar-ep.c | 563 ++++++++ drivers/pci/controller/pcie-rcar-host.c | 1130 +++++++++++++++ drivers/pci/controller/pcie-rcar.c | 1268 +---------------- drivers/pci/controller/pcie-rcar.h | 140 ++ drivers/pci/controller/pcie-rockchip-ep.c | 2 +- drivers/pci/endpoint/pci-epc-mem.c | 204 ++- include/linux/pci-epc.h | 38 +- 13 files changed, 2150 insertions(+), 1312 deletions(-) create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml create mode 100644 drivers/pci/controller/pcie-rcar-ep.c create mode 100644 drivers/pci/controller/pcie-rcar-host.c create mode 100644 drivers/pci/controller/pcie-rcar.h