mbox series

[0/2] iotests: Run pylint and mypy in a testcase

Message ID 20200511163529.349329-1-kwolf@redhat.com (mailing list archive)
Headers show
Series iotests: Run pylint and mypy in a testcase | expand

Message

Kevin Wolf May 11, 2020, 4:35 p.m. UTC 
Kevin Wolf (2):
  iotests: Fix incomplete type declarations
  iotests: Run pylint and mypy in a testcase

 tests/qemu-iotests/iotests.py |  8 +++----
 tests/qemu-iotests/297        | 44 +++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/297.out    |  3 +++
 tests/qemu-iotests/group      |  1 +
 4 files changed, 52 insertions(+), 4 deletions(-)
 create mode 100755 tests/qemu-iotests/297
 create mode 100644 tests/qemu-iotests/297.out

Comments

John Snow May 13, 2020, 8:56 p.m. UTC | #1 
On 5/11/20 12:35 PM, Kevin Wolf wrote:
> Kevin Wolf (2):
>   iotests: Fix incomplete type declarations
>   iotests: Run pylint and mypy in a testcase
> 
>  tests/qemu-iotests/iotests.py |  8 +++----
>  tests/qemu-iotests/297        | 44 +++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/297.out    |  3 +++
>  tests/qemu-iotests/group      |  1 +
>  4 files changed, 52 insertions(+), 4 deletions(-)
>  create mode 100755 tests/qemu-iotests/297
>  create mode 100644 tests/qemu-iotests/297.out
> 

Cool!

Maybe the approach of putting this in 'make check' somewhere can
alleviate that expensive test being performed in iotests directly (as
Max notes), but, uhm. whatever.

For now, this will help prevent the backslide.

Reviewed-by: John Snow <jsnow@redhat.com>