[v3,0/7] ASoC: add soc-link

Message

Kuninori Morimoto May 22, 2020, 12:13 a.m. UTC

Hi Mark

Current ALSA SoC is handling dai_link related operation,
but it is implmemented directly without using function/macro,
and at random place.

This v3 patch-set creates new snd_soc_link_xxx() functions
which handles dai_link related operation,
and implmement these at new soc-link.c.

v2 -> v3

	- add missing #include <sound/soc-link.h> in soc-link.c

v1 -> v2
	- #include <sound/soc-link.h> is added on each c source file
	  instead of soc.h
	- not have extra error message after snd_soc_link_xxx(),
	  because it already indicate it via snc_link_ret()
	- snd_soc_link_compr_xxx() doesn't have rtd parameter,
	  because it can be created from cstream

Link: https://lore.kernel.org/r/[e-mail]
Link: https://lore.kernel.org/r/[e-mail]

Kuninori Morimoto (7):
  ASoC: add soc-link.c
  ASoC: soc-link: move soc_rtd_xxx()
  ASoC: soc-link: remove unneeded parameter from snd_soc_link_xxx()
  ASoC: soc-link: add snd_soc_link_be_hw_params_fixup()
  ASoC: soc-link: add snd_soc_link_compr_startup()
  ASoC: soc-link: add snd_soc_link_compr_shutdown()
  ASoC: soc-link: add snd_soc_link_compr_set_params()

 include/sound/soc-link.h |  27 +++++++
 sound/soc/Makefile       |   2 +-
 sound/soc/soc-compress.c |  46 ++++--------
 sound/soc/soc-core.c     |  18 ++---
 sound/soc/soc-dai.c      |   9 ++-
 sound/soc/soc-link.c     | 150 +++++++++++++++++++++++++++++++++++++++
 sound/soc/soc-pcm.c      |  86 ++++------------------
 7 files changed, 219 insertions(+), 119 deletions(-)
 create mode 100644 include/sound/soc-link.h
 create mode 100644 sound/soc/soc-link.c

Comments

Kuninori Morimoto May 22, 2020, 12:21 a.m. UTC | #1

Hi Mark

> Current ALSA SoC is handling dai_link related operation,
> but it is implmemented directly without using function/macro,
> and at random place.
> 
> This v3 patch-set creates new snd_soc_link_xxx() functions
> which handles dai_link related operation,
> and implmement these at new soc-link.c.
> 
> v2 -> v3
> 
> 	- add missing #include <sound/soc-link.h> in soc-link.c
> 
> v1 -> v2
> 	- #include <sound/soc-link.h> is added on each c source file
> 	  instead of soc.h
> 	- not have extra error message after snd_soc_link_xxx(),
> 	  because it already indicate it via snc_link_ret()
> 	- snd_soc_link_compr_xxx() doesn't have rtd parameter,
> 	  because it can be created from cstream

I forgot to add Ranjani's Acked-by on this patch-set.

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Pierre-Louis Bossart May 22, 2020, 2:36 p.m. UTC | #2

On 5/21/20 7:13 PM, Kuninori Morimoto wrote:
> 
> Hi Mark
> 
> Current ALSA SoC is handling dai_link related operation,
> but it is implmemented directly without using function/macro,
> and at random place.
> 
> This v3 patch-set creates new snd_soc_link_xxx() functions
> which handles dai_link related operation,
> and implmement these at new soc-link.c.

For the series

Reviewed-by: Pierre-Louis Bossart <[e-mail]>

> 
> v2 -> v3
> 
> 	- add missing #include <sound/soc-link.h> in soc-link.c
> 
> v1 -> v2
> 	- #include <sound/soc-link.h> is added on each c source file
> 	  instead of soc.h
> 	- not have extra error message after snd_soc_link_xxx(),
> 	  because it already indicate it via snc_link_ret()
> 	- snd_soc_link_compr_xxx() doesn't have rtd parameter,
> 	  because it can be created from cstream
> 
> Link: https://lore.kernel.org/r/[e-mail]
> Link: https://lore.kernel.org/r/[e-mail]
> 
> Kuninori Morimoto (7):
>    ASoC: add soc-link.c
>    ASoC: soc-link: move soc_rtd_xxx()
>    ASoC: soc-link: remove unneeded parameter from snd_soc_link_xxx()
>    ASoC: soc-link: add snd_soc_link_be_hw_params_fixup()
>    ASoC: soc-link: add snd_soc_link_compr_startup()
>    ASoC: soc-link: add snd_soc_link_compr_shutdown()
>    ASoC: soc-link: add snd_soc_link_compr_set_params()
> 
>   include/sound/soc-link.h |  27 +++++++
>   sound/soc/Makefile       |   2 +-
>   sound/soc/soc-compress.c |  46 ++++--------
>   sound/soc/soc-core.c     |  18 ++---
>   sound/soc/soc-dai.c      |   9 ++-
>   sound/soc/soc-link.c     | 150 +++++++++++++++++++++++++++++++++++++++
>   sound/soc/soc-pcm.c      |  86 ++++------------------
>   7 files changed, 219 insertions(+), 119 deletions(-)
>   create mode 100644 include/sound/soc-link.h
>   create mode 100644 sound/soc/soc-link.c
>

Mark Brown May 25, 2020, 2:57 p.m. UTC | #3

On 22 May 2020 09:13:00 +0900, Kuninori Morimoto wrote:
> Current ALSA SoC is handling dai_link related operation,
> but it is implmemented directly without using function/macro,
> and at random place.
> 
> This v3 patch-set creates new snd_soc_link_xxx() functions
> which handles dai_link related operation,
> and implmement these at new soc-link.c.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/7] ASoC: add soc-link.c
      commit: 02e756363fc936917bed7320199c80729b2a825c
[2/7] ASoC: soc-link: move soc_rtd_xxx()
      commit: a5e6c1090001b8a14e797364dde7c84236465fc7
[3/7] ASoC: soc-link: remove unneeded parameter from snd_soc_link_xxx()
      commit: 7cf3c5b4a04f4b27d964089630290beccc115f9f
[4/7] ASoC: soc-link: add snd_soc_link_be_hw_params_fixup()
      commit: 0cbbf8a0399518e5b865f9a1320d704c1d621703
[5/7] ASoC: soc-link: add snd_soc_link_compr_startup()
      commit: 9ab711cb84d4b77fb3929fabc5e3756d5010af14
[6/7] ASoC: soc-link: add snd_soc_link_compr_shutdown()
      commit: 0e532c99b468d6e4fc4e1d29b45ffe2749db6d07
[7/7] ASoC: soc-link: add snd_soc_link_compr_set_params()
      commit: eab810f37ff5fd76172ac903e5e732d6b72fc834

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark