[v2,00/19] ASoC: add soc-card

Message

Kuninori Morimoto May 28, 2020, 1:47 a.m. UTC

Hi Mark

Current ALSA SoC is handling snd_soc_card related operation,
but it is implmemented directly without using function/macro,
and at random place.

This v2 patch-set creates new snd_soc_card_xxx() functions
which handles snd_soc_card related operation,
and implmement these at new soc-card.c.

v1 -> v2

	- careed scripts/checkpatch.pl except for MAINTAINERS file update
	- added detail log at git-log, and/or comment at file.
	- cares "if (card)" under snd_soc_card_xxx()

Link: https://lore.kernel.org/r/[e-mail]

Kuninori Morimoto (19):
   1 ASoC: soc.h: convert bool to bit field for snd_soc_card
   2 ASoC: add soc-card.c
   3 ASoC: soc-card: move snd_soc_card_get_kcontrol() to soc-card
   4 ASoC: soc-card: move snd_soc_card_jack_new() to soc-card
   5 ASoC: soc-card: move snd_soc_card_set/get_drvdata() to soc-card
   6 ASoC: soc-card: move snd_soc_card_get_codec_dai() to soc-card
   7 ASoC: soc-card: move snd_soc_card_subclass to soc-card
   8 ASoC: soc-card: add snd_soc_card_suspend_pre()
   9 ASoC: soc-card: add snd_soc_card_suspend_post()
  10 ASoC: soc-card: add snd_soc_card_resume_pre()
  11 ASoC: soc-card: add snd_soc_card_resume_post()
  12 ASoC: soc-card: add probed bit field to snd_soc_card
  13 ASoC: soc-card: add snd_soc_card_probe()
  14 ASoC: soc-card: add snd_soc_card_late_probe()
  15 ASoC: soc-card: add snd_soc_card_remove()
  16 ASoC: soc-card: add snd_soc_card_set_bias_level()
  17 ASoC: soc-card: add snd_soc_card_set_bias_level_post()
  18 ASoC: soc-card: add snd_soc_card_add_dai_link()
  19 ASoC: soc-card: add snd_soc_card_remove_dai_link()

 include/sound/soc-card.h |  69 ++++++++++++
 include/sound/soc.h      |  53 ++-------
 sound/soc/Makefile       |   2 +-
 sound/soc/soc-card.c     | 225 +++++++++++++++++++++++++++++++++++++++
 sound/soc/soc-core.c     |  71 ++++--------
 sound/soc/soc-dapm.c     |   6 +-
 sound/soc/soc-jack.c     |  38 -------
 7 files changed, 325 insertions(+), 139 deletions(-)
 create mode 100644 include/sound/soc-card.h
 create mode 100644 sound/soc/soc-card.c

Comments

Ranjani Sridharan May 29, 2020, 11:17 p.m. UTC | #1

On Thu, 2020-05-28 at 10:47 +0900, Kuninori Morimoto wrote:
> Hi Mark
> 
> Current ALSA SoC is handling snd_soc_card related operation,
> but it is implmemented directly without using function/macro,
> and at random place.
> 
> This v2 patch-set creates new snd_soc_card_xxx() functions
> which handles snd_soc_card related operation,
> and implmement these at new soc-card.c.
> 
> v1 -> v2
> 
> 	- careed scripts/checkpatch.pl except for MAINTAINERS file
> update
> 	- added detail log at git-log, and/or comment at file.
> 	- cares "if (card)" under snd_soc_card_xxx()
> 
> Link: 
> https://lore.kernel.org/r/[e-mail]
> 
> Kuninori Morimoto (19):
>    1 ASoC: soc.h: convert bool to bit field for snd_soc_card
>    2 ASoC: add soc-card.c
>    3 ASoC: soc-card: move snd_soc_card_get_kcontrol() to soc-card
>    4 ASoC: soc-card: move snd_soc_card_jack_new() to soc-card
>    5 ASoC: soc-card: move snd_soc_card_set/get_drvdata() to soc-card
>    6 ASoC: soc-card: move snd_soc_card_get_codec_dai() to soc-card
>    7 ASoC: soc-card: move snd_soc_card_subclass to soc-card
>    8 ASoC: soc-card: add snd_soc_card_suspend_pre()
>    9 ASoC: soc-card: add snd_soc_card_suspend_post()
>   10 ASoC: soc-card: add snd_soc_card_resume_pre()
>   11 ASoC: soc-card: add snd_soc_card_resume_post()
>   12 ASoC: soc-card: add probed bit field to snd_soc_card
>   13 ASoC: soc-card: add snd_soc_card_probe()
>   14 ASoC: soc-card: add snd_soc_card_late_probe()
>   15 ASoC: soc-card: add snd_soc_card_remove()
>   16 ASoC: soc-card: add snd_soc_card_set_bias_level()
>   17 ASoC: soc-card: add snd_soc_card_set_bias_level_post()
>   18 ASoC: soc-card: add snd_soc_card_add_dai_link()
>   19 ASoC: soc-card: add snd_soc_card_remove_dai_link()
LGTM, Morimoto-san.

Reviewed-by: Ranjani Sridharan <[e-mail]>

Mark Brown May 30, 2020, 1:18 a.m. UTC | #2

On 28 May 2020 10:47:07 +0900, Kuninori Morimoto wrote:
> Current ALSA SoC is handling snd_soc_card related operation,
> but it is implmemented directly without using function/macro,
> and at random place.
> 
> This v2 patch-set creates new snd_soc_card_xxx() functions
> which handles snd_soc_card related operation,
> and implmement these at new soc-card.c.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/19] ASoC: soc.h: convert bool to bit field for snd_soc_card
        commit: 317ec67593100f0ef0d017bcd73d42704d73fdb6
[02/19] ASoC: add soc-card.c
        commit: 1793936bc9081d541da2ecd2af83eded7e6212a7
[03/19] ASoC: soc-card: move snd_soc_card_get_kcontrol() to soc-card
        commit: 209c6cdfd28360f030f88ae9adb69f633e6bcd2d
[04/19] ASoC: soc-card: move snd_soc_card_jack_new() to soc-card
        commit: 3359e9b6fa3eafeeb79d5f0ec8a04f3fe6986db1
[05/19] ASoC: soc-card: move snd_soc_card_set/get_drvdata() to soc-card
        commit: 63efed582cc346c098adf6f5c852e2d5b0753783
[06/19] ASoC: soc-card: move snd_soc_card_get_codec_dai() to soc-card
        commit: 65a75718d68ea338b918328d471eff6f472192fc
[07/19] ASoC: soc-card: move snd_soc_card_subclass to soc-card
        commit: bf5bb8db5bf07b0a82cdcdc44e4494e55aaa4ed7
[08/19] ASoC: soc-card: add snd_soc_card_suspend_pre()
        commit: 130dc08c827db76f4a32fe7867075029fe9071d1
[09/19] ASoC: soc-card: add snd_soc_card_suspend_post()
        commit: d17b60b2c46750ebfb6ea39a2b02d988b97484eb
[10/19] ASoC: soc-card: add snd_soc_card_resume_pre()
        commit: 934c752c38b751663fe3dc18413db13e73b8b2b2
[11/19] ASoC: soc-card: add snd_soc_card_resume_post()
        commit: 739443d1f162ce80eb717c695e58302958b51239
[12/19] ASoC: soc-card: add probed bit field to snd_soc_card
        commit: 27f07cacc9f1ddf955b85e5746f967351ab0b40b
[13/19] ASoC: soc-card: add snd_soc_card_probe()
        commit: 73de4b026850da432b8bcfb73fc4af94674a8102
[14/19] ASoC: soc-card: add snd_soc_card_late_probe()
        commit: 5c0eac036dfd3e20dd09ab86343c3b2fb2a1ac86
[15/19] ASoC: soc-card: add snd_soc_card_remove()
        commit: b0275d956fab05a5088e20244c8d1eb433b7b90f
[16/19] ASoC: soc-card: add snd_soc_card_set_bias_level()
        commit: 39caefda0a30cac8284264e5031a0dd478510ced
[17/19] ASoC: soc-card: add snd_soc_card_set_bias_level_post()
        commit: d41278ea0579a8c1e216c5321e2d207705ab3b54
[18/19] ASoC: soc-card: add snd_soc_card_add_dai_link()
        commit: cbc7a6b5a87a129084c643455d16699ea490fd2f
[19/19] ASoC: soc-card: add snd_soc_card_remove_dai_link()
        commit: fcbbcc325bc2dd90212de19b520c190b6fbeddae

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark