mbox series

[0/2] osstest: update FreeBSD guest tests

Message ID 20200528102648.8724-1-roger.pau@citrix.com (mailing list archive)
Headers show
Series osstest: update FreeBSD guest tests | expand

Message

Roger Pau Monné May 28, 2020, 10:26 a.m. UTC
Hello,

The following series adds FreeBSD 11 and 12 guests tests to osstest.
ATM this is only tested on amd64, since the i386 versions had a bug.

The result can be seen at:

http://logs.test-lab.xenproject.org/osstest/logs/150428/

Note this flight has been generated without using the freebsd-{11,12}
hostflags and with the following env variable set:

OSSTEST_JOBS_ONLY=^(.*)freebsd(.*)$,build-(amd64|i386),build-(amd64|i386)-pvops

In order to limit the number of tests run. The runvar difference can be
see in patch #2.

Roger Pau Monne (2):
  freebsd10: refactor code to generate jobs
  freebsd: add FreeBSD 11 and 12 guest jobs

 make-flight | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

Comments

Ian Jackson June 3, 2020, 9:50 a.m. UTC | #1
Roger Pau Monne writes ("[PATCH 0/2] osstest: update FreeBSD guest tests"):
> The following series adds FreeBSD 11 and 12 guests tests to osstest.
> ATM this is only tested on amd64, since the i386 versions had a bug.
> 
> The result can be seen at:
> 
> http://logs.test-lab.xenproject.org/osstest/logs/150428/

Thanks, Roger.

I think that for this change I ought to get an ack from Paul as the
RM.

Paul: how do you want to handle osstest changes during the freeze ?  I
already pushed on Monday - without asking you - a series to fix a
problem with bisection which was stopping osstest from bisecting the
libvirt failure in the smoke tests.  Please let me know if you think I
should have checked with you.

I think we should take this change from Roger.  Right now we are still
waiting for even the smoke tests from staging to pass.  I don't
think this would interfere with that nor will it get in the way of the
osstest buster upgrade.

Thanks,
Ian.
Ian Jackson June 3, 2020, 9:52 a.m. UTC | #2
Roger Pau Monne writes ("[PATCH 0/2] osstest: update FreeBSD guest tests"):
> The following series adds FreeBSD 11 and 12 guests tests to osstest.
> ATM this is only tested on amd64, since the i386 versions had a bug.
> 
> The result can be seen at:
> 
> http://logs.test-lab.xenproject.org/osstest/logs/150428/

Oh, I forgot to say, both patches

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Durrant, Paul June 3, 2020, 10:37 a.m. UTC | #3
> -----Original Message-----
> From: Ian Jackson <ian.jackson@citrix.com>
> Sent: 03 June 2020 10:51
> To: Roger Pau Monne <roger.pau@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Paul Durrant <xadimgnik@gmail.com>
> Subject: Re: [PATCH 0/2] osstest: update FreeBSD guest tests
> 
> Roger Pau Monne writes ("[PATCH 0/2] osstest: update FreeBSD guest tests"):
> > The following series adds FreeBSD 11 and 12 guests tests to osstest.
> > ATM this is only tested on amd64, since the i386 versions had a bug.
> >
> > The result can be seen at:
> >
> > http://logs.test-lab.xenproject.org/osstest/logs/150428/
> 
> Thanks, Roger.
> 
> I think that for this change I ought to get an ack from Paul as the
> RM.
> 
> Paul: how do you want to handle osstest changes during the freeze ?  I
> already pushed on Monday - without asking you - a series to fix a
> problem with bisection which was stopping osstest from bisecting the
> libvirt failure in the smoke tests.  Please let me know if you think I
> should have checked with you.
> 

I'm no expert in osstest so I need to trust your judgement as to whether a patch is needed for 4.14 testing. That fix was clearly
necessary to help diagnose the libvirt issue so I don't think you need check with me for such things.

> I think we should take this change from Roger.  Right now we are still
> waiting for even the smoke tests from staging to pass.  I don't
> think this would interfere with that nor will it get in the way of the
> osstest buster upgrade.

We should certainly try to limit changes to only those where really are beneficial for 4.14 at this stage, but it looks like this
series is adding more relevant testing (i.e. on newer OS) so I think it qualifies.

  Paul

> 
> Thanks,
> Ian.
Ian Jackson July 17, 2020, 4:28 p.m. UTC | #4
Ian Jackson writes ("Re: [PATCH 0/2] osstest: update FreeBSD guest tests"):
> Roger Pau Monne writes ("[PATCH 0/2] osstest: update FreeBSD guest tests"):
> > The following series adds FreeBSD 11 and 12 guests tests to osstest.
> > ATM this is only tested on amd64, since the i386 versions had a bug.
> > 
> > The result can be seen at:
> > 
> > http://logs.test-lab.xenproject.org/osstest/logs/150428/
> 
> Oh, I forgot to say, both patches
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Thanks, pushed.

Ian.